Re: RFR: JDK-8325189: Enable this-escape javac warning in java.base

2024-02-03 Thread Alan Bateman
On Fri, 2 Feb 2024 23:36:41 GMT, Joe Darcy wrote: > After the "this-escape" lint warning was added to javac (JDK-8015831), the > base module was not updated to be able to compile with this warning enabled. > This PR makes the necessary changes to allow the base module to build with > the

Re: RFR: 8325194: GHA: Add macOS M1 testing [v4]

2024-02-03 Thread Aleksey Shipilev
On Sat, 3 Feb 2024 16:22:14 GMT, George Adams wrote: >> Now that macOS M1 executors are [available in GitHub >> actions](https://github.blog/changelog/2024-01-30-github-actions-introducing-the-new-m1-macos-runner-available-to-open-source/) >> it makes sense to move the build to run on M1

Re: RFR: 8325194: GHA: Add macOS M1 testing [v4]

2024-02-03 Thread George Adams
On Sat, 3 Feb 2024 21:45:27 GMT, Aleksey Shipilev wrote: >> George Adams has updated the pull request incrementally with one additional >> commit since the last revision: >> >> update copyright headers > > .github/actions/get-jtreg/action.yml line 66: > >> 64: fi >> 65: #

Re: RFR: 8325194: GHA: Add macOS M1 testing [v5]

2024-02-03 Thread George Adams
> Now that macOS M1 executors are [available in GitHub > actions](https://github.blog/changelog/2024-01-30-github-actions-introducing-the-new-m1-macos-runner-available-to-open-source/) > it makes sense to move the build to run on M1 (rather than cross-compiled) > and also enable testing on the

Re: RFR: 8325194: GHA: Add macOS M1 testing [v4]

2024-02-03 Thread George Adams
> Now that macOS M1 executors are [available in GitHub > actions](https://github.blog/changelog/2024-01-30-github-actions-introducing-the-new-m1-macos-runner-available-to-open-source/) > it makes sense to move the build to run on M1 (rather than cross-compiled) > and also enable testing on the

Re: RFR: 8325194: GHA: Add macOS M1 testing [v3]

2024-02-03 Thread George Adams
On Sat, 3 Feb 2024 14:09:50 GMT, Christoph Langer wrote: > Do we maybe want to go to 'macos-14' on both MacOS architectures? Maybe do it > in a prior, separate change? Noting that macos-14 is arm64 only in GitHub so such a change might not be intentional in this scenario. > Other than that

Re: RFR: 8325194: GHA: Add macOS M1 testing [v3]

2024-02-03 Thread Christoph Langer
On Sat, 3 Feb 2024 11:49:24 GMT, George Adams wrote: >> Now that macOS M1 executors are [available in GitHub >> actions](https://github.blog/changelog/2024-01-30-github-actions-introducing-the-new-m1-macos-runner-available-to-open-source/) >> it makes sense to move the build to run on M1

Re: RFR: 8325194: GHA: Add macOS M1 testing [v3]

2024-02-03 Thread George Adams
> Now that macOS M1 executors are [available in GitHub > actions](https://github.blog/changelog/2024-01-30-github-actions-introducing-the-new-m1-macos-runner-available-to-open-source/) > it makes sense to move the build to run on M1 (rather than cross-compiled) > and also enable testing on the

Re: RFR: 8325194: GHA: Add macOS M1 testing [v2]

2024-02-03 Thread George Adams
> Now that macOS M1 executors are [available in GitHub > actions](https://github.blog/changelog/2024-01-30-github-actions-introducing-the-new-m1-macos-runner-available-to-open-source/) > it makes sense to move the build to run on M1 (rather than cross-compiled) > and also enable testing on the

RFR: 8325194: GHA: Add macOS M1 testing

2024-02-03 Thread George Adams
Now that macOS M1 executors are [available in GitHub actions](https://github.blog/changelog/2024-01-30-github-actions-introducing-the-new-m1-macos-runner-available-to-open-source/) it makes sense to move the build to run on M1 (rather than cross-compiled) and also enable testing on the

Re: RFR: 8324243: Fix GCC 14 build [v3]

2024-02-03 Thread Sam James
> This fixes building with GCC 14: > * Cherry-pick a fix from Harfbuzz upstream > * Apply other `-Wcalloc-transposed-args` fixes to the JDK sources > > -Wcalloc-transposed-args errors out with GCC 14 as the OpenJDK build uses > -Werror. > > The calloc prototype is: > > void *calloc(size_t