On Mon, 5 Feb 2024 03:21:35 GMT, Kim Barrett wrote:
>> Inspired by (the later backed-out)
>> [JDK-8296115](https://bugs.openjdk.org/browse/JDK-8296115), I propose to
>> enable `-Wpedantic` for clang. This has already found some irregularities in
>> the code, like mistakenly using `#import`
On Fri, 2 Feb 2024 15:22:03 GMT, Magnus Ihse Bursie wrote:
> Inspired by (the later backed-out)
> [JDK-8296115](https://bugs.openjdk.org/browse/JDK-8296115), I propose to
> enable `-Wpedantic` for clang. This has already found some irregularities in
> the code, like mistakenly using `#import`
On Sun, 4 Feb 2024 22:52:19 GMT, Magnus Ihse Bursie wrote:
> > Guess I could work on the gcc counterpart and find a way around the
> > inability to disable -Wpedantic with it in tandem with this change...
>
> I don't think that is possible. The double semicolon rule can only be
> disabled by
On Mon, 5 Feb 2024 03:07:43 GMT, Kim Barrett wrote:
> I consider the "format '%p' expects argument of type 'void*" warnings to be
> not at all helpful. Fortunately we don't use '%p' in HotSpot,
We do use it in hotspot. Not a huge amount as we have the legacy format
specifiers for PTR_FORMAT
On Fri, 2 Feb 2024 15:22:03 GMT, Magnus Ihse Bursie wrote:
> Inspired by (the later backed-out)
> [JDK-8296115](https://bugs.openjdk.org/browse/JDK-8296115), I propose to
> enable `-Wpedantic` for clang. This has already found some irregularities in
> the code, like mistakenly using `#import`
On Fri, 2 Feb 2024 15:22:03 GMT, Magnus Ihse Bursie wrote:
> #define DEBUG_ONLY(code) code;
>
> DEBUG_ONLY(foo());
> ```
>
> will result in a `; ;`. This breaks the C standard, but is benign, and we use
> it all over the place. On clang, we can ignore this by `-Wno-extra-semi`, but
> this is
On Fri, 2 Feb 2024 15:59:56 GMT, Julian Waters wrote:
> Guess I could work on the gcc counterpart and find a way around the inability
> to disable -Wpedantic with it in tandem with this change...
I don't think that is possible. The double semicolon rule can only be disabled
by disabling
On Sat, 3 Feb 2024 21:55:25 GMT, George Adams wrote:
>> Now that macOS M1 executors are [available in GitHub
>> actions](https://github.blog/changelog/2024-01-30-github-actions-introducing-the-new-m1-macos-runner-available-to-open-source/)
>> it makes sense to move the build to run on M1
On Fri, 2 Feb 2024 15:22:03 GMT, Magnus Ihse Bursie wrote:
> Inspired by (the later backed-out)
> [JDK-8296115](https://bugs.openjdk.org/browse/JDK-8296115), I propose to
> enable `-Wpedantic` for clang. This has already found some irregularities in
> the code, like mistakenly using `#import`
On Fri, 2 Feb 2024 09:26:28 GMT, Kim Barrett wrote:
>> Sam James has updated the pull request incrementally with three additional
>> commits since the last revision:
>>
>> - fix whitespace
>> - Revert "harfbuzz: Cherry-pick upstream fix for GCC 14"
>>
>>This reverts commit
On Sat, 3 Feb 2024 10:07:26 GMT, Sam James wrote:
>> This fixes building with GCC 14:
>> * ~Cherry-pick a fix from Harfbuzz upstream~
>> * Apply other `-Wcalloc-transposed-args` fixes to the JDK sources
>>
>> -Wcalloc-transposed-args errors out with GCC 14 as the OpenJDK build uses
>> -Werror.
On Fri, 2 Feb 2024 06:35:26 GMT, Sam James wrote:
>> This fixes building with GCC 14:
>> * ~Cherry-pick a fix from Harfbuzz upstream~
>> * Apply other `-Wcalloc-transposed-args` fixes to the JDK sources
>>
>> -Wcalloc-transposed-args errors out with GCC 14 as the OpenJDK build uses
>> -Werror.
On Sat, 3 Feb 2024 21:45:27 GMT, Aleksey Shipilev wrote:
>> George Adams has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> update copyright headers
>
> .github/actions/get-jtreg/action.yml line 66:
>
>> 64: fi
>> 65: #
13 matches
Mail list logo
