Re: RFR: 8326891: Prefer RPATH over RUNPATH for $ORIGIN rpaths in internal JDK binaries

2024-02-28 Thread David Holmes
On Wed, 28 Feb 2024 19:29:13 GMT, Erik Joelsson wrote: > There is no supported usecase that I can think of for injecting other > versions of such libraries in a JDK distribution. I can imagine it could be used to allow "hot patching" of the installed JDK/JRE. Whether anyone has ever needed to

Re: RFR: 8326831 Clarify test harness control variables in make help

2024-02-28 Thread Guoxiong Li
On Tue, 27 Feb 2024 13:55:53 GMT, Ludvig Janiuk wrote: > Clarifying text in `make help` output on how to list variables for e.g. > JTREG='...'. > I have no idea what causes it. Nevermind. The patch looks good. - Marked as reviewed by gli (Committer). PR Review: https://git.openj

Integrated: 8326953: Race in creation of win-exports.def with static-libs

2024-02-28 Thread Magnus Ihse Bursie
On Wed, 28 Feb 2024 12:26:54 GMT, Magnus Ihse Bursie wrote: > We have seen a build failure along the lines of: > > /usr/bin/mv: cannot move > '.../build/windows-x64-open-debug/hotspot/variant-server/libjvm/win-exports.def.tmp' > to > '.../build/windows-x64-open-debug/hotspot/variant-server/l

Re: RFR: 8326953: Race in creation of win-exports.def with static-libs [v3]

2024-02-28 Thread David Holmes
On Wed, 28 Feb 2024 17:06:17 GMT, Magnus Ihse Bursie wrote: >> We have seen a build failure along the lines of: >> >> /usr/bin/mv: cannot move >> '.../build/windows-x64-open-debug/hotspot/variant-server/libjvm/win-exports.def.tmp' >> to >> '.../build/windows-x64-open-debug/hotspot/variant-se

RFR: 8326891: Prefer RPATH over RUNPATH for $ORIGIN rpaths in internal JDK binaries

2024-02-28 Thread Erik Joelsson
Executables and dynamic libraries on Linux can encode a search path that the dynamic linker will use when looking up library dependencies, generally referred to as an "rpath". In the JDK we use this with the $ORIGIN feature to set search paths relative to the location of the binary itself. Typic

Re: RFR: 8325881: Require minimum gcc version 10

2024-02-28 Thread Aleksey Shipilev
On Sat, 17 Feb 2024 08:28:56 GMT, Kim Barrett wrote: > Please review this change that updates the minimum supported version of gcc > to be used for building OpenJDK from 6.0 to 10.0. > > This permits enabling C++17 (JDK-8314488), though gcc 9.0 might suffice for > that. A minimum of gcc 10 also

Re: RFR: 8326953: Race in creation of win-exports.def with static-libs [v3]

2024-02-28 Thread Erik Joelsson
On Wed, 28 Feb 2024 17:06:17 GMT, Magnus Ihse Bursie wrote: >> We have seen a build failure along the lines of: >> >> /usr/bin/mv: cannot move >> '.../build/windows-x64-open-debug/hotspot/variant-server/libjvm/win-exports.def.tmp' >> to >> '.../build/windows-x64-open-debug/hotspot/variant-se

Re: RFR: 8326953: Race in creation of win-exports.def with static-libs [v3]

2024-02-28 Thread Magnus Ihse Bursie
On Wed, 28 Feb 2024 17:06:17 GMT, Magnus Ihse Bursie wrote: >> We have seen a build failure along the lines of: >> >> /usr/bin/mv: cannot move >> '.../build/windows-x64-open-debug/hotspot/variant-server/libjvm/win-exports.def.tmp' >> to >> '.../build/windows-x64-open-debug/hotspot/variant-se

Re: RFR: JDK-8298405: Support Markdown in Documentation Comments [v43]

2024-02-28 Thread Jonathan Gibbons
On Wed, 28 Feb 2024 15:54:38 GMT, Hannes Wallnöfer wrote: >> Jonathan Gibbons has updated the pull request incrementally with one >> additional commit since the last revision: >> >> Refactor most of TestMarkdown.java into separate tests, grouped by >> functionality > > src/jdk.javadoc/share/

Re: RFR: 8326953: Possible race in creation of win-exports.def [v3]

2024-02-28 Thread Magnus Ihse Bursie
> We have seen a build failure along the lines of: > > /usr/bin/mv: cannot move > '.../build/windows-x64-open-debug/hotspot/variant-server/libjvm/win-exports.def.tmp' > to > '.../build/windows-x64-open-debug/hotspot/variant-server/libjvm/win-exports.def': > No such file or directory > > on W

Re: RFR: JDK-8298405: Support Markdown in Documentation Comments [v43]

2024-02-28 Thread Hannes Wallnöfer
On Fri, 23 Feb 2024 22:27:43 GMT, Jonathan Gibbons wrote: >> Please review a patch to add support for Markdown syntax in documentation >> comments, as described in the associated JEP. >> >> Notable features: >> >> * support for `///` documentation comments in `JavaTokenizer` >> * new module `j

Re: RFR: JDK-8298405: Support Markdown in Documentation Comments [v43]

2024-02-28 Thread Hannes Wallnöfer
On Fri, 23 Feb 2024 22:27:43 GMT, Jonathan Gibbons wrote: >> Please review a patch to add support for Markdown syntax in documentation >> comments, as described in the associated JEP. >> >> Notable features: >> >> * support for `///` documentation comments in `JavaTokenizer` >> * new module `j

Re: RFR: 8326964: Remove Eclipse Shared Workspaces [v2]

2024-02-28 Thread Julian Waters
> WIP Julian Waters has updated the pull request incrementally with one additional commit since the last revision: Remove shared targets - Changes: - all: https://git.openjdk.org/jdk/pull/18046/files - new: https://git.openjdk.org/jdk/pull/18046/files/aefff3e8..0d29a355 Webr

RFR: 8326964: Remove Eclipse Shared Workspaces

2024-02-28 Thread Julian Waters
WIP - Commit messages: - 8326964 Changes: https://git.openjdk.org/jdk/pull/18046/files Webrev: https://webrevs.openjdk.org/?repo=jdk&pr=18046&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8326964 Stats: 3 lines in 1 file changed: 0 ins; 3 del; 0 mod Patch: https://git.o

Re: RFR: 8326953: Possible race in creation of win-exports.def [v2]

2024-02-28 Thread Erik Joelsson
On Wed, 28 Feb 2024 14:53:13 GMT, Magnus Ihse Bursie wrote: >> We have seen a build failure along the lines of: >> >> /usr/bin/mv: cannot move >> '.../build/windows-x64-open-debug/hotspot/variant-server/libjvm/win-exports.def.tmp' >> to >> '.../build/windows-x64-open-debug/hotspot/variant-se

Re: RFR: 8326947: Minimize MakeBase.gmk

2024-02-28 Thread Magnus Ihse Bursie
On Wed, 28 Feb 2024 11:24:06 GMT, Magnus Ihse Bursie wrote: > This is part of a general "spring cleaning" of the build system, addressing > old code that has bit-rotted, been subject to lava flow, or just had bad or > smelly code that we've never gotten around to fix. > > This particular patch

Re: RFR: 8326953: Possible race in creation of win-exports.def [v2]

2024-02-28 Thread Magnus Ihse Bursie
> We have seen a build failure along the lines of: > > /usr/bin/mv: cannot move > '.../build/windows-x64-open-debug/hotspot/variant-server/libjvm/win-exports.def.tmp' > to > '.../build/windows-x64-open-debug/hotspot/variant-server/libjvm/win-exports.def': > No such file or directory > > on W

Re: RFR: JDK-8298405: Support Markdown in Documentation Comments [v43]

2024-02-28 Thread Hannes Wallnöfer
On Fri, 23 Feb 2024 22:27:43 GMT, Jonathan Gibbons wrote: >> Please review a patch to add support for Markdown syntax in documentation >> comments, as described in the associated JEP. >> >> Notable features: >> >> * support for `///` documentation comments in `JavaTokenizer` >> * new module `j

Re: RFR: 8326831 Clarify test harness control variables in make help

2024-02-28 Thread Ludvig Janiuk
On Tue, 27 Feb 2024 13:55:53 GMT, Ludvig Janiuk wrote: > Clarifying text in `make help` output on how to list variables for e.g. > JTREG='...'. It's interesting that the order of those two lines can change. I have no idea what causes it. - PR Comment: https://git.openjdk.org/jdk/

Re: RFR: 8326953: Possible race in creation of win-exports.def

2024-02-28 Thread Magnus Ihse Bursie
On Wed, 28 Feb 2024 12:26:54 GMT, Magnus Ihse Bursie wrote: > We have seen a build failure along the lines of: > > /usr/bin/mv: cannot move > '.../build/windows-x64-open-debug/hotspot/variant-server/libjvm/win-exports.def.tmp' > to > '.../build/windows-x64-open-debug/hotspot/variant-server/l

Re: RFR: 8326953: Possible race in creation of win-exports.def

2024-02-28 Thread Magnus Ihse Bursie
On Wed, 28 Feb 2024 13:12:14 GMT, Julian Waters wrote: >> We have seen a build failure along the lines of: >> >> /usr/bin/mv: cannot move >> '.../build/windows-x64-open-debug/hotspot/variant-server/libjvm/win-exports.def.tmp' >> to >> '.../build/windows-x64-open-debug/hotspot/variant-server/

Re: RFR: 8326953: Possible race in creation of win-exports.def

2024-02-28 Thread Julian Waters
On Wed, 28 Feb 2024 12:26:54 GMT, Magnus Ihse Bursie wrote: > We have seen a build failure along the lines of: > > /usr/bin/mv: cannot move > '.../build/windows-x64-open-debug/hotspot/variant-server/libjvm/win-exports.def.tmp' > to > '.../build/windows-x64-open-debug/hotspot/variant-server/l

Re: RFR: 8326947: Minimize MakeBase.gmk

2024-02-28 Thread Erik Joelsson
On Wed, 28 Feb 2024 11:24:06 GMT, Magnus Ihse Bursie wrote: > This is part of a general "spring cleaning" of the build system, addressing > old code that has bit-rotted, been subject to lava flow, or just had bad or > smelly code that we've never gotten around to fix. > > This particular patch

Re: RFR: 8326953: Possible race in creation of win-exports.def

2024-02-28 Thread Magnus Ihse Bursie
On Wed, 28 Feb 2024 12:26:54 GMT, Magnus Ihse Bursie wrote: > We have seen a build failure along the lines of: > > /usr/bin/mv: cannot move > '.../build/windows-x64-open-debug/hotspot/variant-server/libjvm/win-exports.def.tmp' > to > '.../build/windows-x64-open-debug/hotspot/variant-server/l

RFR: 8326953: Possible race in creation of win-exports.def

2024-02-28 Thread Magnus Ihse Bursie
We have seen a build failure along the lines of: /usr/bin/mv: cannot move '.../build/windows-x64-open-debug/hotspot/variant-server/libjvm/win-exports.def.tmp' to '.../build/windows-x64-open-debug/hotspot/variant-server/libjvm/win-exports.def': No such file or directory on Windows. My guess

Re: RFR: 8326831 Clarify test harness control variables in make help

2024-02-28 Thread Guoxiong Li
On Tue, 27 Feb 2024 13:55:53 GMT, Ludvig Janiuk wrote: > Clarifying text in `make help` output on how to list variables for e.g. > JTREG='...'. I use the command `make test-only JTREG=help` locally, the outputed message seems an error (shown below). Does it work as expected? Building target

Re: RFR: 8326947: Minimize MakeBase.gmk

2024-02-28 Thread Magnus Ihse Bursie
On Wed, 28 Feb 2024 11:24:06 GMT, Magnus Ihse Bursie wrote: > This is part of a general "spring cleaning" of the build system, addressing > old code that has bit-rotted, been subject to lava flow, or just had bad or > smelly code that we've never gotten around to fix. > > This particular patch

RFR: 8326947: Minimize MakeBase.gmk

2024-02-28 Thread Magnus Ihse Bursie
This is part of a general "spring cleaning" of the build system, addressing old code that has bit-rotted, been subject to lava flow, or just had bad or smelly code that we've never gotten around to fix. This particular patch tries to make MakeBase truly minimal; only including the core parts of

Integrated: 8326509: Clean up JNIEXPORT in Hotspot after JDK-8017234

2024-02-28 Thread Magnus Ihse Bursie
On Thu, 22 Feb 2024 16:28:20 GMT, Magnus Ihse Bursie wrote: > Once [JDK-8017234](https://bugs.openjdk.org/browse/JDK-8017234) has been > integrated, it is possible to do some cleanup. The goal of > [JDK-8017234](https://bugs.openjdk.org/browse/JDK-8017234) was to not change > any behavior, eve

Re: RFR: 8325881: Require minimum gcc version 10

2024-02-28 Thread Aleksey Shipilev
On Sat, 17 Feb 2024 08:28:56 GMT, Kim Barrett wrote: > Please review this change that updates the minimum supported version of gcc > to be used for building OpenJDK from 6.0 to 10.0. > > This permits enabling C++17 (JDK-8314488), though gcc 9.0 might suffice for > that. A minimum of gcc 10 also

Re: RFR: 8326831 Clarify test harness control variables in make help

2024-02-28 Thread Ludvig Janiuk
On Tue, 27 Feb 2024 13:55:53 GMT, Ludvig Janiuk wrote: > Clarifying text in `make help` output on how to list variables for e.g. > JTREG='...'. Thanks for the insight Erik! - PR Comment: https://git.openjdk.org/jdk/pull/18028#issuecomment-1968538692

Integrated: 8326685: Linux builds not reproducible if two builds configured in different build folders

2024-02-28 Thread Andrew Leonard
On Mon, 26 Feb 2024 16:00:42 GMT, Andrew Leonard wrote: > Adds Linux -fdebug-prefix-map'ing for SUPPORT_OUTPUTDIR and HOTSPOT_OUTPUTDIR > when absolute paths are not allowed in the binaries, thus making the building > of a JDK identically reproducible from different build directories. This pul

Re: RFR: 8325881: Require minimum gcc version 10

2024-02-28 Thread Martin Doerr
On Sat, 17 Feb 2024 08:28:56 GMT, Kim Barrett wrote: > Please review this change that updates the minimum supported version of gcc > to be used for building OpenJDK from 6.0 to 10.0. > > This permits enabling C++17 (JDK-8314488), though gcc 9.0 might suffice for > that. A minimum of gcc 10 also