Re: undefined symbols in libjvm.so

2024-05-09 Thread David Holmes
On 8/05/2024 6:55 am, Vladimir Petko wrote: Hi, This is probably an edge-case with assembly-defined symbols. -Wl,z,defs prevents linking a shared library with undefined imports, but does nothing about symbols exported by the library itself that are undefined. -Wl,--allow-shlib-undefined allows

Re: RFR: 8331952: --enable-compatible-cds-alignment should be enabled by default

2024-05-09 Thread Jaikiran Pai
On Fri, 10 May 2024 01:08:29 GMT, xiaotaonan wrote: >> --enable-compatible-cds-alignment should be enabled by default > > @lgxbslgx Hello @xiaotaonan, the JBS issue against which this PR has been opened has already been closed as a duplicate of https://bugs.openjdk.org/browse/JDK-8331942, whic

Re: RFR: 8331942: On Linux aarch64, CDS archives should be using 64K alignment by default

2024-05-09 Thread Thomas Stuefe
On Thu, 9 May 2024 17:05:40 GMT, Ioi Lam wrote: >> On Linux aarch64, a JVM may encounter three different page sizes: 4K, 64K, >> and (when run on Mac M1 hardware) 16K. >> >> Since forgetting to specify `--enable-compatible-cds-alignment` is a common >> error that is only noticed when running t

Integrated: 8331942: On Linux aarch64, CDS archives should be using 64K alignment by default

2024-05-09 Thread Thomas Stuefe
On Wed, 8 May 2024 15:14:16 GMT, Thomas Stuefe wrote: > On Linux aarch64, a JVM may encounter three different page sizes: 4K, 64K, > and (when run on Mac M1 hardware) 16K. > > Since forgetting to specify `--enable-compatible-cds-alignment` is a common > error that is only noticed when running

Re: RFR: 8331952: --enable-compatible-cds-alignment should be enabled by default

2024-05-09 Thread xiaotaonan
On Thu, 9 May 2024 01:07:26 GMT, xiaotaonan wrote: > --enable-compatible-cds-alignment should be enabled by default @lgxbslgx - PR Comment: https://git.openjdk.org/jdk/pull/19150#issuecomment-2103672340

Re: RFR: 8330988: Implementation of 8288293: Windows/gcc Port for hsdis

2024-05-09 Thread Julian Waters
On Wed, 24 Apr 2024 09:15:21 GMT, Magnus Ihse Bursie wrote: >> WIP >> >> This changeset contains hsdis for Windows/gcc Port. It supports both the >> binutils and capstone backends, though the LLVM backend is left out due to >> compatibility issues encountered during the build. Currently, which

Re: RFR: 8330182: Start of release updates for JDK 24 [v4]

2024-05-09 Thread Joe Darcy
> Get JDK 24 underway. Joe Darcy has updated the pull request with a new target base due to a merge or a rebase. The pull request now contains ten commits: - Adjust test for deprecated options. - Merge branch 'master' into JDK-8330188 - Update deprecated options test. - Merge branch 'master'

Re: RFR: 8329538: Accelerate P256 on x86_64 using Montgomery intrinsic [v9]

2024-05-09 Thread Volodymyr Paprotski
> Performance. Before: > > Benchmark(algorithm) (dataSize) (keyLength) > (provider) Mode Cnt ScoreError Units > SignatureBench.ECDSA.signSHA256withECDSA1024 256 > thrpt3 6443.934 ± 6.491 ops/s > SignatureBench.ECDSA.

Re: RFR: 8329538: Accelerate P256 on x86_64 using Montgomery intrinsic [v7]

2024-05-09 Thread Volodymyr Paprotski
On Thu, 9 May 2024 23:36:03 GMT, Anthony Scarpino wrote: >> Volodymyr Paprotski has updated the pull request incrementally with one >> additional commit since the last revision: >> >> whitespace > > src/java.base/share/classes/sun/security/ec/ECOperations.java line 701: > >> 699:

Re: RFR: 8329538: Accelerate P256 on x86_64 using Montgomery intrinsic [v8]

2024-05-09 Thread Volodymyr Paprotski
> Performance. Before: > > Benchmark(algorithm) (dataSize) (keyLength) > (provider) Mode Cnt ScoreError Units > SignatureBench.ECDSA.signSHA256withECDSA1024 256 > thrpt3 6443.934 ± 6.491 ops/s > SignatureBench.ECDSA.

Re: RFR: 8329538: Accelerate P256 on x86_64 using Montgomery intrinsic [v7]

2024-05-09 Thread Anthony Scarpino
On Thu, 9 May 2024 22:23:02 GMT, Volodymyr Paprotski wrote: >> Performance. Before: >> >> Benchmark(algorithm) (dataSize) (keyLength) >> (provider) Mode Cnt ScoreError Units >> SignatureBench.ECDSA.signSHA256withECDSA1024 256 >

Integrated: 8332008: Enable issuestitle check

2024-05-09 Thread Zhao Song
On Thu, 9 May 2024 20:53:59 GMT, Zhao Song wrote: > As requested in [SKARA-2170](https://bugs.openjdk.org/browse/SKARA-2170) and > [SKARA-2248](https://bugs.openjdk.org/browse/SKARA-2248), now Skara bot is > able to warn on trailing periods or leading lowercase letter in issue titles. > I am go

Re: RFR: 8332008: Enable issuestitle check

2024-05-09 Thread Zhao Song
On Thu, 9 May 2024 20:53:59 GMT, Zhao Song wrote: > As requested in [SKARA-2170](https://bugs.openjdk.org/browse/SKARA-2170) and > [SKARA-2248](https://bugs.openjdk.org/browse/SKARA-2248), now Skara bot is > able to warn on trailing periods or leading lowercase letter in issue titles. > I am go

Re: RFR: 8332008: Enable issuestitle check

2024-05-09 Thread Erik Joelsson
On Thu, 9 May 2024 20:53:59 GMT, Zhao Song wrote: > As requested in [SKARA-2170](https://bugs.openjdk.org/browse/SKARA-2170) and > [SKARA-2248](https://bugs.openjdk.org/browse/SKARA-2248), now Skara bot is > able to warn on trailing periods or leading lowercase letter in issue titles. > I am go

Re: RFR: 8329538: Accelerate P256 on x86_64 using Montgomery intrinsic [v7]

2024-05-09 Thread Volodymyr Paprotski
> Performance. Before: > > Benchmark(algorithm) (dataSize) (keyLength) > (provider) Mode Cnt ScoreError Units > SignatureBench.ECDSA.signSHA256withECDSA1024 256 > thrpt3 6443.934 ± 6.491 ops/s > SignatureBench.ECDSA.

RFR: 8332008: Enable issuestitle check

2024-05-09 Thread Zhao Song
As requested in [SKARA-2170](https://bugs.openjdk.org/browse/SKARA-2170) and [SKARA-2248](https://bugs.openjdk.org/browse/SKARA-2248), now Skara bot is able to warn on trailing periods or leading lowercase letter in issue titles. I am going to update the jcheck configuration to configure issuesti

Re: RFR: 8331942: On Linux aarch64, CDS archives should be using 64K alignment by default

2024-05-09 Thread Ioi Lam
On Wed, 8 May 2024 15:14:16 GMT, Thomas Stuefe wrote: > On Linux aarch64, a JVM may encounter three different page sizes: 4K, 64K, > and (when run on Mac M1 hardware) 16K. > > Since forgetting to specify `--enable-compatible-cds-alignment` is a common > error that is only noticed when running

Integrated: 8327476: Upgrade JLine to 3.26.1

2024-05-09 Thread Jan Lahoda
On Wed, 6 Mar 2024 21:20:50 GMT, Jan Lahoda wrote: > This is a patch that: > a) upgrades the JLine inside the JDK to 3.25.1 > b) since the new version of JLine has a FFM backend, our custom native > backends are removed, and replaced with the FFM backend > > Some changes had to be made to the o

Re: RFR: 8331952: --enable-compatible-cds-alignment should be enabled by default

2024-05-09 Thread Erik Joelsson
On Thu, 9 May 2024 01:07:26 GMT, xiaotaonan wrote: > --enable-compatible-cds-alignment should be enabled by default Build change looks ok. I think this should be approved by someone from hotspot as well. - Marked as reviewed by erikj (Reviewer). PR Review: https://git.openjdk.org

Re: RFR: 8331942: On Linux aarch64, CDS archives should be using 64K alignment by default

2024-05-09 Thread Thomas Stuefe
On Thu, 9 May 2024 05:04:47 GMT, Thomas Stuefe wrote: >> On Linux aarch64, a JVM may encounter three different page sizes: 4K, 64K, >> and (when run on Mac M1 hardware) 16K. >> >> Since forgetting to specify `--enable-compatible-cds-alignment` is a common >> error that is only noticed when run

Re: RFR: 8331942: On Linux aarch64, CDS archives should be using 64K alignment by default

2024-05-09 Thread Andrew Dinn
On Thu, 9 May 2024 05:04:47 GMT, Thomas Stuefe wrote: >> On Linux aarch64, a JVM may encounter three different page sizes: 4K, 64K, >> and (when run on Mac M1 hardware) 16K. >> >> Since forgetting to specify `--enable-compatible-cds-alignment` is a common >> error that is only noticed when run

Re: RFR: 8330988: Implementation of 8288293: Windows/gcc Port for hsdis

2024-05-09 Thread Julian Waters
On Wed, 24 Apr 2024 09:15:21 GMT, Magnus Ihse Bursie wrote: >> WIP >> >> This changeset contains hsdis for Windows/gcc Port. It supports both the >> binutils and capstone backends, though the LLVM backend is left out due to >> compatibility issues encountered during the build. Currently, which

Re: RFR: 8330988: Implementation of 8288293: Windows/gcc Port for hsdis [v2]

2024-05-09 Thread Julian Waters
> WIP > > This changeset contains hsdis for Windows/gcc Port. It supports both the > binutils and capstone backends, though the LLVM backend is left out due to > compatibility issues encountered during the build. Currently, which gcc > distributions are supported is still to be clarified, as se

Re: RFR: 8330988: Implementation of 8288293: Windows/gcc Port for hsdis

2024-05-09 Thread Julian Waters
On Wed, 24 Apr 2024 09:15:21 GMT, Magnus Ihse Bursie wrote: >> WIP >> >> This changeset contains hsdis for Windows/gcc Port. It supports both the >> binutils and capstone backends, though the LLVM backend is left out due to >> compatibility issues encountered during the build. Currently, which