Integrated: 8336091: Fix HTML warnings in the generated HTML files

2024-07-17 Thread Nizar Benalla
On Tue, 16 Jul 2024 14:29:25 GMT, Nizar Benalla wrote: > Can I please have a review for this bug fix? This regex to avoid duplicate > "style" tags in our generated HTML, It can now match it even if the text > contains a newline character. > > Thanks in advance! This pull request has now

Re: RFR: 8336498: [macos] [build]: install-file macro may run into permission denied error

2024-07-17 Thread Christoph Langer
On Tue, 16 Jul 2024 20:50:32 GMT, Lutz Schmidt wrote: > On MacOS, files may have extended attributes attached. These attributes are > copied together with the files. To prevent issues during further processing, > the extended attributes of the copies must be removed. This action was >

Integrated: 8335921: Fix HotSpot VM build without JVMTI

2024-07-17 Thread Vladimir Kozlov
On Wed, 17 Jul 2024 03:37:36 GMT, Vladimir Kozlov wrote: > Citing David Holmes from bug report: > "We provided the ability to leave out certain VM services (JVMTI, GC's other > than serial, ...) as part of the design of the MinimalVM to support Java SE > Embedded, along with the Compact

Re: RFR: 8335921: Fix HotSpot VM build without JVMTI

2024-07-17 Thread Vladimir Kozlov
On Wed, 17 Jul 2024 03:37:36 GMT, Vladimir Kozlov wrote: > Citing David Holmes from bug report: > "We provided the ability to leave out certain VM services (JVMTI, GC's other > than serial, ...) as part of the design of the MinimalVM to support Java SE > Embedded, along with the Compact

Integrated: 8336040: Missing closing anchor element in Docs.gmk

2024-07-17 Thread Nizar Benalla
On Tue, 16 Jul 2024 14:12:54 GMT, Nizar Benalla wrote: > Can I please have a review for this bug fix to make file used to generate the > OpenJDK documentation. It adds the missing `` tag after `OTHER > SPECIFICATIONS`, this should help remove some HTML warnings in out generated > docs. > >

Re: RFR: 8336040: Missing closing anchor element in Docs.gmk

2024-07-17 Thread duke
On Tue, 16 Jul 2024 14:12:54 GMT, Nizar Benalla wrote: > Can I please have a review for this bug fix to make file used to generate the > OpenJDK documentation. It adds the missing `` tag after `OTHER > SPECIFICATIONS`, this should help remove some HTML warnings in out generated > docs. > >

Re: RFR: 8336040: Missing closing anchor element in Docs.gmk

2024-07-17 Thread Nizar Benalla
On Tue, 16 Jul 2024 14:12:54 GMT, Nizar Benalla wrote: > Can I please have a review for this bug fix to make file used to generate the > OpenJDK documentation. It adds the missing `` tag after `OTHER > SPECIFICATIONS`, this should help remove some HTML warnings in out generated > docs. > >

Re: RFR: 8336091: Fix HTML warnings in the generated HTML files

2024-07-17 Thread duke
On Tue, 16 Jul 2024 14:29:25 GMT, Nizar Benalla wrote: > Can I please have a review for this bug fix? This regex to avoid duplicate > "style" tags in our generated HTML, It can now match it even if the text > contains a newline character. > > Thanks in advance! @nizarbenalla Your change

Re: RFR: 8336091: Fix HTML warnings in the generated HTML files

2024-07-17 Thread Nizar Benalla
On Tue, 16 Jul 2024 14:29:25 GMT, Nizar Benalla wrote: > Can I please have a review for this bug fix? This regex to avoid duplicate > "style" tags in our generated HTML, It can now match it even if the text > contains a newline character. > > Thanks in advance! Thanks for the review

Re: RFR: 8335921: Fix HotSpot VM build without JVMTI

2024-07-17 Thread Aleksey Shipilev
On Wed, 17 Jul 2024 03:37:36 GMT, Vladimir Kozlov wrote: > Citing David Holmes from bug report: > "We provided the ability to leave out certain VM services (JVMTI, GC's other > than serial, ...) as part of the design of the MinimalVM to support Java SE > Embedded, along with the Compact

Re: RFR: 8335921: Fix HotSpot VM build without JVMTI

2024-07-17 Thread Aleksey Shipilev
On Wed, 17 Jul 2024 04:57:38 GMT, David Holmes wrote: > It highlights the problem we have with optional components in that you either > have to work things so that semantically we have a do-nothing implementation > of that component, or else you have to put the guards around every piece of >

Re: RFR: 8336040: Missing closing anchor element in Docs.gmk

2024-07-17 Thread Aleksey Shipilev
On Tue, 16 Jul 2024 14:12:54 GMT, Nizar Benalla wrote: > Can I please have a review for this bug fix to make file used to generate the > OpenJDK documentation. It adds the missing `` tag after `OTHER > SPECIFICATIONS`, this should help remove some HTML warnings in out generated > docs. > >

Re: RFR: 8336040: Missing closing anchor element in Docs.gmk

2024-07-17 Thread Jaikiran Pai
On Tue, 16 Jul 2024 14:12:54 GMT, Nizar Benalla wrote: > Can I please have a review for this bug fix to make file used to generate the > OpenJDK documentation. It adds the missing `` tag after `OTHER > SPECIFICATIONS`, this should help remove some HTML warnings in out generated > docs. > >