Re: RFR: 8338768: Introduce runtime lookup to check for static builds [v2]

2024-09-01 Thread Julian Waters
On Mon, 2 Sep 2024 04:09:19 GMT, David Holmes wrote: > > This does make me wonder: What if the new method for checking if the VM was > > statically linked was inlined? Then the problem comes back yet again as the > > object files need to be recompiled once more. This is possible if Link Time >

Re: RFR: 8338768: Introduce runtime lookup to check for static builds [v2]

2024-09-01 Thread David Holmes
On Sun, 1 Sep 2024 16:30:33 GMT, Julian Waters wrote: > This does make me wonder: What if the new method for checking if the VM was > statically linked was inlined? Then the problem comes back yet again as the > object files need to be recompiled once more. This is possible if Link Time > Opti

Re: RFR: 8339336: Fix build system whitespace to adhere to coding conventions [v2]

2024-09-01 Thread Magnus Ihse Bursie
On Fri, 30 Aug 2024 19:29:56 GMT, Erik Joelsson wrote: >> Magnus Ihse Bursie has updated the pull request incrementally with one >> additional commit since the last revision: >> >> Fix bad change in BuildMicrobenchmarks > > make/MainSupport.gmk line 202: > >> 200: $(foreach i, 2 3 4 5 6 7

Re: RFR: 8339336: Fix build system whitespace to adhere to coding conventions [v2]

2024-09-01 Thread Magnus Ihse Bursie
On Fri, 30 Aug 2024 20:19:46 GMT, Erik Joelsson wrote: >> Magnus Ihse Bursie has updated the pull request incrementally with one >> additional commit since the last revision: >> >> Fix bad change in BuildMicrobenchmarks > > make/test/BuildMicrobenchmark.gmk line 71: > >> 69: # Need double \n

Re: RFR: 8339336: Fix build system whitespace to adhere to coding conventions [v2]

2024-09-01 Thread Magnus Ihse Bursie
> The build system code has unfortunately diverted in some places from the > conventions as described in > https://openjdk.org/groups/build/doc/code-conventions.html. > > Instead of trying to fix these when touching code nearby, I'd like to make an > effort to fix all issues at once and separat

Re: RFR: 8338768: Introduce runtime lookup to check for static builds [v2]

2024-09-01 Thread Julian Waters
On Wed, 21 Aug 2024 22:14:40 GMT, Magnus Ihse Bursie wrote: >> As a preparation for Hermetic Java, we need to have a way to look up during >> runtime if we are using a statically linked library or not. >> >> This change will be the first step needed towards compiling the object files >> only o

RFR: 8337265: Test static-libs build in GitHub Actions

2024-09-01 Thread Doug Simon
This PR modifies the GitHub Actions' linux product build to include building of the static-libs bundle as a minimal smoke test that these builds don't break. - Commit messages: - build static-libs on linux Changes: https://git.openjdk.org/jdk/pull/20803/files Webrev: https://webr