Re: RFR: 8311530: Deprecate jdk.jsobject module for removal

2024-09-05 Thread Alan Bateman
On Mon, 12 Aug 2024 17:22:47 GMT, Kevin Rushforth wrote: > Deprecate the `jdk.jsobject` module for removal from the JDK, and ship it > with JavaFX instead. > > See [JDK-8337280](https://bugs.openjdk.org/browse/JDK-8337280) / PR > openjdk/jfx#1529 for the JavaFX PR that will include the module

Integrated: 8339548: GHA: RISC-V: Use Debian snapshot archive for bootstrap

2024-09-05 Thread Fei Yang
On Wed, 4 Sep 2024 14:40:38 GMT, Fei Yang wrote: > Debian "sid" or "unstable" (https://httpredir.debian.org/debian) that we use > for debootstrapping RISC-V breaks very often. Currently, the GHA > linux-cross-build for RISC-V would not continue and is simply skipped when > this debootstrap for

Re: RFR: 8339548: GHA: RISC-V: Use Debian snapshot archive for bootstrap

2024-09-05 Thread Fei Yang
On Wed, 4 Sep 2024 14:40:38 GMT, Fei Yang wrote: > Debian "sid" or "unstable" (https://httpredir.debian.org/debian) that we use > for debootstrapping RISC-V breaks very often. Currently, the GHA > linux-cross-build for RISC-V would not continue and is simply skipped when > this debootstrap for

Re: RFR: 8311530: Deprecate jdk.jsobject module for removal

2024-09-05 Thread Roger Riggs
On Mon, 12 Aug 2024 17:22:47 GMT, Kevin Rushforth wrote: > Deprecate the `jdk.jsobject` module for removal from the JDK, and ship it > with JavaFX instead. > > See [JDK-8337280](https://bugs.openjdk.org/browse/JDK-8337280) / PR > openjdk/jfx#1529 for the JavaFX PR that will include the module

Re: RFR: 8311530: Deprecate jdk.jsobject module for removal

2024-09-05 Thread Kevin Rushforth
On Mon, 12 Aug 2024 17:22:47 GMT, Kevin Rushforth wrote: > Deprecate the `jdk.jsobject` module for removal from the JDK, and ship it > with JavaFX instead. > > See [JDK-8337280](https://bugs.openjdk.org/browse/JDK-8337280) / PR > openjdk/jfx#1529 for the JavaFX PR that will include the module

RFR: 8311530: Deprecate jdk.jsobject module for removal

2024-09-05 Thread Kevin Rushforth
Deprecate the `jdk.jsobject` module for removal from the JDK, and ship it with JavaFX instead. See [JDK-8337280](https://bugs.openjdk.org/browse/JDK-8337280) / PR openjdk/jfx#1529 for the JavaFX PR that will include the module with JavaFX. That PR describes the needed test scenarios. This PR d

Re: RFR: 8339480: Build static-jdk image with a statically linked launcher

2024-09-05 Thread Jiangli Zhou
On Thu, 5 Sep 2024 09:57:15 GMT, Magnus Ihse Bursie wrote: >> make/modules/java.desktop/lib/AwtLibraries.gmk line 176: >> >>> 174: >>> 175: ifneq ($(ENABLE_HEADLESS_ONLY), true) >>> 176: # We cannot link with both awt_headless and awt_xawt at the same >>> time >> >> Just a note on that.

Re: RFR: 8339480: Build static-jdk image with a statically linked launcher

2024-09-05 Thread Jiangli Zhou
On Thu, 5 Sep 2024 10:03:19 GMT, Magnus Ihse Bursie wrote: >> make/StaticLibs.gmk line 118: >> >>> 116: OPTIMIZATION := HIGH, \ >>> 117: STATIC_LAUNCHER := true, \ >>> 118: LDFLAGS := $(JAVASTATIC_LINK_LDFLAGS), \ >> >> I could be missing something, but I don't see where is >> $JAV

Re: RFR: 8339480: Build static-jdk image with a statically linked launcher

2024-09-05 Thread Jiangli Zhou
On Thu, 5 Sep 2024 05:06:55 GMT, Julian Waters wrote: >> make/StaticLibs.gmk line 71: >> >>> 69: # libsspi_bridge has name conflicts with sunmscapi >>> 70: BROKEN_STATIC_LIBS += sspi_bridge >>> 71: # These libs define DllMain which conflict with Hotspot >> >> I'm not aware of the DllMain

Re: RFR: 8339480: Build static-jdk image with a statically linked launcher

2024-09-05 Thread Jiangli Zhou
On Thu, 5 Sep 2024 09:50:49 GMT, Magnus Ihse Bursie wrote: > Well, but your proof-of-concept only supports clang on linux, where you have > enabled symbol hiding. The hermetic-java-runtime branch doesn't have general symbol hiding enabled. That's why I'm wondering what the issues are with thes

Re: RFR: 8339548: GHA: RISC-V: Use Debian snapshot archive for bootstrap

2024-09-05 Thread Fei Yang
On Thu, 5 Sep 2024 13:23:14 GMT, Erik Joelsson wrote: >> Marked as reviewed by erikj (Reviewer). > >> @erikj79 : Please take a look. Thanks. > >> Maybe @erikj79 ? Thanks. > > I generally skip most GHA related PRs as there are plenty of other reviewers > on this mailing list with deeper GHA kno

Re: RFR: 8339548: GHA: RISC-V: Use Debian snapshot archive for bootstrap

2024-09-05 Thread Erik Joelsson
On Thu, 5 Sep 2024 13:16:41 GMT, Erik Joelsson wrote: >> Debian "sid" or "unstable" (https://httpredir.debian.org/debian) that we use >> for debootstrapping RISC-V breaks very often. Currently, the GHA >> linux-cross-build for RISC-V would not continue and is simply skipped when >> this deboot

Re: RFR: 8339548: GHA: RISC-V: Use Debian snapshot archive for bootstrap

2024-09-05 Thread Erik Joelsson
On Wed, 4 Sep 2024 14:40:38 GMT, Fei Yang wrote: > Debian "sid" or "unstable" (https://httpredir.debian.org/debian) that we use > for debootstrapping RISC-V breaks very often. Currently, the GHA > linux-cross-build for RISC-V would not continue and is simply skipped when > this debootstrap for

Re: RFR: 8339480: Build static-jdk image with a statically linked launcher

2024-09-05 Thread Alan Bateman
On Tue, 3 Sep 2024 12:50:01 GMT, Magnus Ihse Bursie wrote: > As a prerequisite for Hermetic Java, we need a statically linked `java` > launcher. It should behave like the normal, dynamically linked `java` > launcher, except that all JDK native libraries should be statically, not > dynamically,

Re: RFR: 8339480: Build static-jdk image with a statically linked launcher

2024-09-05 Thread Magnus Ihse Bursie
On Wed, 4 Sep 2024 23:24:13 GMT, Jiangli Zhou wrote: >> As a prerequisite for Hermetic Java, we need a statically linked `java` >> launcher. It should behave like the normal, dynamically linked `java` >> launcher, except that all JDK native libraries should be statically, not >> dynamically, l

Re: RFR: 8339480: Build static-jdk image with a statically linked launcher

2024-09-05 Thread Magnus Ihse Bursie
On Wed, 4 Sep 2024 23:28:10 GMT, Jiangli Zhou wrote: >> As a prerequisite for Hermetic Java, we need a statically linked `java` >> launcher. It should behave like the normal, dynamically linked `java` >> launcher, except that all JDK native libraries should be statically, not >> dynamically, l

Re: RFR: 8339480: Build static-jdk image with a statically linked launcher

2024-09-05 Thread Magnus Ihse Bursie
On Tue, 3 Sep 2024 12:50:01 GMT, Magnus Ihse Bursie wrote: > As a prerequisite for Hermetic Java, we need a statically linked `java` > launcher. It should behave like the normal, dynamically linked `java` > launcher, except that all JDK native libraries should be statically, not > dynamically,

Re: RFR: 8339480: Build static-jdk image with a statically linked launcher

2024-09-05 Thread Magnus Ihse Bursie
On Wed, 4 Sep 2024 23:03:23 GMT, Jiangli Zhou wrote: >> As a prerequisite for Hermetic Java, we need a statically linked `java` >> launcher. It should behave like the normal, dynamically linked `java` >> launcher, except that all JDK native libraries should be statically, not >> dynamically, l

Re: RFR: 8339480: Build static-jdk image with a statically linked launcher

2024-09-05 Thread Magnus Ihse Bursie
On Thu, 5 Sep 2024 05:06:55 GMT, Julian Waters wrote: >> make/StaticLibs.gmk line 71: >> >>> 69: # libsspi_bridge has name conflicts with sunmscapi >>> 70: BROKEN_STATIC_LIBS += sspi_bridge >>> 71: # These libs define DllMain which conflict with Hotspot >> >> I'm not aware of the DllMain