Re: RFR: 8366121: Hotspot Style Guide should document conventions for lock-free code

2025-08-27 Thread David Holmes
On Tue, 26 Aug 2025 00:26:59 GMT, David Holmes wrote: > This is a topic that we, at Oracle, have discussed numerous times over the > years and we have some simple guidelines that never get written down properly > and which we/I tend to forget and then can't locate. To remedy that I would > lik

Re: RFR: 8365053: Refresh hotspot precompiled.hpp with headers based on current frequency [v20]

2025-08-27 Thread Erik Joelsson
On Wed, 27 Aug 2025 18:06:30 GMT, Francesco Andreuzzi wrote: >> In this PR I propose to refresh the included headers in hotspot >> `precompiled.hpp`. The current set of precompiled headers was refreshed in >> 2018, 7 years ago. I repeated the same operations and measurements after >> refreshin

Re: RFR: 8365053: Refresh hotspot precompiled.hpp with headers based on current frequency [v20]

2025-08-27 Thread Magnus Ihse Bursie
On Wed, 27 Aug 2025 18:06:30 GMT, Francesco Andreuzzi wrote: >> In this PR I propose to refresh the included headers in hotspot >> `precompiled.hpp`. The current set of precompiled headers was refreshed in >> 2018, 7 years ago. I repeated the same operations and measurements after >> refreshin

Re: RFR: 8365053: Refresh hotspot precompiled.hpp with headers based on current frequency [v19]

2025-08-27 Thread Francesco Andreuzzi
On Wed, 27 Aug 2025 17:02:39 GMT, Erik Joelsson wrote: >> Francesco Andreuzzi has updated the pull request incrementally with two >> additional commits since the last revision: >> >> - stuff >> - nn > > make/scripts/update_pch.sh line 101: > >> 99: mv "$PRECOMPILED_HPP.tmp" "$PRECOMPILED_HPP

Re: RFR: 8365053: Refresh hotspot precompiled.hpp with headers based on current frequency [v20]

2025-08-27 Thread Francesco Andreuzzi
> In this PR I propose to refresh the included headers in hotspot > `precompiled.hpp`. The current set of precompiled headers was refreshed in > 2018, 7 years ago. I repeated the same operations and measurements after > refreshing the set of precompiled headers according to the current usage >

Re: RFR: 8365053: Refresh hotspot precompiled.hpp with headers based on current frequency [v19]

2025-08-27 Thread Erik Joelsson
On Wed, 27 Aug 2025 16:50:33 GMT, Francesco Andreuzzi wrote: >> In this PR I propose to refresh the included headers in hotspot >> `precompiled.hpp`. The current set of precompiled headers was refreshed in >> 2018, 7 years ago. I repeated the same operations and measurements after >> refreshin

Re: RFR: 8365053: Refresh hotspot precompiled.hpp with headers based on current frequency [v18]

2025-08-27 Thread Francesco Andreuzzi
On Wed, 27 Aug 2025 13:01:28 GMT, Erik Joelsson wrote: >> Francesco Andreuzzi has updated the pull request incrementally with one >> additional commit since the last revision: >> >> no executable > > make/scripts/update_pch.sh line 69: > >> 67: >> 68: make clean CONF_NAME="$RUN_NAME" >> 69:

Re: RFR: 8365053: Refresh hotspot precompiled.hpp with headers based on current frequency [v18]

2025-08-27 Thread Francesco Andreuzzi
On Wed, 27 Aug 2025 10:44:45 GMT, Aleksey Shipilev wrote: > See if there is anything easy missing in the script? Thanks @shipilev, I addressed this in 6693cefe01e03cd05a11a93cf04d0d6af78f42bb. I use `SortIncludes.java` instead of `sort`, and I also added `precompiled` to `TestIncludesAreSorted

Re: RFR: 8365053: Refresh hotspot precompiled.hpp with headers based on current frequency [v19]

2025-08-27 Thread Francesco Andreuzzi
> In this PR I propose to refresh the included headers in hotspot > `precompiled.hpp`. The current set of precompiled headers was refreshed in > 2018, 7 years ago. I repeated the same operations and measurements after > refreshing the set of precompiled headers according to the current usage >

Re: RFR: 8365053: Refresh hotspot precompiled.hpp with headers based on current frequency [v18]

2025-08-27 Thread Erik Joelsson
On Tue, 26 Aug 2025 22:34:39 GMT, Francesco Andreuzzi wrote: >> In this PR I propose to refresh the included headers in hotspot >> `precompiled.hpp`. The current set of precompiled headers was refreshed in >> 2018, 7 years ago. I repeated the same operations and measurements after >> refreshin

Re: RFR: 8365053: Refresh hotspot precompiled.hpp with headers based on current frequency [v18]

2025-08-27 Thread Erik Joelsson
On Wed, 27 Aug 2025 10:44:45 GMT, Aleksey Shipilev wrote: > Ran the script locally, and noticed that on my Mac this was the difference: > > ``` > -#include "oops/oopHandle.inline.hpp" > #include "oops/oop.inline.hpp" > +#include "oops/oopHandle.inline.hpp" > ``` > > Something is a bit off with

Re: RFR: 8365053: Refresh hotspot precompiled.hpp with headers based on current frequency [v18]

2025-08-27 Thread Aleksey Shipilev
On Tue, 26 Aug 2025 22:34:39 GMT, Francesco Andreuzzi wrote: >> In this PR I propose to refresh the included headers in hotspot >> `precompiled.hpp`. The current set of precompiled headers was refreshed in >> 2018, 7 years ago. I repeated the same operations and measurements after >> refreshin

Re: RFR: 8365053: Refresh hotspot precompiled.hpp with headers based on current frequency [v18]

2025-08-27 Thread duke
On Tue, 26 Aug 2025 22:34:39 GMT, Francesco Andreuzzi wrote: >> In this PR I propose to refresh the included headers in hotspot >> `precompiled.hpp`. The current set of precompiled headers was refreshed in >> 2018, 7 years ago. I repeated the same operations and measurements after >> refreshin

Re: RFR: 8365053: Refresh hotspot precompiled.hpp with headers based on current frequency [v18]

2025-08-27 Thread Magnus Ihse Bursie
On Tue, 26 Aug 2025 22:34:39 GMT, Francesco Andreuzzi wrote: >> In this PR I propose to refresh the included headers in hotspot >> `precompiled.hpp`. The current set of precompiled headers was refreshed in >> 2018, 7 years ago. I repeated the same operations and measurements after >> refreshin