Re: RFR: 8361950: Update to use jtreg 8 [v4]

2025-09-05 Thread Chen Liang
On Thu, 4 Sep 2025 22:01:57 GMT, Christian Stein wrote: >> Please review the change to update to using jtreg 8. >> >> The primary change is to the `jib-profiles.js` file, which specifies the >> version of jtreg to use, for those systems that rely on this file. In >> addition, the requiredVersi

Re: RFR: 8366455: Move VarHandles.GuardMethodGenerator to execute on build [v2]

2025-09-05 Thread Paul Sandoz
On Tue, 2 Sep 2025 22:20:26 GMT, Chen Liang wrote: >> Currently, java.lang.invoke.VarHandles$GuardMethodGenerator is in a weird >> state: when VarHandleGuards needs to be updated, we uncomment it, build JDK, >> run it as a main class, and paste the generated VarHandleGuards class. >> >> This p

Re: RFR: 8366837: Clean up gensrc by spp.Spp

2025-09-05 Thread Magnus Ihse Bursie
On Fri, 5 Sep 2025 22:34:32 GMT, Erik Joelsson wrote: >> Several java classes in java.base is generated from templates using SPP, the >> "Stream Preprocessor". Unfortunately much of this code is very old and has >> survived unchanged since pre-JDK 7. It does not follow modern makefile >> stand

Re: RFR: 8332872: SetupExecute should cd to temp directory

2025-09-05 Thread Erik Joelsson
On Thu, 4 Sep 2025 15:34:45 GMT, Magnus Ihse Bursie wrote: > Some commands create junk files all around in the current directory. We > should change directory to a special working dir (typically the support dir) > in SetupExecute, before running any command. Marked as reviewed by erikj (Review

Re: RFR: 8366837: Clean up gensrc by spp.Spp

2025-09-05 Thread Erik Joelsson
On Wed, 3 Sep 2025 20:17:50 GMT, Magnus Ihse Bursie wrote: > Several java classes in java.base is generated from templates using SPP, the > "Stream Preprocessor". Unfortunately much of this code is very old and has > survived unchanged since pre-JDK 7. It does not follow modern makefile > stan

Re: RFR: 8233115: Protect ExecuteWithLog from running with redirection without a subshell [v3]

2025-09-05 Thread Erik Joelsson
On Fri, 5 Sep 2025 08:55:26 GMT, Magnus Ihse Bursie wrote: >> When calling ExecuteWithLog with a redirection (using > or, possibly, <), >> the entire command needs to be executed in a subshell, that is, inside a >> pair of parentheses. This is the callers obligation to ensure, but we have >> p

Re: RFR: 8366455: Move VarHandles.GuardMethodGenerator to execute on build [v2]

2025-09-05 Thread Chen Liang
On Tue, 2 Sep 2025 22:20:26 GMT, Chen Liang wrote: >> Currently, java.lang.invoke.VarHandles$GuardMethodGenerator is in a weird >> state: when VarHandleGuards needs to be updated, we uncomment it, build JDK, >> run it as a main class, and paste the generated VarHandleGuards class. >> >> This p

Integrated: 8366455: Move VarHandles.GuardMethodGenerator to execute on build

2025-09-05 Thread Chen Liang
On Fri, 29 Aug 2025 19:13:27 GMT, Chen Liang wrote: > Currently, java.lang.invoke.VarHandles$GuardMethodGenerator is in a weird > state: when VarHandleGuards needs to be updated, we uncomment it, build JDK, > run it as a main class, and paste the generated VarHandleGuards class. > > This proce

Integrated: 8314488: Compiling the JDK with C++17

2025-09-05 Thread Kim Barrett
On Thu, 21 Aug 2025 14:47:14 GMT, Kim Barrett wrote: > Please review this change to use C++17 for building C++ parts of the JDK. In > particular this affects HotSpot. This change also includes an update to the > HotSpot Style Guide regarding C++17 features and their use in HotSpot code. > > Test

Re: RFR: 8332872: SetupExecute should cd to temp directory

2025-09-05 Thread Magnus Ihse Bursie
On Thu, 4 Sep 2025 15:34:45 GMT, Magnus Ihse Bursie wrote: > Some commands create junk files all around in the current directory. We > should change directory to a special working dir (typically the support dir) > in SetupExecute, before running any command. This has passed Oracle internal CI

Re: RFR: 8366837: Clean up gensrc by spp.Spp

2025-09-05 Thread Magnus Ihse Bursie
On Wed, 3 Sep 2025 20:17:50 GMT, Magnus Ihse Bursie wrote: > Several java classes in java.base is generated from templates using SPP, the > "Stream Preprocessor". Unfortunately much of this code is very old and has > survived unchanged since pre-JDK 7. It does not follow modern makefile > stan

RFR: 8366837: Clean up gensrc by spp.Spp

2025-09-05 Thread Magnus Ihse Bursie
Several java classes in java.base is generated from templates using SPP, the "Stream Preprocessor". Unfortunately much of this code is very old and has survived unchanged since pre-JDK 7. It does not follow modern makefile standards for abstraction, safe coding practices, etc. In short, they hav

Re: RFR: 8366837: Clean up gensrc by spp.Spp

2025-09-05 Thread Magnus Ihse Bursie
On Wed, 3 Sep 2025 20:17:50 GMT, Magnus Ihse Bursie wrote: > Several java classes in java.base is generated from templates using SPP, the > "Stream Preprocessor". Unfortunately much of this code is very old and has > survived unchanged since pre-JDK 7. It does not follow modern makefile > stan

Re: RFR: 8366455: Move VarHandles.GuardMethodGenerator to execute on build

2025-09-05 Thread Chen Liang
On Tue, 2 Sep 2025 15:24:07 GMT, Paul Sandoz wrote: >> @PaulSandoz Do you know if there was/is a particular reason for not >> generating the VarHandle guards as part of the build? > >> @PaulSandoz Do you know if there was/is a particular reason for not >> generating the VarHandle guards as part

RFR: 8332872: SetupExecute should cd to temp directory

2025-09-05 Thread Magnus Ihse Bursie
Some commands create junk files all around in the current directory. We should change directory to a special working dir (typically the support dir) in SetupExecute, before running any command. - Commit messages: - Merge branch 'master' into execute-in-work-dir - Jmod workaround d

Re: RFR: 8233115: Protect ExecuteWithLog from running with redirection without a subshell [v3]

2025-09-05 Thread Magnus Ihse Bursie
> When calling ExecuteWithLog with a redirection (using > or, possibly, <), the > entire command needs to be executed in a subshell, that is, inside a pair of > parentheses. This is the callers obligation to ensure, but we have proven > multiple times that this is hard to keep in mind, and we go

Re: RFR: 8366777: Build fails unknown pseudo-op with old AS on linux-aarch64 [v6]

2025-09-05 Thread SendaoYan
On Fri, 5 Sep 2025 06:16:01 GMT, SendaoYan wrote: >> Hi all, >> >> Build jdk on linux-aarch64 with older assembler version(as 2.30) will report >> compilation failre, shows as >> [JDK-8366777](https://bugs.openjdk.org/browse/JDK-8366777). >> >> This PR add the expression `svfloat64_t a() {}`