Integrated: 8329471: Remove GTK2

2024-08-08 Thread Alexander Zvegintsev
On Mon, 29 Jul 2024 14:55:07 GMT, Alexander Zvegintsev wrote: > GTK2 support for Swing/AWT was deprecated for removal in JDK 21. > > It's being removed because no platform that supports the JDK needs it. > > Manual and automated testing is green. This pull request has

Re: RFR: 8329471: Remove GTK2 [v4]

2024-07-31 Thread Alexander Zvegintsev
On Wed, 31 Jul 2024 18:29:57 GMT, Phil Race wrote: >> Alexander Zvegintsev has updated the pull request incrementally with one >> additional commit since the last revision: >> >> more cleanup > > src/java.desktop/share/classes/com/sun/java/swing/plaf/g

Re: RFR: 8329471: Remove GTK2 [v5]

2024-07-31 Thread Alexander Zvegintsev
> GTK2 support for Swing/AWT was deprecated for removal in JDK 21. > > It's being removed because no platform that supports the JDK needs it. > > Manual and automated testing is green. Alexander Zvegintsev has updated the pull request incrementally with one additional c

Re: RFR: 8329471: Remove GTK2

2024-07-31 Thread Alexander Zvegintsev
On Wed, 31 Jul 2024 09:31:42 GMT, Abhishek Kumar wrote: > > Other references related to gtk2 here > > > > 1. > > [DesktopGtkLoadTest](https://github.com/openjdk/jdk/blob/574358df3b4891e953f84814c64ac651ea37755a/test/jdk/java/awt/Desktop/DesktopGtkLoadTest/DesktopGtkLoadTest.java#L56) > > Did y

Re: RFR: 8329471: Remove GTK2 [v4]

2024-07-30 Thread Alexander Zvegintsev
> GTK2 support for Swing/AWT was deprecated for removal in JDK 21. > > It's being removed because no platform that supports the JDK needs it. > > Manual and automated testing is green. Alexander Zvegintsev has updated the pull request incrementally with one additional c

Re: RFR: 8329471: Remove GTK2 [v3]

2024-07-30 Thread Alexander Zvegintsev
> GTK2 support for Swing/AWT was deprecated for removal in JDK 21. > > It's being removed because no platform that supports the JDK needs it. > > Manual and automated testing is green. Alexander Zvegintsev has updated the pull request incrementally with one additional c

Re: RFR: 8329471: Remove GTK2 [v3]

2024-07-30 Thread Alexander Zvegintsev
On Tue, 30 Jul 2024 07:12:17 GMT, Abhishek Kumar wrote: >> Alexander Zvegintsev has updated the pull request incrementally with one >> additional commit since the last revision: >> >> revert spacing > > src/java.desktop/share/classes/com/sun/java/swing/plaf/gtk

Re: RFR: 8329471: Remove GTK2 [v2]

2024-07-30 Thread Alexander Zvegintsev
> GTK2 support for Swing/AWT was deprecated for removal in JDK 21. > > It's being removed because no platform that supports the JDK needs it. > > Manual and automated testing is green. Alexander Zvegintsev has updated the pull request incrementally with three additional co

RFR: 8329471: Remove GTK2

2024-07-29 Thread Alexander Zvegintsev
GTK2 support for Swing/AWT was deprecated for removal in JDK 21. It's being removed because no platform that supports the JDK needs it. Manual and automated testing is green. - Commit messages: - 8329471: Remove GTK2 Changes: https://git.openjdk.org/jdk/pull/20378/files Webrev:

Re: RFR: 8324347: Enable "maybe-uninitialized" warning for FreeType 2.13.1

2024-01-25 Thread Alexander Zvegintsev
On Tue, 23 Jan 2024 00:58:27 GMT, Sergey Bylokhov wrote: > The next bug in freetype was fixed upstream and fix already merged to OpenJDK: > https://gitlab.freedesktop.org/freetype/freetype/-/issues/1245 > So now we can revert the workaround in the JDK: > https://bugs.openjdk.org/browse/JDK-831357

Re: RFR: 8314753: Remove support for @beaninfo, @ToDo, @since.unbundled, and @Note [v2]

2023-08-28 Thread Alexander Zvegintsev
On Tue, 22 Aug 2023 14:55:18 GMT, Pavel Rappo wrote: >> Please review this trivial PR. > > Pavel Rappo has updated the pull request with a new target base due to a > merge or a rebase. The pull request now contains two commits: > > - Merge branch 'master' into 8314753 > - Initial commit Mark

Integrated: 8280982: [Wayland] [XWayland] java.awt.Robot taking screenshots

2023-06-07 Thread Alexander Zvegintsev
On Thu, 4 May 2023 14:18:44 GMT, Alexander Zvegintsev wrote: > Modern Linux systems often come with > [Wayland](https://wayland.freedesktop.org/) by default. > This comes with some difficulties, and one of them is the inability to get > screenshots from the system. > This is

Re: RFR: 8280982: [Wayland] [XWayland] java.awt.Robot taking screenshots [v12]

2023-06-07 Thread Alexander Zvegintsev
tly disabled by default. > > This change also introduces some new behavior for the robot: > A system window now appears asking for confirmation from the user to capture > the screen. > + The user can refuse the screen capture completely. In this case a security > exception will b

Re: RFR: 8280982: [Wayland] [XWayland] java.awt.Robot taking screenshots [v11]

2023-06-07 Thread Alexander Zvegintsev
On Wed, 7 Jun 2023 04:44:44 GMT, Prasanta Sadhukhan wrote: >> Alexander Zvegintsev has updated the pull request incrementally with two >> additional commits since the last revision: >> >> - move screencast-tokens.properties to a new location >> - fix failure

Re: RFR: 8280982: [Wayland] [XWayland] java.awt.Robot taking screenshots [v11]

2023-06-07 Thread Alexander Zvegintsev
On Wed, 7 Jun 2023 05:40:38 GMT, Phil Race wrote: >> src/java.desktop/unix/classes/sun/awt/screencast/TokenStorage.java line 145: >> >>> 143: path, >>> 144: Set.of(PosixFilePermission.OWNER_READ, >>> 145: PosixFilePermission.OWN

Re: RFR: 8280982: [Wayland] [XWayland] java.awt.Robot taking screenshots [v11]

2023-06-06 Thread Alexander Zvegintsev
tly disabled by default. > > This change also introduces some new behavior for the robot: > A system window now appears asking for confirmation from the user to capture > the screen. > + The user can refuse the screen capture completely. In this case a security > exception will b

Re: RFR: 8280982: [Wayland] [XWayland] java.awt.Robot taking screenshots [v9]

2023-06-01 Thread Alexander Zvegintsev
On Wed, 31 May 2023 20:53:03 GMT, Andrey Turbanov wrote: >> Alexander Zvegintsev has updated the pull request incrementally with four >> additional commits since the last revision: >> >> - improve retVal processing >> - address token storage com

Re: RFR: 8280982: [Wayland] [XWayland] java.awt.Robot taking screenshots [v10]

2023-06-01 Thread Alexander Zvegintsev
tly disabled by default. > > This change also introduces some new behavior for the robot: > A system window now appears asking for confirmation from the user to capture > the screen. > + The user can refuse the screen capture completely. In this case a security > exception will be

Re: RFR: 8280982: [Wayland] [XWayland] java.awt.Robot taking screenshots [v8]

2023-05-31 Thread Alexander Zvegintsev
On Tue, 30 May 2023 19:33:20 GMT, Phil Race wrote: >> Alexander Zvegintsev has updated the pull request incrementally with one >> additional commit since the last revision: >> >> fix macos build > > src/java.desktop/unix/classes/sun/awt/screencast/ScreencastHelp

Re: RFR: 8280982: [Wayland] [XWayland] java.awt.Robot taking screenshots [v9]

2023-05-31 Thread Alexander Zvegintsev
tly disabled by default. > > This change also introduces some new behavior for the robot: > A system window now appears asking for confirmation from the user to capture > the screen. > + The user can refuse the screen capture completely. In this case a security > exception will b

Re: RFR: 8280982: [Wayland] [XWayland] java.awt.Robot taking screenshots [v7]

2023-05-26 Thread Alexander Zvegintsev
On Fri, 26 May 2023 21:50:15 GMT, Phil Race wrote: > macos builds are broken with this change. The problem is > unix/classes/sun/awt/screencast, causing unix/classes/sun/awt/X11 to be built > but it fails because we don't (and shouldn't) generate the XAWT source on > macOS. > > You need to ad

Re: RFR: 8280982: [Wayland] [XWayland] java.awt.Robot taking screenshots [v8]

2023-05-26 Thread Alexander Zvegintsev
tly disabled by default. > > This change also introduces some new behavior for the robot: > A system window now appears asking for confirmation from the user to capture > the screen. > + The user can refuse the screen capture completely. In this case a security > exception will be

Re: RFR: 8280982: [Wayland] [XWayland] java.awt.Robot taking screenshots [v7]

2023-05-26 Thread Alexander Zvegintsev
On Fri, 26 May 2023 15:32:41 GMT, Maxim Kartashev wrote: > Tried running this version on my machine (Ubuntu 22.04, two displays with > 100% and 200% scaling). A few observations: > > 1. I couldn't get any of the screenshot tests working through `jtreg` > (screenshots are all black, no per

Re: RFR: 8280982: [Wayland] [XWayland] java.awt.Robot taking screenshots [v7]

2023-05-25 Thread Alexander Zvegintsev
On Thu, 25 May 2023 16:29:39 GMT, Alexander Zvegintsev wrote: >> Modern Linux systems often come with >> [Wayland](https://wayland.freedesktop.org/) by default. >> This comes with some difficulties, and one of them is the inability to get >> screenshots from the syste

Re: RFR: 8280982: [Wayland] [XWayland] java.awt.Robot taking screenshots [v7]

2023-05-25 Thread Alexander Zvegintsev
tly disabled by default. > > This change also introduces some new behavior for the robot: > A system window now appears asking for confirmation from the user to capture > the screen. > + The user can refuse the screen capture completely. In this case a security > exception will be

Re: RFR: 8280982: [Wayland] [XWayland] java.awt.Robot taking screenshots [v5]

2023-05-23 Thread Alexander Zvegintsev
On Mon, 22 May 2023 22:34:17 GMT, Alexander Zvegintsev wrote: >> Modern Linux systems often come with >> [Wayland](https://wayland.freedesktop.org/) by default. >> This comes with some difficulties, and one of them is the inability to get >> screenshots from the syste

Re: RFR: 8280982: [Wayland] [XWayland] java.awt.Robot taking screenshots [v6]

2023-05-23 Thread Alexander Zvegintsev
tly disabled by default. > > This change also introduces some new behavior for the robot: > A system window now appears asking for confirmation from the user to capture > the screen. > + The user can refuse the screen capture completely. In this case a security > exception will be

Re: RFR: 8280982: [Wayland] [XWayland] java.awt.Robot taking screenshots [v5]

2023-05-22 Thread Alexander Zvegintsev
tly disabled by default. > > This change also introduces some new behavior for the robot: > A system window now appears asking for confirmation from the user to capture > the screen. > + The user can refuse the screen capture completely. In this case a security > exception will be

Re: RFR: 8280982: [Wayland] [XWayland] java.awt.Robot taking screenshots [v4]

2023-05-22 Thread Alexander Zvegintsev
tly disabled by default. > > This change also introduces some new behavior for the robot: > A system window now appears asking for confirmation from the user to capture > the screen. > + The user can refuse the screen capture completely. In this case a security > exception will be

Re: RFR: 8280982: [Wayland] [XWayland] java.awt.Robot taking screenshots

2023-05-18 Thread Alexander Zvegintsev
On Fri, 5 May 2023 14:58:15 GMT, Alexander Zvegintsev wrote: > Do we really need to add this new API? probably we can implement the feature > w/o this new method? Please review the changes to remove resetScreenCapturePermission The token is now stored together with the bounds of the s

Re: RFR: 8280982: [Wayland] [XWayland] java.awt.Robot taking screenshots [v3]

2023-05-18 Thread Alexander Zvegintsev
tly disabled by default. > > This change also introduces some new behavior for the robot: > A system window now appears asking for confirmation from the user to capture > the screen. > + The user can refuse the screen capture completely. In this case a security > exception will be

Re: RFR: 8280982: [Wayland] [XWayland] java.awt.Robot taking screenshots [v2]

2023-05-11 Thread Alexander Zvegintsev
On Wed, 10 May 2023 21:59:37 GMT, Phil Race wrote: > > It is not for the "we have all permissions" case, it is for the case when > > we only have a permission to some screens. So it won't hurt. > > But how does the app know when to call it ? Right now it doesn't know. If the user is not satisf

Re: RFR: 8280982: [Wayland] [XWayland] java.awt.Robot taking screenshots [v2]

2023-05-09 Thread Alexander Zvegintsev
On Tue, 9 May 2023 20:43:13 GMT, Phil Race wrote: > I want to work through the scenarios and how much of it is specific to the > behaviours of the API you are using and so forth. Since you use the > Preferences API for saving the token, if you keyed it off the Robot class > rather than the int

Re: RFR: 8280982: [Wayland] [XWayland] java.awt.Robot taking screenshots

2023-05-09 Thread Alexander Zvegintsev
On Mon, 8 May 2023 18:41:56 GMT, Sergey Bylokhov wrote: > > It seems that the current robot API is not suitable for this. > > Can we just reset the token when we create a new instance of Robot? This will be a big problem for automated testing, as each test with the robot will require user conf

Re: RFR: 8280982: [Wayland] [XWayland] java.awt.Robot taking screenshots

2023-05-05 Thread Alexander Zvegintsev
On Fri, 5 May 2023 02:37:28 GMT, Sergey Bylokhov wrote: > > If the user wishes to change their mind about the screens allowed to be > > captured, the user should use the new Robot#resetScreenCapturePermission > > method > > Do we really need to add this new API? probably we can implement the f

Re: RFR: 8280982: [Wayland] [XWayland] java.awt.Robot taking screenshots [v2]

2023-05-05 Thread Alexander Zvegintsev
On Thu, 4 May 2023 19:52:22 GMT, Erik Joelsson wrote: >> Alexander Zvegintsev has updated the pull request incrementally with three >> additional commits since the last revision: >> >> - update, based on review comments >> - remove wayland detection >&

Re: RFR: 8280982: [Wayland] [XWayland] java.awt.Robot taking screenshots [v2]

2023-05-05 Thread Alexander Zvegintsev
ge is divided into two commits: > 1. added [pipewire > headers](https://gitlab.freedesktop.org/pipewire/pipewire/) that are needed > for the build > 2. main changes > > Changes in the documentation are in a separate draft PR (#13809) also for > convenience. > > At the mom

Re: RFR: 8280982: [Wayland] [XWayland] java.awt.Robot taking screenshots [v2]

2023-05-05 Thread Alexander Zvegintsev
On Fri, 5 May 2023 09:33:00 GMT, Maxim Kartashev wrote: >> Alexander Zvegintsev has updated the pull request incrementally with three >> additional commits since the last revision: >> >> - update, based on review comments >> - remove wayland detection >&

RFR: 8280982: [Wayland] [XWayland] java.awt.Robot taking screenshots

2023-05-04 Thread Alexander Zvegintsev
Modern Linux systems often come with [Wayland](https://wayland.freedesktop.org/) by default. This comes with some difficulties, and one of them is the inability to get screenshots from the system. This is because we now use the [X Window System API](https://en.wikipedia.org/wiki/X_Window_System)