Re: RFR: 8315786: [AIX] Build Disk Local Detection Issue with GNU-utils df on AIX [v2]

2023-09-20 Thread Deepa Kumari
On Wed, 20 Sep 2023 10:21:36 GMT, Deepa Kumari wrote: >> Previously [JDK-8304364](https://github.com/openjdk/jdk/pull/13066/files) , >> the AIX build process raised complaints about the disk location detection, >> incorrectly determining that the build wasn't on a

Integrated: 8315786: [AIX] Build Disk Local Detection Issue with GNU-utils df on AIX

2023-09-20 Thread Deepa Kumari
On Wed, 6 Sep 2023 13:46:01 GMT, Deepa Kumari wrote: > Previously [JDK-8304364](https://github.com/openjdk/jdk/pull/13066/files) , > the AIX build process raised complaints about the disk location detection, > incorrectly determining that the build wasn't on a local disk. However

Re: RFR: 8315786: [AIX] Build Disk Local Detection Issue with GNU-utils df on AIX [v2]

2023-09-20 Thread Deepa Kumari
On Wed, 20 Sep 2023 12:47:19 GMT, Erik Joelsson wrote: > Looks good. I assume you have verified that this still works. Thank you @erikj79 . I appreciate your input. Yes, I have verified the changes , build successfully completed. - PR Comment: https://git.openjdk.org/jdk/pull/15

Re: RFR: 8315786: [AIX] Build Disk Local Detection Issue with GNU-utils df on AIX [v2]

2023-09-20 Thread Deepa Kumari
On Tue, 12 Sep 2023 16:51:53 GMT, Erik Joelsson wrote: >> Deepa Kumari has updated the pull request incrementally with one additional >> commit since the last revision: >> >> remove quotes > > make/autoconf/basic.m4 line 482: > >> 480: # is the s

Re: RFR: 8315786: [AIX] Build Disk Local Detection Issue with GNU-utils df on AIX [v2]

2023-09-20 Thread Deepa Kumari
tly evaluates the **DF** variable as a > command. > > Reported Issue : [JDK-8315786](https://bugs.openjdk.org/browse/JDK-8315786) Deepa Kumari has updated the pull request incrementally with one additional commit since the last revision: remove quotes - Changes: -

Re: RFR: 8315786: [AIX] Build Disk Local Detection Issue with GNU-utils df on AIX

2023-09-08 Thread Deepa Kumari
On Fri, 8 Sep 2023 08:41:41 GMT, Deepa Kumari wrote: >> Previously [JDK-8304364](https://github.com/openjdk/jdk/pull/13066/files) , >> the AIX build process raised complaints about the disk location detection, >> incorrectly determining that the build wasn't on a

Re: RFR: 8315786: [AIX] Build Disk Local Detection Issue with GNU-utils df on AIX

2023-09-08 Thread Deepa Kumari
On Wed, 6 Sep 2023 13:46:01 GMT, Deepa Kumari wrote: > Previously [JDK-8304364](https://github.com/openjdk/jdk/pull/13066/files) , > the AIX build process raised complaints about the disk location detection, > incorrectly determining that the build wasn't on a local disk. However

RFR: 8315786 : [AIX] Build Disk Local Detection Issue with GNU-utils df on AIX

2023-09-07 Thread Deepa Kumari
Previously [JDK-8304364](https://github.com/openjdk/jdk/pull/13066/files) , the AIX build process raised complaints about the disk location detection, incorrectly determining that the build wasn't on a local disk. However, a partial fix introduced a new problem, the build process consistently re

Integrated: 8285850 : [AIX] unreachable code in basic_tools.m4 -> BASIC_CHECK_TAR

2023-01-27 Thread Deepa Kumari
On Mon, 23 Jan 2023 16:47:47 GMT, Deepa Kumari wrote: > basic_tools.m4 contains the line 'elif test "x$TAR_TYPE" = "aix";...' The > comparison "x$TAR_TYPE" = "aix" can never be true. Adding an 'x' to both > sides of the com

Re: RFR: 8285850 : [AIX] unreachable code in basic_tools.m4 -> BASIC_CHECK_TAR

2023-01-26 Thread Deepa Kumari
On Mon, 23 Jan 2023 16:47:47 GMT, Deepa Kumari wrote: > basic_tools.m4 contains the line 'elif test "x$TAR_TYPE" = "aix";...' The > comparison "x$TAR_TYPE" = "aix" can never be true. Adding an 'x' to both > sides of the com

RFR: 8285850 : [AIX] unreachable code in basic_tools.m4 -> BASIC_CHECK_TAR

2023-01-26 Thread Deepa Kumari
basic_tools.m4 contains the line 'elif test "x$TAR_TYPE" = "aix";...' The comparison "x$TAR_TYPE" = "aix" can never be true. Adding an 'x' to both sides of the comparison prevents an erroneous match when the variable is the empty string. Verified the test after successful build and reflecting c