On Fri, 1 Nov 2024 19:38:45 GMT, Jiangli Zhou wrote:
>> Please review this PR that fixes JDK build configure failure when using
>> clang after JDK-8338304:
>>
>>
>> Found candidate GCC installation:
>> Selected GCC installation:
>> ...
>> clang: error: unsupported option '-V -static-libgcc'
On Fri, 1 Nov 2024 00:08:56 GMT, Jiangli Zhou wrote:
> Please review this PR that fixes JDK build configure failure when using clang
> after JDK-8338304:
>
>
> Found candidate GCC installation:
> Selected GCC installation:
> ...
> clang: error: unsupported option '-V -static-libgcc'
> config
On Thu, 31 Oct 2024 10:52:22 GMT, Severin Gehwolf wrote:
>> Please review this patch which adds a jlink mode to the JDK which doesn't
>> need the packaged modules being present. A.k.a run-time image based jlink.
>> Fundamentally this patch adds an option to use `jlink` even though your JDK
>>
On Thu, 31 Oct 2024 13:29:35 GMT, Claes Redestad wrote:
> Benchmarks using Indify was added to the JMH microbenchmarks corpus in the
> JDK 8 timeframe. This adds overhead to the microbenchmarks build and has been
> blocking/slowing progress on some indy-based prototyping as the indify tool
> i
On Thu, 31 Oct 2024 08:53:07 GMT, Claes Redestad wrote:
> Update RunTests.gmk to use `-jvmArgsPrepend` to avoid overwriting built-in
> micro `jvmArgs` flags.
Marked as reviewed by erikj (Reviewer).
-
PR Review: https://git.openjdk.org/jdk/pull/21800#pullrequestreview-2409051253
On Thu, 31 Oct 2024 12:09:25 GMT, Aleksey Shipilev wrote:
> [JDK-8343190](https://bugs.openjdk.org/browse/JDK-8343190) was in mainline
> for a few days. I have now caught the case where JTReg fails to build due to
> network failure (wget exit code 4):
>
>
> Run # Try building JTReg several ti
On Thu, 31 Oct 2024 11:09:13 GMT, Aleksey Shipilev wrote:
> > > Reliability was not the problem the `remove-bundles` block solves. Note
> > > the comment: "# Remove bundles so they are not misconstrued as binary
> > > distributions from the JDK project".
> >
> > Based on discussions about the
On Thu, 31 Oct 2024 09:42:54 GMT, Doug Simon wrote:
> There have been numerous problems in the past with the logic for removing
> bundles:
>
> * [JDK-8340418](https://bugs.openjdk.org/browse/JDK-8340418)
> * [JDK-8336928](https://bugs.openjdk.org/browse/JDK-8336928)
> * [JDK-8338402](https://bu
On Tue, 29 Oct 2024 16:15:30 GMT, Pavel Rappo wrote:
>> Prepare for JDK 25.
>
> Pavel Rappo has updated the pull request incrementally with one additional
> commit since the last revision:
>
> Add forgotten .jcheck/conf
Marked as reviewed by erikj (Reviewer).
-
PR Review: https
On Tue, 29 Oct 2024 13:15:32 GMT, Matthias Baesken wrote:
>> On SUSE with precompiled binutils this error occurs :
>>
>> configure: error: "/mydir/binutils-2.39-s15/lib64 must contain libbfd.a,
>> libopcodes.a and libiberty.a"
>>
>> But the libs are present; the error message and detection is
On Tue, 29 Oct 2024 10:58:34 GMT, Aleksey Shipilev wrote:
> We still sometimes have problems checking out JTReg build dependencies.
> [JDK-8342988](https://bugs.openjdk.org/browse/JDK-8342988) makes it less
> pronounced, but it still happens. We might need to do a retries for JTReg
> builds to
On Tue, 29 Oct 2024 09:21:39 GMT, Matthias Baesken wrote:
> On SUSE with precompiled binutils this error occurs :
>
> configure: error: "/mydir/binutils-2.39-s15/lib64 must contain libbfd.a,
> libopcodes.a and libiberty.a"
>
> But the libs are present; the error message and detection is wrong.
On Mon, 28 Oct 2024 18:58:51 GMT, Aleksey Shipilev wrote:
>> This is the implementation of [JEP 479: _Remove the Windows 32-bit x86
>> Port_](https://openjdk.org/jeps/479).
>>
>> This is the summary of JEP 479:
>>> Remove the source code and build support for the Windows 32-bit x86 port.
>>> T
On Mon, 28 Oct 2024 18:09:41 GMT, Magnus Ihse Bursie wrote:
> This is the implementation of [JEP 479: _Remove the Windows 32-bit x86
> Port_](https://openjdk.org/jeps/479).
>
> This is the summary of JEP 479:
>> Remove the source code and build support for the Windows 32-bit x86 port.
>> This
On Fri, 25 Oct 2024 16:29:52 GMT, Severin Gehwolf wrote:
>> Please review this patch which adds a jlink mode to the JDK which doesn't
>> need the packaged modules being present. A.k.a run-time image based jlink.
>> Fundamentally this patch adds an option to use `jlink` even though your JDK
>>
On Tue, 22 Oct 2024 14:55:47 GMT, Chen Liang wrote:
>> Context: https://mail.openjdk.org/pipermail/build-dev/2024-July/045586.html
>>
>> People were confused on a few details around fixing windows space names,
>> including:
>> 1. setshortname can report confusing error message when the director
On Wed, 23 Oct 2024 21:20:45 GMT, Magnus Ihse Bursie wrote:
> > I'm not sure that error was caused by this issue. That would imply that I
> > had strange file attributes on files in my build directory, and I don't
> > think I do.
>
> I can't see what else did. I think the strange attributes ar
On Tue, 22 Oct 2024 21:30:40 GMT, Erik Joelsson wrote:
> The target mac-jdk-bundle can fail randomly. MacBundles.gmk defines a large
> number of individual copy rules, which can execute in any order. The
> "install-file" (our copy) macro on macos includes a check for weird
On Tue, 22 Oct 2024 21:30:40 GMT, Erik Joelsson wrote:
> The target mac-jdk-bundle can fail randomly. MacBundles.gmk defines a large
> number of individual copy rules, which can execute in any order. The
> "install-file" (our copy) macro on macos includes a check for weird
On Wed, 23 Oct 2024 07:23:44 GMT, Lutz Schmidt wrote:
>> The target mac-jdk-bundle can fail randomly. MacBundles.gmk defines a large
>> number of individual copy rules, which can execute in any order. The
>> "install-file" (our copy) macro on macos includes a check for weird
>> attributes usin
The target mac-jdk-bundle can fail randomly. MacBundles.gmk defines a large
number of individual copy rules, which can execute in any order. The
"install-file" (our copy) macro on macos includes a check for weird attributes
using `xattr` so that we can remove them. We use the switch `-s` to make
On Mon, 21 Oct 2024 14:41:48 GMT, Aleksey Shipilev wrote:
> When GH output is too large, we do not actually truncate it after
> [JDK-8341424](https://bugs.openjdk.org/browse/JDK-8341424). The error log
> would be:
>
>
> Run bash ./.github/scripts/gen-test-results.sh "$GITHUB_STEP_SUMMARY"
> .
On Mon, 21 Oct 2024 13:12:55 GMT, SendaoYan wrote:
>> Hi all,
>> In
>> [make/RunTests.gmk](https://github.com/openjdk/jdk/blob/master/make/RunTests.gmk#L208),
>> the keyword is 'TEST_THREAD_FACTORY'.
>>
>> So the below test command will print error:
>>
>> make test TEST=test/jdk/java/math/Big
On Sun, 20 Oct 2024 02:11:11 GMT, SendaoYan wrote:
> Hi all,
> In
> [make/RunTests.gmk](https://github.com/openjdk/jdk/blob/master/make/RunTests.gmk#L208),
> the keyword is 'TEST_THREAD_FACTORY'.
>
> So the below test command will print error:
>
> make test TEST=test/jdk/java/math/BigInteger/
On Fri, 18 Oct 2024 12:51:46 GMT, Nizar Benalla wrote:
>> Please review this change that adds a new test root `docs` dedicated to
>> testing the documentation, which has been a work in progress for a while.
>> Tests for links, encoding, HTML, accessibility will be later added in
>> following P
On Fri, 18 Oct 2024 12:46:36 GMT, Nizar Benalla wrote:
> I'd like to avoid integrating this right before the weekend, and I still want
> to add copyright headers to the other TEST.ROOT files if I can find out when
> they were added. I roughly know how to do it.
I would say fixing copyrights in
On Fri, 18 Oct 2024 12:44:36 GMT, Nizar Benalla wrote:
>> Can I get a review for this patch that adds the necessary changes for local
>> support of the `tidy` library.
>>
>> The dependency can be retrieved by running `make/devkit/createTidyBundle.sh`
>> on Linux and MacOs systems.
>>
>> This
On Fri, 18 Oct 2024 08:47:31 GMT, Nizar Benalla wrote:
>> Can I get a review for this patch that adds the necessary changes for local
>> support of the `tidy` library.
>>
>> The dependency can be retrieved by running `make/devkit/createTidyBundle.sh`
>> on Linux and MacOs systems.
>>
>> This
On Fri, 18 Oct 2024 12:29:30 GMT, Magnus Ihse Bursie wrote:
>> It's fine to leave out the conditional, but the double `$$` isn't needed and
>> I'm surprised if it actually works. That must be some lucky double
>> evaluation somewhere in that case.
>>
>> Suggestion:
>>
>> $1_JTREG_BASIC_OPT
On Fri, 18 Oct 2024 09:14:06 GMT, Nizar Benalla wrote:
>> Nizar Benalla has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> use existing DOCS_JDK_IMAGE_DIR to be consistent.
>>
>> no ifneq check before assigning the env variable because
On Fri, 18 Oct 2024 08:39:49 GMT, Nizar Benalla wrote:
>> Please review this change that adds a new test root `docs` dedicated to
>> testing the documentation, which has been a work in progress for a while.
>> Tests for links, encoding, HTML, accessibility will be later added in
>> following P
On Fri, 18 Oct 2024 01:33:18 GMT, Fei Yang wrote:
> In JDK-8339548, we switched to use Debian snapshot
> (https://snapshot.debian.org/archive/debian/20240228T034848Z/) for bootstrap.
> The reason is that we don't have a stable Debian release for RISC-V yet and
> Debian "sid" (https://httpredir
On Wed, 16 Oct 2024 16:19:51 GMT, Nizar Benalla wrote:
>> Please review this change that adds a new test root `docs` dedicated to
>> testing the documentation, which has been a work in progress for a while.
>> Tests for links, encoding, HTML, accessibility will be later added in
>> following P
On Tue, 15 Oct 2024 18:46:55 GMT, Nizar Benalla wrote:
>> make/RunTestsPrebuiltSpec.gmk line 182:
>>
>>> 180: ifneq ($(TIDY_HOME), )
>>> 181: TIDY := $(TIDY_HOME)
>>> 182: endif
>>
>> This is worse than before. Please forget what I said initially about
>> `TIDY_HOME`, it should certainly not
On Tue, 15 Oct 2024 18:45:37 GMT, Nizar Benalla wrote:
>> Please review this change that adds a new test root `docs` dedicated to
>> testing the documentation, which has been a work in progress for a while.
>> Tests for links, encoding, HTML, accessibility will be later added in
>> following P
On Tue, 15 Oct 2024 17:57:59 GMT, Nizar Benalla wrote:
>> Can I get a review for this patch that adds the necessary changes for local
>> support of the `tidy` library.
>>
>> The dependency can be retrieved by running `make/devkit/createTidyBundle.sh`
>> on Linux and MacOs systems.
>>
>> This
On Mon, 14 Oct 2024 13:52:24 GMT, Sean Mullan wrote:
> This is the implementation of JEP 486: Permanently Disable the Security
> Manager. See [JEP 486](https://openjdk.org/jeps/486) for more details. The
> [CSR](https://bugs.openjdk.org/browse/JDK-8338412) describes in detail the
> main change
On Tue, 15 Oct 2024 15:28:49 GMT, Nizar Benalla wrote:
>> Can I get a review for this patch that adds the necessary changes for local
>> support of the `tidy` library.
>>
>> The dependency can be retrieved by running `make/devkit/createTidyBundle.sh`
>> on Linux and MacOs systems.
>>
>> This
On Mon, 14 Oct 2024 13:08:32 GMT, Aleksey Shipilev wrote:
> This implicitly fixes x86-32 builds that fail at runtime, because late
> barrier expansion is not implemented for them. I think about this check as
> something that we should have done as part of original JDK-8334060.
>
> The first ve
On Fri, 11 Oct 2024 15:55:08 GMT, Nizar Benalla wrote:
> Is it okay to assume that if someone wants to test the generated docs, he
> will have most luckily built them beforehand?
> So it can work if users use `make test TEST=some/specific/test/in/docs`,
> while not being ideal.
I definitely th
On Thu, 10 Oct 2024 12:25:53 GMT, Kevin Rushforth wrote:
>> Deprecate the `jdk.jsobject` module for removal from the JDK, and ship it
>> with JavaFX instead.
>>
>> See [JDK-8337280](https://bugs.openjdk.org/browse/JDK-8337280) / PR
>> openjdk/jfx#1529 for the JavaFX PR that will include the mo
On Thu, 10 Oct 2024 21:57:57 GMT, Nizar Benalla wrote:
>> Please review this change that adds a new test root `docs` dedicated to
>> testing the documentation, which has been a work in progress for a while.
>> Tests for links, encoding, HTML, accessibility will be later added in
>> following P
On Thu, 10 Oct 2024 00:16:40 GMT, Nizar Benalla wrote:
>> Please review this change that adds a new test root `docs` dedicated to
>> testing the documentation, which has been a work in progress for a while.
>> Tests for links, encoding, HTML, accessibility will be later added in
>> following P
On Thu, 10 Oct 2024 13:55:40 GMT, Nizar Benalla wrote:
> I made a few changes based on the review comments. After a few iterations, I
> now define module as `"tidy-html-" + input.target_os`. The dependency is
> indeed multi arch so only one is needed for macos.
When it's not too much work, we
On Fri, 4 Oct 2024 00:17:14 GMT, Nizar Benalla wrote:
> Can I get a review for this patch that adds the necessary changes for local
> support of the `tidy` library.
>
> The dependency can be retrieved by running `make/devkit/createTidyBundle.sh`
> on Linux and MacOs systems.
>
> This dependen
On Tue, 1 Oct 2024 19:25:39 GMT, Mikael Vidstedt wrote:
> With the JDK 23 GA out it's time to bump the minimum boot JDK version for
> mainline/JDK 24.
>
> Testing: tier1-5, GHA
Marked as reviewed by erikj (Reviewer).
-
PR Review: https://git.openjdk.org/jdk/pull/21296#pullrequest
On Mon, 30 Sep 2024 18:53:57 GMT, Nizar Benalla wrote:
> Please review this change that adds a new test root `docs` dedicated to
> testing the documentation, which has been a work in progress for a while.
> Tests for links, encoding, HTML, accessibility will be later added in
> following PRs.
On Fri, 27 Sep 2024 10:05:08 GMT, Matthias Baesken wrote:
> The jtreg test build/AbsPathsInImage.java fails with OOM when using
> ubsan-enabled binaries (on Linux x86_64).
> Reason seems to be that the ubsan-enabled binaries are much larger than
> 'normal' product binaries.
> (for debug binarie
On Wed, 25 Sep 2024 06:28:18 GMT, George Adams wrote:
>> Currently the [security tab](https://github.com/openjdk/jdk/security) on the
>> GitHub repos is empty with no clear information or links on where to report
>> security vulnerabilities.
>>
>> > src="https://github.com/user-attachments/ass
since the last revision:
>
> Update building.md
>
> Co-authored-by: Erik Joelsson <37597443+erik...@users.noreply.github.com>
Marked as reviewed by erikj (Reviewer).
-
PR Review: https://git.openjdk.org/jdk/pull/21154#pullrequestreview-2325954191
On Tue, 24 Sep 2024 13:28:47 GMT, George Adams wrote:
> Currently the [security tab](https://github.com/openjdk/jdk/security) on the
> GitHub repos is empty with no clear information or links on where to report
> security vulnerabilities.
>
> src="https://github.com/user-attachments/assets/4f
On Tue, 24 Sep 2024 13:08:50 GMT, George Adams wrote:
>> Since JDK17 there has been a dependency on metal in the macOS builds which
>> is only available as part of the full Xcode IDE (rather than command-line
>> tools). We currently recommend only installing the command-line tools in the
>> bu
On Tue, 24 Sep 2024 12:54:49 GMT, George Adams wrote:
>> doc/building.html line 618:
>>
>>> 616: The oldest supported version of Xcode is 13.0.
>>> 617: You will need to download Xcode either from the App Store or
>>> specific
>>> 618: versions can be easily located via >> href="https://xcodere
On Tue, 24 Sep 2024 11:21:33 GMT, George Adams wrote:
> Since JDK17 there has been a dependency on metal in the macOS builds which is
> only available as part of the full Xcode IDE (rather than command-line
> tools). We currently recommend only installing the command-line tools in the
> buildi
On Mon, 23 Sep 2024 07:30:59 GMT, Hamlin Li wrote:
>> Hi,
>> Can you help to review this patch?
>> Thanks!
>>
>> This patch is based on https://github.com/openjdk/jdk/pull/20781 which added
>> the sleef source (in particular the generated sleef inline headers). We use
>> sleef api to vectorize
On Sun, 22 Sep 2024 09:46:43 GMT, Thomas Stuefe wrote:
> Trivial change to drop the optimization level (for both fastdebug and
> release) of stackMapTable.cpp to O1 on MacOS with Xcode 16.
>
> This is a workaround for https://bugs.openjdk.org/browse/JDK-8340341, which
> prevents building on Ma
On Thu, 19 Sep 2024 16:35:14 GMT, Hamlin Li wrote:
>> Sorry, I had to remind myself of how this works. We actually set this as a
>> separate parameter on the Setup macro: `OPTIMIZATION := HIGH`
>
> Thanks. I'm sorry too, I'm not familiar with the build system.
> What you expected could be someth
On Thu, 19 Sep 2024 13:47:50 GMT, Hamlin Li wrote:
>> make/modules/jdk.incubator.vector/Lib.gmk line 48:
>>
>>> 46: DISABLED_WARNINGS_gcc := unused-function sign-compare
>>> tautological-compare ignored-qualifiers, \
>>> 47: DISABLED_WARNINGS_clang := unused-function sign-compare
>
On Thu, 19 Sep 2024 08:32:38 GMT, Hamlin Li wrote:
> Hi,
> Can you help to review this patch?
> Thanks!
>
> This patch is based on https://github.com/openjdk/jdk/pull/20781 which added
> the sleef source (in particular the generated sleef inline headers). We use
> sleef api to vectorize the ma
On Thu, 19 Sep 2024 05:51:00 GMT, Aleksey Shipilev wrote:
> `remove-bundles` step does not depend on `test-macos-aarch64`, which means it
> can run before macos-aarch64 tests start to run, which would fail those
> steps. This is not frequent, but will happen if macos-aarch64 runners are
> lagg
On Tue, 17 Sep 2024 12:47:24 GMT, Magnus Ihse Bursie wrote:
>> [JDK-8312425](https://bugs.openjdk.org/browse/JDK-8312425) is looking to
>> optimize vector math operations by leveraging the SLEEF library. For legal
>> reasons the actual contribution of the SLEEF files needs to be handled
>> sep
On Thu, 12 Sep 2024 22:33:43 GMT, Erik Joelsson wrote:
> The autoconf launcher script in the autoconf bundle created by
> `make/devkit/createAutoconf.sh` currently writes a config file into the
> bundle installation dir every time it runs. This prevents it from functioning
> when
The autoconf launcher script in the autoconf bundle created by
`make/devkit/createAutoconf.sh` currently writes a config file into the bundle
installation dir every time it runs. This prevents it from functioning when
installed on a read-only filesystem. We can work around the need for writing t
On Thu, 5 Sep 2024 13:16:41 GMT, Erik Joelsson wrote:
>> Debian "sid" or "unstable" (https://httpredir.debian.org/debian) that we use
>> for debootstrapping RISC-V breaks very often. Currently, the GHA
>> linux-cross-build for RISC-V would not contin
On Wed, 4 Sep 2024 14:40:38 GMT, Fei Yang wrote:
> Debian "sid" or "unstable" (https://httpredir.debian.org/debian) that we use
> for debootstrapping RISC-V breaks very often. Currently, the GHA
> linux-cross-build for RISC-V would not continue and is simply skipped when
> this debootstrap for
On Tue, 3 Sep 2024 17:43:38 GMT, Magnus Ihse Bursie wrote:
>> After JDK-8338404, the build produces warnings like:
>>
>> /bin/tee:
>> /localhome/git/jdk-CDR/build/linux-x64/support/interim-image/jlink.log: No
>> such file or directory
>>
>> Fix this by using a proper SetupExecute instead.
>
>
On Tue, 3 Sep 2024 12:50:01 GMT, Magnus Ihse Bursie wrote:
> As a prerequisite for Hermetic Java, we need a statically linked `java`
> launcher. It should behave like the normal, dynamically linked `java`
> launcher, except that all JDK native libraries should be statically, not
> dynamically,
On Tue, 3 Sep 2024 12:50:01 GMT, Magnus Ihse Bursie wrote:
> As a prerequisite for Hermetic Java, we need a statically linked `java`
> launcher. It should behave like the normal, dynamically linked `java`
> launcher, except that all JDK native libraries should be statically, not
> dynamically,
On Sun, 1 Sep 2024 06:37:26 GMT, Doug Simon wrote:
> This PR modifies the GitHub Actions product build on Linux to include
> building of the static-libs bundle.
> This is a minimal smoke test to ensure these builds don't break.
I think adding static libs to one platform and flavor combination s
On Mon, 2 Sep 2024 12:20:24 GMT, Magnus Ihse Bursie wrote:
> After JDK-8338404, the build produces warnings like:
>
> /bin/tee:
> /localhome/git/jdk-CDR/build/linux-x64/support/interim-image/jlink.log: No
> such file or directory
>
> Fix this by using a proper SetupExecute instead.
Marked as
On Mon, 2 Sep 2024 12:28:17 GMT, Magnus Ihse Bursie wrote:
> From the bug report:
>
> Users are reporting warnings like this:
>
> lib/CompileGtest.gmk:84: warning: overriding recipe for target
> '/.../build/linux-x64/make-support/compile-commands/jvm-ldflags.txt'
> lib/CompileJvm.gmk:166: warn
On Sun, 1 Sep 2024 21:35:02 GMT, Magnus Ihse Bursie wrote:
>> The build system code has unfortunately diverted in some places from the
>> conventions as described in
>> https://openjdk.org/groups/build/doc/code-conventions.html.
>>
>> Instead of trying to fix these when touching code nearby, I
On Mon, 2 Sep 2024 08:59:05 GMT, Magnus Ihse Bursie wrote:
> I've done that now, and it looks clean on all platforms. (With one exception:
> we include the vardeps files for jar files in jdk/demos -- historical
> reasons, I assume -- and they look slightly different; but they should not
> real
On Fri, 30 Aug 2024 16:27:18 GMT, Magnus Ihse Bursie wrote:
> The build system code has unfortunately diverted in some places from the
> conventions as described in
> https://openjdk.org/groups/build/doc/code-conventions.html.
>
> Instead of trying to fix these when touching code nearby, I'd l
forward that was held in that original PR.
>
> Magnus Ihse Bursie has updated the pull request incrementally with two
> additional commits since the last revision:
>
> - Use "whitespace" as an uncountable noun
>
>Co-authored-by: Erik Joelsson <37597443+er
On Fri, 30 Aug 2024 16:03:19 GMT, Magnus Ihse Bursie wrote:
>> [JDK-8312425](https://bugs.openjdk.org/browse/JDK-8312425) is looking to
>> optimize vector math operations by leveraging the SLEEF library. For legal
>> reasons the actual contribution of the SLEEF files needs to be handled
>> sep
On Fri, 30 Aug 2024 11:35:51 GMT, Magnus Ihse Bursie wrote:
>> Currently, we issue -Wno-unused for all files in clang, which is a rather
>> big sledgehammer to get rid of some warnings that proliferate in a few areas
>> of the build.
>>
>> We should instead leave -Wunused turned on (as done by
On Thu, 29 Aug 2024 23:07:16 GMT, Magnus Ihse Bursie wrote:
> [JDK-8312425](https://bugs.openjdk.org/browse/JDK-8312425) is looking to
> optimize vector math operations by leveraging the SLEEF library. For legal
> reasons the actual contribution of the SLEEF files needs to be handled
> separat
On Wed, 28 Aug 2024 14:49:26 GMT, Magnus Ihse Bursie wrote:
> From the bug report:
>
> After JDK-8318913, trying to cross-compile to a different endian target than
> the build host is using, will cause the interim image generation to fail:
>
>
> [buildjdk] Creating interim jimage
> Error: spe
On Thu, 29 Aug 2024 13:14:35 GMT, Magnus Ihse Bursie wrote:
> Currently, we issue -Wno-unused for all files in clang, which is a rather big
> sledgehammer to get rid of some warnings that proliferate in a few areas of
> the build.
>
> We should instead leave -Wunused turned on (as done by -Wal
On Thu, 29 Aug 2024 13:24:31 GMT, Magnus Ihse Bursie wrote:
>> The indentation in the build system should be two spaces for logical
>> indents, and four spaces for broken lines, period.
>>
>> I searched for files starting with an odd number of spaces, and fixed those.
>
> Magnus Ihse Bursie has
On Thu, 29 Aug 2024 12:39:28 GMT, Magnus Ihse Bursie wrote:
> Furthermore, despite what Erik said above, I would really, really like to not
> have a stand-alone shell script mixed in with the spleef sources. Instead, we
> should treat updating the generated spleef sources as any other build-rel
On Thu, 29 Aug 2024 09:02:36 GMT, Magnus Ihse Bursie wrote:
> The indentation in the build system should be two spaces for logical indents,
> and four spaces for broken lines, period.
>
> I searched for files starting with an odd number of spaces, and fixed those.
Thanks for fixing this! See t
On Wed, 28 Aug 2024 15:36:41 GMT, Hamlin Li wrote:
> 3]. scripts to transfering from 1] to 2], and necessary documents, e.g.
> record which tag of sleef to use, .
In addition to the tag, we should include the full git hash as well. A tag can
be moved, but it's very hard to fake a new git hash
On Wed, 28 Aug 2024 15:17:52 GMT, Magnus Ihse Bursie wrote:
>> Currently, we issue -Wno-unused for all files in gcc, which is a rather big
>> sledgehammer to get rid of some warnings that proliferate in a few areas of
>> the build.
>>
>> We should instead leave -Wunused turned on (as done by -
On Mon, 26 Aug 2024 02:07:39 GMT, David Holmes wrote:
> I understand the cost overhead experienced by any individual Java run may be
> lost in the noise, but it still impacts every single Java run just to save
> some time/resources for the handful of builders of statically linked VMs. I
> am n
On Wed, 21 Aug 2024 14:07:00 GMT, Magnus Ihse Bursie wrote:
>> Add a make target to generate an Xcode project file for Hotspot.
>>
>> This PR is the result of a cooperation between me and @gerard-ziemski.
>> Gerard developed the original Xcode generator (as a stand-alone project in
>> https:/
On Tue, 13 Aug 2024 09:57:51 GMT, Magnus Ihse Bursie wrote:
> Add a make target to generate an Xcode project file for Hotspot.
>
> This PR is the result of a cooperation between me and @gerard-ziemski. Gerard
> developed the original Xcode generator (as a stand-alone project in
> https://gith
On Wed, 21 Aug 2024 11:21:34 GMT, Jan Lahoda wrote:
>> Currently incremental builds for the microbenchmarks may take notable amount
>> of time, like:
>>
>> $ touch test/micro/org/openjdk/bench/java/io/BlackholedOutputStream.java;
>> time make test TEST=jaxp:tier1
>> Building target 'test' in c
On Tue, 16 Jul 2024 20:50:32 GMT, Lutz Schmidt wrote:
> On MacOS, files may have extended attributes attached. These attributes are
> copied together with the files. To prevent issues during further processing,
> the extended attributes of the copies must be removed. This action was
> implemen
On Fri, 16 Aug 2024 12:24:19 GMT, Jan Lahoda wrote:
> Currently incremental builds for the microbenchmarks may take notable amount
> of time, like:
>
> $ touch test/micro/org/openjdk/bench/java/io/BlackholedOutputStream.java;
> time make test TEST=jaxp:tier1
> Building target 'test' in configu
On Wed, 14 Aug 2024 13:01:09 GMT, Matthias Baesken wrote:
>> After [JDK-8333189](https://bugs.openjdk.org/browse/JDK-8333189) I get now
>> this build error (when using clang on Linux) :
>> `clang: error: invalid linker name in argument '-fuse-ld=lld'`
>> We should better check for lld in the co
On Wed, 14 Aug 2024 10:49:27 GMT, Matthias Baesken wrote:
> After [JDK-8333189](https://bugs.openjdk.org/browse/JDK-8333189) I get now
> this build error (when using clang on Linux) :
> `clang: error: invalid linker name in argument '-fuse-ld=lld'`
> We should better check for lld in the config
Something like that yes. Maybe just BOOT_JDK_RELEASE, or possibly
BOOT_JDK_RELEASE_FLAG?
/Erik
On 8/12/24 5:56 AM, Baesken, Matthias wrote:
You mean instead of BOOT_JDK_SOURCETARGET use
BOOT_JDK_RELEASETARGET (and set '--release N-1' there) ?
Best regards, Matthias
*
There is a variable BOOT_JDK_SOURCETARGET exported from configure and
picked up in JavaCompilation.gmk. We should probably change the name of
the variable as well to avoid confusion.
/Erik
On 8/12/24 12:08 AM, Baesken, Matthias wrote:
Hi Erik, the '--release N-1' sounds like a good idea ;
On Fri, 9 Aug 2024 13:37:54 GMT, Fei Gao wrote:
>> This patch enables BTI branch protection for runtime part on Linux/aarch64
>> platform.
>>
>> Motivation
>>
>> 1. Since Fedora 33, glibc+kernel are PAC/BTI enabled by default. User-level
>> packages can gain additional hardening by compiling
On Fri, 9 Aug 2024 10:27:25 GMT, Magnus Ihse Bursie wrote:
> The XCode command lines tools is almost, but not quite, enough to build the
> JDK. We still need the metal and metallib tools. The error message given by
> configure should be improved to indicate if this is the problem with the
> us
quirements in the company most
likely have a problem with an old / unpatched JDK20 .
Best regards, Matthias
*From:*Erik Joelsson
*Sent:* Wednesday, 7 August 2024 13:58
*To:* Baesken, Matthias ; Magnus Ihse Bursie
*Subject:* Re: jdk21u-dev build issue : 8326332: Unclosed inline tags
cause
On Tue, 16 Jul 2024 20:50:32 GMT, Lutz Schmidt wrote:
> On MacOS, files may have extended attributes attached. These attributes are
> copied together with the files. To prevent issues during further processing,
> the extended attributes of the copies must be removed. This action was
> implemen
Hello Brian,
(Unfortunately) only members of the respective groups are able to edit
group specific wiki pages, so in this case you need someone in the build
group to handle it for you. Perhaps if you are taking ownership of a
port, you would want to volunteer someone to join the build group an
1 - 100 of 952 matches
Mail list logo
