Re: RFR: 8363910: Avoid tuning for Power10 CPUs on Linux ppc64le when gcc < 10 is used

2025-07-24 Thread Lutz Schmidt
On Wed, 23 Jul 2025 12:23:04 GMT, Matthias Baesken wrote: > Older gcc version (8, 9) do not support the -mtune=power10 flag. We should > set this only when recent gcc versions are used. Just for my understanding: If `-mtune=power10` is already in the arguments, nothing is changed/added. In any

Re: RFR: 8360791: [ubsan] Adjust signal handling [v2]

2025-07-01 Thread Lutz Schmidt
On Mon, 30 Jun 2025 07:02:31 GMT, Matthias Baesken wrote: >> A couple of tests e.g. VendorInfoPluginsTest but also some Hotspot like >> runtime/ErrorHandling/CreateCoredumpOnCrash.java put (write) to special >> addresses like 0 to provoke crashs. >> However this does not work well with ubsan-en

Re: RFR: 8351440: Link with -reproducible on macOS

2025-06-18 Thread Lutz Schmidt
On Fri, 7 Mar 2025 20:46:32 GMT, Mikael Vidstedt wrote: > Background (from JBS): > > Recent versions of Xcode, most likely starting with Xcode 15, do not produce > deterministic binaries/libraries out of the box. In particular, the UUID data > in the LC_UUID load command is not stable. > > Af

Re: RFR: 8355570: [s390x] Update -march to z13 generation [v2]

2025-05-16 Thread Lutz Schmidt
On Thu, 15 May 2025 16:03:51 GMT, Amit Kumar wrote: >> updated march level from z10 to z13. >> >> Testing: tier1 (fastdebug-vm) > > Amit Kumar has updated the pull request with a new target base due to a merge > or a rebase. The incremental webrev excludes the unrelated changes brought in > by

Re: RFR: 8345590: AIX 'make all' fails after JDK-8339480

2024-12-12 Thread Lutz Schmidt
On Thu, 12 Dec 2024 14:14:18 GMT, Matthias Baesken wrote: > On AIX we after [JDK-8339480](https://bugs.openjdk.org/browse/JDK-8339480) > into this error > > > make all > Building target 'all' in configuration '/open_jdk/jdk/build_aix' > Creating 1 test executable file(s) for BUILD_LIBTEST_JTRE

Re: RFR: 8344607: Link Time Optimization - basic support for clang [v4]

2024-12-05 Thread Lutz Schmidt
On Tue, 3 Dec 2024 16:46:04 GMT, Matthias Baesken wrote: >> Support the clang toolchain when link time optimization is configured. >> Please note that this is NOT intended to enable lto by default and NOT to >> fix all possible clang-supporting builds or test issues . >> >> It works on my Linux

Re: RFR: 8344607: Link Time Optimization - basic support for clang

2024-11-27 Thread Lutz Schmidt
On Wed, 27 Nov 2024 15:14:10 GMT, Matthias Baesken wrote: > Support the clang toolchain when link time optimization is configured. > Please note that this is NOT intended to enable lto by default and NOT to fix > all possible clang-supporting builds or test issues . > > It works on my Linux x86

Re: RFR: 8342858: Make target mac-jdk-bundle fails on chmod command

2024-10-23 Thread Lutz Schmidt
On Wed, 23 Oct 2024 12:32:44 GMT, Erik Joelsson wrote: >> make/common/FileUtils.gmk line 141: >> >>> 139: $(CHMOD) -h u+w '$(call DecodeSpace, $@)'; \ >>> 140: $(XATTR) -cs '$(call DecodeSpace, $@)'; \ >>> 141:fi >> >> What about running chmod only against real files?

Re: RFR: 8342858: Make target mac-jdk-bundle fails on chmod command

2024-10-23 Thread Lutz Schmidt
On Tue, 22 Oct 2024 21:30:40 GMT, Erik Joelsson wrote: > The target mac-jdk-bundle can fail randomly. MacBundles.gmk defines a large > number of individual copy rules, which can execute in any order. The > "install-file" (our copy) macro on macos includes a check for weird > attributes using `

Re: RFR: 8342858: Make target mac-jdk-bundle fails on chmod command

2024-10-23 Thread Lutz Schmidt
On Tue, 22 Oct 2024 21:30:40 GMT, Erik Joelsson wrote: > The target mac-jdk-bundle can fail randomly. MacBundles.gmk defines a large > number of individual copy rules, which can execute in any order. The > "install-file" (our copy) macro on macos includes a check for weird > attributes using `

Integrated: 8336498: [macos] [build]: install-file macro may run into permission denied error

2024-08-21 Thread Lutz Schmidt
On Tue, 16 Jul 2024 20:50:32 GMT, Lutz Schmidt wrote: > On MacOS, files may have extended attributes attached. These attributes are > copied together with the files. To prevent issues during further processing, > the extended attributes of the copies must be removed. This a

Re: RFR: 8336498: [macos] [build]: install-file macro may run into permission denied error

2024-08-20 Thread Lutz Schmidt
On Tue, 16 Jul 2024 20:50:32 GMT, Lutz Schmidt wrote: > On MacOS, files may have extended attributes attached. These attributes are > copied together with the files. To prevent issues during further processing, > the extended attributes of the copies must be removed. This a

Re: RFR: 8336498: [macos] [build]: install-file macro may run into permission denied error

2024-08-05 Thread Lutz Schmidt
On Mon, 5 Aug 2024 15:25:32 GMT, Magnus Ihse Bursie wrote: > Hi, I'm back from vacation now. Looks like we are taking turns. Now I'm on vacation. Thorough analysis of why the issue pops up occasionally will have to wait until I'm back (Aug 19th). I have no specific idea in which direction I sh

Re: RFR: 8336498: [macos] [build]: install-file macro may run into permission denied error

2024-07-30 Thread Lutz Schmidt
On Tue, 16 Jul 2024 20:50:32 GMT, Lutz Schmidt wrote: > On MacOS, files may have extended attributes attached. These attributes are > copied together with the files. To prevent issues during further processing, > the extended attributes of the copies must be removed. This a

Re: RFR: 8336498: [macos] [build]: install-file macro may run into permission denied error

2024-07-19 Thread Lutz Schmidt
On Fri, 19 Jul 2024 14:19:59 GMT, Jaikiran Pai wrote: > Hello Lutz, would it be possible to wait a few more days on this one? ... Sure, I'll stand by. - PR Comment: https://git.openjdk.org/jdk/pull/20203#issuecomment-2239799703

Re: RFR: 8336498: [macos] [build]: install-file macro may run into permission denied error

2024-07-19 Thread Lutz Schmidt
On Tue, 16 Jul 2024 20:50:32 GMT, Lutz Schmidt wrote: > On MacOS, files may have extended attributes attached. These attributes are > copied together with the files. To prevent issues during further processing, > the extended attributes of the copies must be removed. This a

Re: RFR: 8336498: [macos] [build]: install-file macro may run into permission denied error

2024-07-18 Thread Lutz Schmidt
On Thu, 18 Jul 2024 14:16:21 GMT, Lutz Schmidt wrote: >> Looks trivial. Can you hint on how to reproduce the issue? E.g. for which >> file I should remove the user write permission to get the build failing? > > Thank you for the review, @RealCLanger ! > > Crea

Re: RFR: 8336498: [macos] [build]: install-file macro may run into permission denied error

2024-07-18 Thread Lutz Schmidt
On Wed, 17 Jul 2024 20:35:04 GMT, Christoph Langer wrote: >> On MacOS, files may have extended attributes attached. These attributes are >> copied together with the files. To prevent issues during further processing, >> the extended attributes of the copies must be removed. This action was >>

RFR: 8336498: [macos] [build]: install-file macro may run into permission denied error

2024-07-16 Thread Lutz Schmidt
On MacOS, files may have extended attributes attached. These attributes are copied together with the files. To prevent issues during further processing, the extended attributes of the copies must be removed. This action was implemented as solution of an older bug. The solution is incomplete bec

Re: RFR: 8334618: ubsan: support setting additional ubsan check options [v4]

2024-06-26 Thread Lutz Schmidt
On Tue, 25 Jun 2024 11:20:38 GMT, Matthias Baesken wrote: >> Sometimes it would be helpful to have configure-support for adding >> additional ubsan check options. >> E.g. support new configure option >> '--with-additional-ubsan-checks=' . > > Matthias Baesken has updated the pull request increm

Re: RFR: 8318834: s390x: Debug builds are missing debug helpers

2023-10-26 Thread Lutz Schmidt
On Wed, 25 Oct 2023 17:26:13 GMT, Andrew Haley wrote: > On s390x only, HotSpot is built by GCC with -ffunction-sections. > This means that debug helpers such as ps() and pfl() are not available. These > helpers are extremely useful in debugging, so it makes no sense to omit them > from debug bu

Re: RFR: JDK-8307604: gcc12 based Alpine build broken build after JDK-8307301

2023-05-08 Thread Lutz Schmidt
On Mon, 8 May 2023 10:29:56 GMT, Matthias Baesken wrote: > After the harfbuzz 7.2 update we run into > > /linuxmuslx86_64/jdk-dev/src/java.desktop/share/native/libharfbuzz/OT/glyf/Glyph.hh:281:8: > error: offset '4' outside bounds of constant string [-Werror=array-bounds] > 281 | bool get_poi

Re: RFR: 8304915: Create jdk.internal.util.Architecture enum and apply [v10]

2023-04-12 Thread Lutz Schmidt
On Wed, 12 Apr 2023 03:44:45 GMT, Amit Kumar wrote: > Another remark: Old JDK on s390 used "os.arch = zArch_64", current one > "os.arch = s390x". @offamitkumar: You probably want to take a look. zArch_64 is not relevant/not used in the OpenJDK port to IBM System z. As noted elsewhere in the PR

Re: RFR: 8304915: Create jdk.internal.util.Architecture enum and apply [v7]

2023-04-07 Thread Lutz Schmidt
On Fri, 7 Apr 2023 11:21:33 GMT, Thomas Stuefe wrote: >> Hello Thomas, that change was based on the review comment here >> https://github.com/openjdk/jdk/pull/13357#discussion_r1159810942 > > Okay, Lutz is the expert here. Sorry for the noise. Just to let my voice be heard directly after being

Re: RFR: 8305174: disable dtrace for s390x builds

2023-03-29 Thread Lutz Schmidt
On Wed, 29 Mar 2023 13:04:39 GMT, Amit Kumar wrote: > As stated in JBS-issue, `dtrace` functionality is not available on s390x. So > disabling it explicitly in the build. Looks good and trivial. For formal reasons, we may want to wait for the GHA to complete before we integrate and sponsor.

Re: RFR: JDK-8304867: Explicitly disable dtrace for ppc builds [v2]

2023-03-27 Thread Lutz Schmidt
On Fri, 24 Mar 2023 12:20:32 GMT, Matthias Baesken wrote: >> Currently the support for the JVM feature 'dtrace' is not implemented in the >> HS codebase on ppc, so we should disable it in the jvm-features make >> detection as well. Otherwise we could run into building with dtrace feature >> su

Re: RFR: JDK-8301661: Enhance os::pd_print_cpu_info on macOS and Windows [v4]

2023-02-14 Thread Lutz Schmidt
On Thu, 9 Feb 2023 10:21:11 GMT, Matthias Baesken wrote: >> Enhance os::pd_print_cpu_info on macOS and Windows by information about CPU >> frequency and caches. >> On Windows , this info can be obtained by the Processor Power Information >> API or "powerbase" (CallNtPowerInformation , see >> h