On Thu, 23 Nov 2023 11:52:38 GMT, Stefan Karlsson wrote:
>> In the rewrites made for:
>> [JDK-8318757](https://bugs.openjdk.org/browse/JDK-8318757) `VM_ThreadDump
>> asserts in interleaved ObjectMonitor::deflate_monitor calls`
>>
>> I removed the filtering of *
On Thu, 23 Nov 2023 00:48:19 GMT, David Holmes wrote:
> > Previously, the locked monitors never got unlocked because the
> > ObjectMonitor iterator never exposed these monitors to the JNI detach code
>
> I had not realized that. It explains some confusion in a separate issue I had
> been
thread holds a lock
> with a dead object, and the code will return NULL as one of the "owned
> monitors" returned. I don't think that's a good idea, so I'm filtering out
> these ObjectMonitor for those calls.
>
> Test: the written tests with and without the fix. Tier1-Tier3, s
thread holds a lock
> with a dead object, and the code will return NULL as one of the "owned
> monitors" returned. I don't think that's a good idea, so I'm filtering out
> these ObjectMonitor for those calls.
>
> Test: the written tests with and without the fix. Tier1-Tier3, so
On Thu, 23 Nov 2023 02:10:41 GMT, David Holmes wrote:
>> Stefan Karlsson has updated the pull request incrementally with two
>> additional commits since the last revision:
>>
>> - Tweaked comment in test
>> - Rewrite tests
>
>
On Thu, 23 Nov 2023 02:07:59 GMT, David Holmes wrote:
>> In the rewrites made for:
>> [JDK-8318757](https://bugs.openjdk.org/browse/JDK-8318757) `VM_ThreadDump
>> asserts in interleaved ObjectMonitor::deflate_monitor calls`
>>
>> I removed the filtering of *owned ObjectMonitors with dead
On Thu, 23 Nov 2023 00:48:19 GMT, David Holmes wrote:
>> In the rewrites made for:
>> [JDK-8318757](https://bugs.openjdk.org/browse/JDK-8318757) `VM_ThreadDump
>> asserts in interleaved ObjectMonitor::deflate_monitor calls`
>>
>> I removed the filtering of *owned ObjectMonitors with dead
On Thu, 23 Nov 2023 01:38:57 GMT, David Holmes wrote:
>> In the rewrites made for:
>> [JDK-8318757](https://bugs.openjdk.org/browse/JDK-8318757) `VM_ThreadDump
>> asserts in interleaved ObjectMonitor::deflate_monitor calls`
>>
>> I removed the filtering of *owned ObjectMonitors with dead
On Thu, 23 Nov 2023 01:29:24 GMT, David Holmes wrote:
>> In the rewrites made for:
>> [JDK-8318757](https://bugs.openjdk.org/browse/JDK-8318757) `VM_ThreadDump
>> asserts in interleaved ObjectMonitor::deflate_monitor calls`
>>
>> I removed the filtering of *owned ObjectMonitors with dead
On Thu, 23 Nov 2023 01:28:32 GMT, David Holmes wrote:
>> In the rewrites made for:
>> [JDK-8318757](https://bugs.openjdk.org/browse/JDK-8318757) `VM_ThreadDump
>> asserts in interleaved ObjectMonitor::deflate_monitor calls`
>>
>> I removed the filtering of *owned ObjectMonitors with dead
On Thu, 23 Nov 2023 01:27:24 GMT, David Holmes wrote:
>> In the rewrites made for:
>> [JDK-8318757](https://bugs.openjdk.org/browse/JDK-8318757) `VM_ThreadDump
>> asserts in interleaved ObjectMonitor::deflate_monitor calls`
>>
>> I removed the filtering of *owned ObjectMonitors with dead
In the rewrites made for:
[JDK-8318757](https://bugs.openjdk.org/browse/JDK-8318757) `VM_ThreadDump
asserts in interleaved ObjectMonitor::deflate_monitor calls`
I removed the filtering of *owned ObjectMonitors with dead objects*. The
reasoning was that you should never have an owned
On Fri, 2 Jun 2023 02:49:25 GMT, Kelvin Nilsen wrote:
>> OpenJDK Colleagues:
>>
>> Please review this proposed integration of Generational mode for Shenandoah
>> GC under https://bugs.openjdk.org/browse/JDK-8307314.
>>
>> Generational mode of Shenandoah is enabled by adding
>>
On Fri, 26 May 2023 20:46:29 GMT, Kelvin Nilsen wrote:
> OpenJDK Colleagues:
>
> Please review this proposed integration of Generational mode for Shenandoah
> GC under https://bugs.openjdk.org/browse/JDK-8307314.
>
> Generational mode of Shenandoah is enabled by adding
>
On Thu, 11 May 2023 12:12:56 GMT, Stefan Karlsson wrote:
>> Hi all,
>>
>> Please review the implementation of Generational ZGC, which can be turned on
>> by adding -XX:+ZGenerational in addition to using -XX:+UseZGC. Generational
>> ZGC is a major rewrite of th
On Wed, 3 May 2023 09:04:50 GMT, Stefan Karlsson wrote:
> Hi all,
>
> Please review the implementation of Generational ZGC, which can be turned on
> by adding -XX:+ZGenerational in addition to using -XX:+UseZGC. Generational
> ZGC is a major rewrite of the non-generatio
to
> mash the two implementations together and sprinkle the GC code with
> conditional statements or dynamic dispatches. We have done similar
> experiments before. When ZGC was first born, we started an experiment where
> we converted G1 into getting the same features as the evolving ZG
to
> mash the two implementations together and sprinkle the GC code with
> conditional statements or dynamic dispatches. We have done similar
> experiments before. When ZGC was first born, we started an experiment where
> we converted G1 into getting the same features as the evolving ZG
On Tue, 9 May 2023 12:55:42 GMT, Stefan Karlsson wrote:
>> Hi all,
>>
>> Please review the implementation of Generational ZGC, which can be turned on
>> by adding -XX:+ZGenerational in addition to using -XX:+UseZGC. Generational
>> ZGC is a major rewrite of th
There have been many contributors of this patch over the years. I'll do my
> best to poke Skara into listing you all, but if you see that I've missed your
> name please reach out to me and I'll fix it.
>
> Testing: we have been continuously running Generational ZGC through Ora
There have been many contributors of this patch over the years. I'll do my
> best to poke Skara into listing you all, but if you see that I've missed your
> name please reach out to me and I'll fix it.
>
> Testing: we have been continuously running Generational ZGC through Oracle's
&g
On Tue, 9 May 2023 00:50:56 GMT, Fei Yang wrote:
>> That's unfortunate. Could you try this patch, which probes the address range
>> to see if it can reserve the memory somewhere else within
>> `[ZAddressHeapBase, ZAddressHeapBase+ZAddressOffsetMax)`:
>>
There have been many contributors of this patch over the years. I'll do my
> best to poke Skara into listing you all, but if you see that I've missed your
> name please reach out to me and I'll fix it.
>
> Testing: we have been continuously running Generational ZGC through Oracle's
&
There have been many contributors of this patch over the years. I'll do my
> best to poke Skara into listing you all, but if you see that I've missed your
> name please reach out to me and I'll fix it.
>
> Testing: we have been continuously running Generational ZGC through Oracle's
&g
There have been many contributors of this patch over the years. I'll do my
> best to poke Skara into listing you all, but if you see that I've missed your
> name please reach out to me and I'll fix it.
>
> Testing: we have been continuously running Generational ZGC through Oracle's
&g
On Mon, 8 May 2023 10:19:44 GMT, Fei Yang wrote:
>> Could you provide the values for `reserved`, `ZAddressHeapBase`, and
>> `ZAddressOffsetMax`, when this test is failing. I'd like to know if we can
>> make a workaround for you, or if we have to turn off the test for riscv.
>
> @stefank : I
There have been many contributors of this patch over the years. I'll do my
> best to poke Skara into listing you all, but if you see that I've missed your
> name please reach out to me and I'll fix it.
>
> Testing: we have been continuously running Generational ZGC through Oracle's
&g
On Fri, 5 May 2023 06:28:59 GMT, Yadong Wang wrote:
>> Thanks for reporting. It would be interesting to see what address you get
>> and compare it to the range [ZAddressHeapBase,
>> ZAddressHeapBase+ZAddressOffsetMax).
>
> We emailed to erik to discuss this issue two months ago, and maybe he
On Fri, 5 May 2023 01:54:48 GMT, Fei Yang wrote:
>> Stefan Karlsson has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> undefine glibc major/minor macros
>
> test/hotspot/gtest/gc/z/test_zForwarding.cpp line
On Thu, 4 May 2023 20:21:12 GMT, Andrey Turbanov wrote:
>> Stefan Karlsson has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> undefine glibc major/minor macros
>
> test/hotspot/jtreg/runtime/stringtable/Str
There have been many contributors of this patch over the years. I'll do my
> best to poke Skara into listing you all, but if you see that I've missed your
> name please reach out to me and I'll fix it.
>
> Testing: we have been continuously running Generational ZGC throug
There have been many contributors of this patch over the years. I'll do my
> best to poke Skara into listing you all, but if you see that I've missed your
> name please reach out to me and I'll fix it.
>
> Testing: we have been continuously running Generational ZGC through Oracle's
On Wed, 3 May 2023 21:08:39 GMT, Stefan Karlsson wrote:
>> test/jdk/ProblemList-generational-zgc.txt line 27:
>>
>>> 25: #
>>> 26: # List of quarantined tests for testing with Generational ZGC.
>>> 27: #
>>
>> Are the tests in `test/j
On Wed, 3 May 2023 21:32:54 GMT, Martin Doerr wrote:
> I'm getting build warnings on all linux platforms with gcc-11.3.0:
>
> ```
> src/hotspot/share/gc/z/zDriver.cpp:84:13: error: In the GNU C Library,
> "minor" is defined
> by . For historical compatibility, it is
> currently defined by
There have been many contributors of this patch over the years. I'll do my
> best to poke Skara into listing you all, but if you see that I've missed your
> name please reach out to me and I'll fix it.
>
> Testing: we have been continuously running Generational ZGC through Oracle'
There have been many contributors of this patch over the years. I'll do my
> best to poke Skara into listing you all, but if you see that I've missed your
> name please reach out to me and I'll fix it.
>
> Testing: we have been continuously running Generational ZGC through Oracle
On Wed, 3 May 2023 20:00:42 GMT, Chris Plummer wrote:
>> Yes, the test was finicky with the heap size. Given that the leak it tries
>> to provoke would be provoked by other GCs as well, we didn't think it was
>> that important to run this particular test with Generational ZGC. If you
>> still
On Wed, 3 May 2023 18:54:24 GMT, Chris Plummer wrote:
>> Stefan Karlsson has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> Fix PPC build after 8305668
>
> test/jdk/ProblemList-generational-zgc.txt line
On Wed, 3 May 2023 18:57:22 GMT, Chris Plummer wrote:
>> Stefan Karlsson has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> Fix PPC build after 8305668
>
> test/jdk/com/sun/jdi/ThreadMemoryLeakTest.ja
There have been many contributors of this patch over the years. I'll do my
> best to poke Skara into listing you all, but if you see that I've missed your
> name please reach out to me and I'll fix it.
>
> Testing: we have been continuously running Generational ZGC through Oracle's
>
On Wed, 3 May 2023 18:52:19 GMT, Chris Plummer wrote:
>> Stefan Karlsson has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> Fix PPC build after 8305668
>
> test/hotspot/jtreg/ProblemList-generational-zgc.txt
On Wed, 3 May 2023 12:29:15 GMT, Martin Doerr wrote:
> Thanks for fixing PPC64! With this, the VM compiles and the
> `test/hotspot/jtreg/gc` tests are passing on linux PPC64le.
>
> I'm glad to see this PR for JDK 21 LTS. It's a big step forward for ZGC.
> Congratulations!
Thanks for porting
There have been many contributors of this patch over the years. I'll do my
> best to poke Skara into listing you all, but if you see that I've missed your
> name please reach out to me and I'll fix it.
>
> Testing: we have been continuously running Generational ZGC through Oracle's
&
Hi all,
Please review the implementation of Generational ZGC, which can be turned on by
adding -XX:+ZGenerational in addition to using -XX:+UseZGC. Generational ZGC is
a major rewrite of the non-generational ZGC version that exists in the
openjdk/jdk repository. It splits the heap into two
On Fri, 11 Nov 2022 14:26:20 GMT, Stefan Karlsson wrote:
> The sorted blocks of includes have deteriorated to the point that I felt
> compelled to clean up some of the issues.
>
> *EDIT*: The below discussion has been deferred out of this PR. Now this only
> deals with fixin
On Wed, 16 Nov 2022 16:17:48 GMT, Stefan Karlsson wrote:
>> The sorted blocks of includes have deteriorated to the point that I felt
>> compelled to clean up some of the issues.
>>
>> *EDIT*: The below discussion has been deferred out of this PR. Now this on
r the include headers I've also cleaned up surrounding
> whitespaces and incorrect include guards.
Stefan Karlsson has updated the pull request with a new target base due to a
merge or a rebase. The pull request now contains four commits:
- Merge remote-tracking branch 'upstream/master' into
On Mon, 14 Nov 2022 11:39:10 GMT, Kim Barrett wrote:
>> src/hotspot/os/windows/jvm_windows.cpp line 27:
>>
>>> 25: #include "precompiled.hpp"
>>> 26: #include "include/jvm.h"
>>> 27: #include "os_windows.hpp"
>>
>> os_windows should be at the end, included using `OS_HEADER("os")`.
>
> But
On Wed, 16 Nov 2022 16:17:48 GMT, Stefan Karlsson wrote:
>> The sorted blocks of includes have deteriorated to the point that I felt
>> compelled to clean up some of the issues.
>>
>> One of the more prevalent issues is that files in src/hotspot/share/include
&g
On Fri, 11 Nov 2022 21:01:31 GMT, Kim Barrett wrote:
>> Stefan Karlsson has updated the pull request with a new target base due to a
>> merge or a rebase. The pull request now contains three commits:
>>
>> - Cleanups
>> - Merge remote-tr
; src/hotspot/share,
just like the other platform-independent headers in HotSpot.
>
> While going over the include headers I've also cleaned up surrounding
> whitespaces and incorrect include guards.
Stefan Karlsson has updated the pull request with a new target base due to a
me
On Mon, 14 Nov 2022 09:25:11 GMT, Stefan Karlsson wrote:
> One of the more prevalent issues is that files in src/hotspot/share/include
> are not properly sorted. There has been some discussion that that was done on
> purpose, but it just adds another exception to the include rules t
On Wed, 16 Nov 2022 11:05:59 GMT, Stefan Karlsson wrote:
>> One of the more prevalent issues is that files in src/hotspot/share/include
>> are not properly sorted. There has been some discussion that that was done
>> on purpose, but it just adds another exception to
> the header files in src/hotspot/share/include gets included by specifying the
> path from src/hotspot/share, just like the other platform-independent headers
> in HotSpot
.
>
> This RFE splits out the 'include/' changes from #11108 / JDK-8296886, so that
> those changes can be
> the header files in src/hotspot/share/include gets included by specifying the
> path from src/hotspot/share, just like the other platform-independent headers
> in HotSpot
.
>
> This RFE splits out the 'include/' changes from #11108 / JDK-8296886, so that
> those changes can be
On Mon, 14 Nov 2022 09:25:11 GMT, Stefan Karlsson wrote:
> One of the more prevalent issues is that files in src/hotspot/share/include
> are not properly sorted. There has been some discussion that that was done on
> purpose, but it just adds another exception to the include rules t
One of the more prevalent issues is that files in src/hotspot/share/include are
not properly sorted. There has been some discussion that that was done on
purpose, but it just adds another exception to the include rules that don't
have any practical purposes, IMHO. It also goes against our
On Fri, 11 Nov 2022 14:26:20 GMT, Stefan Karlsson wrote:
> The sorted blocks of includes have deteriorated to the point that I felt
> compelled to clean up some of the issues.
>
> One of the more prevalent issues is that files in src/hotspot/share/include
> are not properly so
On Fri, 11 Nov 2022 14:26:20 GMT, Stefan Karlsson wrote:
> The sorted blocks of includes have deteriorated to the point that I felt
> compelled to clean up some of the issues.
>
> One of the more prevalent issues is that files in src/hotspot/share/include
> are not properly so
The sorted blocks of includes have deteriorated to the point that I felt
compelled to clean up some of the issues.
One of the more prevalent issues is that files in src/hotspot/share/include are
not properly sorted. There has been some discussion that that was done on
purpose, but it just adds
60 matches
Mail list logo
