On Thu, 25 Apr 2024 23:24:07 GMT, Jonathan Gibbons wrote:
>> Please review the updates to support a proposed new
>> `-Xlint:dangling-doc-comments` option.
>>
>> The work can be thought of as in 3 parts:
>>
>> 1. An update to the `javac` internal class `DeferredLintHandler` so that it
>> is po
On Tue, 16 Apr 2024 19:15:14 GMT, Archie Cobbs wrote:
>> Please review several fixes and improvements to the `this-escape` lint
>> warning analyzer.
>>
>> The goal here is to apply some relatively simple logical fixes that improve
>> the precision and accuracy of the analyzer, and capture the
On Mon, 15 Apr 2024 19:01:08 GMT, Joe Darcy wrote:
> Get JDK 24 underway.
lgtm
-
Marked as reviewed by vromero (Reviewer).
PR Review: https://git.openjdk.org/jdk/pull/18787#pullrequestreview-2004323374
On Tue, 9 Apr 2024 15:36:27 GMT, Archie Cobbs wrote:
>> Please review several fixes and improvements to the `this-escape` lint
>> warning analyzer.
>>
>> The goal here is to apply some relatively simple logical fixes that improve
>> the precision and accuracy of the analyzer, and capture the r
On Wed, 27 Mar 2024 22:04:30 GMT, Jonathan Gibbons wrote:
> Please review the updates to support a proposed new
> `-Xlint:dangling-doc-comments` option.
>
> The work can be thought of as in 3 parts:
>
> 1. An update to the `javac` internal class `DeferredLintHandler` so that it
> is possible
On Wed, 20 Mar 2024 18:55:38 GMT, Jan Lahoda wrote:
>> This is a patch that:
>> a) upgrades the JLine inside the JDK to 3.25.1
>> b) since the new version of JLine has a FFM backend, our custom native
>> backends are removed, and replaced with the FFM backend
>>
>> Some changes had to be made t
On Tue, 6 Feb 2024 02:28:32 GMT, Joe Darcy wrote:
> Add policy statement about lint warnings to various langtools modules.
lgtm
-
Marked as reviewed by vromero (Reviewer).
PR Review: https://git.openjdk.org/jdk/pull/17718#pullrequestreview-1868464016
On Sun, 3 Dec 2023 21:31:42 GMT, Jan Lahoda wrote:
> As part of:
> https://github.com/openjdk/jdk/pull/16505
>
> there are new symbol files for JDK 22, and @jddarcy noted the content looks
> weird.
>
> I was investigating, and found a few problems, some introduced by
> https://github.com/open
On Thu, 30 Nov 2023 23:49:24 GMT, Joe Darcy wrote:
>> Time to start making preparations for JDK 23.
>
> Joe Darcy has updated the pull request incrementally with one additional
> commit since the last revision:
>
> Update symbol files to JDK 22 b26.
looks good to me
-
Marked as
On Thu, 9 Nov 2023 14:09:39 GMT, Jan Lahoda wrote:
>> Consider a simple module, like:
>>
>> module test {}
>>
>>
>> And compile it with JDK 22 and JDK 21 using:
>> javac --release 21
>>
>> The results of the compilations will differ: when compiling with JDK 21, the
>> mandated java.base depe
On Wed, 4 Oct 2023 09:30:16 GMT, Adam Sotona wrote:
>> Classfile API is an internal library under package `jdk.internal.classfile`
>> in JDK 21.
>> This pull request turns the Classfile API into a preview feature and moves
>> it into `java.lang.classfile`.
>> It repackages all uses across JDK a
On Mon, 2 Oct 2023 07:18:19 GMT, Adam Sotona wrote:
>> src/java.base/share/classes/java/lang/classfile/AnnotationElement.java line
>> 34:
>>
>>> 32: import jdk.internal.javac.PreviewFeature;
>>> 33:
>>> 34: /**
>>
>> shouldn't we have the preview header applied to all these compilation units?
On Tue, 26 Sep 2023 12:32:37 GMT, Adam Sotona wrote:
>> Classfile API is an internal library under package `jdk.internal.classfile`
>> in JDK 21.
>> This pull request turns the Classfile API into a preview feature and moves
>> it into `java.lang.classfile`.
>> It repackages all uses across JDK
On Tue, 26 Sep 2023 12:32:37 GMT, Adam Sotona wrote:
>> Classfile API is an internal library under package `jdk.internal.classfile`
>> in JDK 21.
>> This pull request turns the Classfile API into a preview feature and moves
>> it into `java.lang.classfile`.
>> It repackages all uses across JDK
On Fri, 29 Sep 2023 08:30:07 GMT, Maurizio Cimadamore
wrote:
>> This patch adds a new lint warning category, namely `-Xlint:restricted` to
>> enable warnings on restricted method calls.
>>
>> The patch is relatively straightforward: javac marks methods that are marked
>> with the `@Restricted
On Fri, 29 Sep 2023 08:14:29 GMT, Maurizio Cimadamore
wrote:
> > question shouldn't the new Restricted annotation be annotated with the
> > @PreviewFeature annotation? it depends on a preview feature
>
> The Restricted annotation is an internal annotation only. So there is no
> value in annot
On Thu, 28 Sep 2023 15:36:30 GMT, Maurizio Cimadamore
wrote:
>> This patch adds a new lint warning category, namely `-Xlint:restricted` to
>> enable warnings on restricted method calls.
>>
>> The patch is relatively straightforward: javac marks methods that are marked
>> with the `@Restricted
On Thu, 28 Sep 2023 15:36:30 GMT, Maurizio Cimadamore
wrote:
>> This patch adds a new lint warning category, namely `-Xlint:restricted` to
>> enable warnings on restricted method calls.
>>
>> The patch is relatively straightforward: javac marks methods that are marked
>> with the `@Restricted
On Thu, 11 May 2023 14:17:56 GMT, Jan Lahoda wrote:
>> To support JShell and other usecases, the JDK uses JLine, which provides
>> line-editing functionality inside a terminal.
>>
>> JLine has several ways to work with the terminal, based on various
>> additional libraries and tools. Most of t
On Thu, 11 May 2023 14:17:56 GMT, Jan Lahoda wrote:
>> To support JShell and other usecases, the JDK uses JLine, which provides
>> line-editing functionality inside a terminal.
>>
>> JLine has several ways to work with the terminal, based on various
>> additional libraries and tools. Most of t
On Fri, 5 May 2023 19:17:53 GMT, Jim Laskey wrote:
>> Add flexible main methods and anonymous main classes to the Java language.
>
> Jim Laskey has updated the pull request incrementally with one additional
> commit since the last revision:
>
> Refactor source code launcher
looks good
-
On Fri, 5 May 2023 17:31:27 GMT, Jim Laskey wrote:
>> Add flexible main methods and anonymous main classes to the Java language.
>
> Jim Laskey has updated the pull request incrementally with one additional
> commit since the last revision:
>
> Typo
src/jdk.compiler/share/classes/com/sun/too
On Fri, 5 May 2023 17:22:03 GMT, Rémi Forax wrote:
>> src/jdk.compiler/share/classes/com/sun/tools/javac/parser/JavacParser.java
>> line 3999:
>>
>>> 3997: Name name = names.fromString(simplename);
>>> 3998: JCModifiers anonMods = F.at(primaryPos)
>>> 3999:
>>>
On Fri, 5 May 2023 16:18:42 GMT, Jim Laskey wrote:
>> Add flexible main methods and anonymous main classes to the Java language.
>
> Jim Laskey has updated the pull request incrementally with one additional
> commit since the last revision:
>
> Recommended changes #2
src/java.base/share/clas
On Mon, 20 Mar 2023 16:19:19 GMT, Jan Lahoda wrote:
>> `this-escape` lint is disabled for jdk.compiler, so it should be disabled
>> for the ant-based langtools-only build as well.
>
> Jan Lahoda has updated the pull request with a new target base due to a merge
> or a rebase. The incremental we
On Mon, 20 Mar 2023 14:50:01 GMT, Jan Lahoda wrote:
> `this-escape` lint is disabled for jdk.compiler, so it should be disabled for
> the ant-based langtools-only build as well.
looks good
-
Marked as reviewed by vromero (Reviewer).
PR: https://git.openjdk.org/jdk/pull/13102
On Wed, 1 Mar 2023 18:56:49 GMT, Jan Lahoda wrote:
>> The OpenJDK build is using a Plugin called Depend to avoid building Java
>> code unnecessarily. It has two parts, one is checking module APIs (and
>> forces rebuild of dependent modules if a dependency changes), and second
>> takes modified
On Wed, 1 Mar 2023 10:12:41 GMT, Jan Lahoda wrote:
> The OpenJDK build is using a Plugin called Depend to avoid building Java code
> unnecessarily. It has two parts, one is checking module APIs (and forces
> rebuild of dependent modules if a dependency changes), and second takes
> modified fil
On Mon, 23 Jan 2023 19:34:42 GMT, Archie L. Cobbs wrote:
> [The CSR](https://bugs.openjdk.org/browse/JDK-825) also needs a review
> from a compiler-dev engineer as well if anyone is interested... thanks.
some comments on the CSR:
- I think the value for field `Compatibility Risk` could be
On Wed, 18 Jan 2023 22:27:08 GMT, Archie L. Cobbs wrote:
>> This PR adds a new lint warning category `this-escape`.
>>
>> It also adds `@SuppressWarnings` annotations as needed to the JDK itself to
>> allow the JDK to continue to compile with `-Xlint:all`.
>>
>> A 'this' escape warning is gene
On Mon, 16 Jan 2023 23:22:00 GMT, Archie L. Cobbs wrote:
>> This PR adds a new lint warning category `this-escape`.
>>
>> It also adds `@SuppressWarnings` annotations as needed to the JDK itself to
>> allow the JDK to continue to compile with `-Xlint:all`.
>>
>> A 'this' escape warning is gene
On Fri, 13 Jan 2023 21:33:02 GMT, Archie L. Cobbs wrote:
>> Sounds good - thanks.
>
> Ah. I just realized that we need to do it your way because of the following
> bug:
>
> Suppose you have a constructor and a field with initializer that both leak,
> but you have `@SuppressWarnings("this-escap
On Fri, 13 Jan 2023 19:09:54 GMT, Archie L. Cobbs wrote:
>> This PR adds a new lint warning category `this-escape`.
>>
>> It also adds `@SuppressWarnings` annotations as needed to the JDK itself to
>> allow the JDK to continue to compile with `-Xlint:all`.
>>
>> A 'this' escape warning is gene
On Fri, 13 Jan 2023 19:09:54 GMT, Archie L. Cobbs wrote:
>> This PR adds a new lint warning category `this-escape`.
>>
>> It also adds `@SuppressWarnings` annotations as needed to the JDK itself to
>> allow the JDK to continue to compile with `-Xlint:all`.
>>
>> A 'this' escape warning is gene
On Fri, 13 Jan 2023 17:49:05 GMT, Archie L. Cobbs wrote:
>> src/jdk.compiler/share/classes/com/sun/tools/javac/comp/ThisEscapeAnalyzer.java
>> line 685:
>>
>>> 683:
>>> 684: @Override
>>> 685: public void visitDoLoop(JCDoWhileLoop tree) {
>>
>> I was thinking, code can also loop using
On Fri, 13 Jan 2023 04:04:36 GMT, Archie L. Cobbs wrote:
>> This PR adds a new lint warning category `this-escape`.
>>
>> It also adds `@SuppressWarnings` annotations as needed to the JDK itself to
>> allow the JDK to continue to compile with `-Xlint:all`.
>>
>> A 'this' escape warning is gene
On Fri, 13 Jan 2023 15:14:05 GMT, Archie L. Cobbs wrote:
>> src/jdk.compiler/share/classes/com/sun/tools/javac/comp/ThisEscapeAnalyzer.java
>> line 516:
>>
>>> 514: Name name = TreeInfo.name(invoke.meth);
>>> 515: if (name == names._super) {
>>> 516: scanInitializers
On Fri, 13 Jan 2023 04:04:36 GMT, Archie L. Cobbs wrote:
>> This PR adds a new lint warning category `this-escape`.
>>
>> It also adds `@SuppressWarnings` annotations as needed to the JDK itself to
>> allow the JDK to continue to compile with `-Xlint:all`.
>>
>> A 'this' escape warning is gene
On Fri, 13 Jan 2023 04:04:36 GMT, Archie L. Cobbs wrote:
>> This PR adds a new lint warning category `this-escape`.
>>
>> It also adds `@SuppressWarnings` annotations as needed to the JDK itself to
>> allow the JDK to continue to compile with `-Xlint:all`.
>>
>> A 'this' escape warning is gene
On Wed, 11 Jan 2023 03:30:03 GMT, Archie L. Cobbs wrote:
>> This PR adds a new lint warning category `this-escape`.
>>
>> It also adds `@SuppressWarnings` annotations as needed to the JDK itself to
>> allow the JDK to continue to compile with `-Xlint:all`.
>>
>> A 'this' escape warning is gene
On Tue, 1 Nov 2022 05:49:25 GMT, Joe Darcy wrote:
> Usual start-of-release updates. Symbol updates in initial version reflect JDK
> 20 build 21.
looks good
-
Marked as reviewed by vromero (Reviewer).
PR: https://git.openjdk.org/jdk/pull/10924
On Fri, 4 Nov 2022 21:50:10 GMT, Jonathan Gibbons wrote:
> Please review some minor updates to the `diags/examples` mechanism, repairing
> some bitrot after one of the not-so-recent repo reorgs.
>
> For bonus, I've added a target for the German version of the output.
lgtm
-
Marke
On Thu, 1 Sep 2022 18:35:24 GMT, Jan Lahoda wrote:
>> Currently, when doing a small change inside a module that does not affect
>> the API of the module, the build system will skip rebuild of the dependent
>> modules. If there's a change that affects the module's API, the dependent
>> modules
On Sat, 13 Aug 2022 19:49:31 GMT, Hannes Greule wrote:
>> With this change, javac emits the MethodParameters attribute in cases where
>> the JLS requires the information about synthetic and mandated parameters to
>> be stored (see issue).
>> Parameter names are *not* emitted unless the `-parame
44 matches
Mail list logo
