Re: RFR: 8264425: Update building.md on non-English locales on Windows [v2]

2023-11-20 Thread Magnus Ihse Bursie
On Fri, 17 Nov 2023 13:06:53 GMT, Magnus Ihse Bursie wrote: >> Update the build documentation to reflect the fact that non-English locales >> are only supported on a "best effort" principle, and add instructions how to >> install the necessary language pack to Visual Studio. > > Magnus Ihse

Re: RFR: 8264425: Update building.md on non-English locales on Windows [v2]

2023-11-17 Thread Naoto Sato
On Fri, 17 Nov 2023 13:01:38 GMT, Magnus Ihse Bursie wrote: >> doc/building.html line 404: >> >>> 402: locale for a specific process like this in Windows. The only way is to >>> 403: change the user locale setting to US English, which >>> 404: will affect all applications run by the user. >>

Re: RFR: 8264425: Update building.md on non-English locales on Windows [v2]

2023-11-17 Thread Magnus Ihse Bursie
> Update the build documentation to reflect the fact that non-English locales > are only supported on a "best effort" principle, and add instructions how to > install the necessary language pack to Visual Studio. Magnus Ihse Bursie has updated the pull request with a new target base due to a

Re: RFR: 8264425: Update building.md on non-English locales on Windows [v2]

2023-11-17 Thread Magnus Ihse Bursie
On Thu, 16 Nov 2023 17:25:58 GMT, Naoto Sato wrote: >> Magnus Ihse Bursie has updated the pull request with a new target base due >> to a merge or a rebase. The incremental webrev excludes the unrelated >> changes brought in by the merge/rebase. The pull request contains three >> additional