Re: RFR: 8289735: UTIL_LOOKUP_PROGS fails on pathes with space [v2]

2023-04-25 Thread Christoph Langer
On Mon, 24 Apr 2023 21:44:00 GMT, Christoph Langer wrote: >> This is an attempt to fix the issue on Windows when no cygwin Git is >> installed or the Git for Windows installation has precedence in PATH lookup. >> The path to the Windows GIT installation usually resides in `C:\Program >>

Re: RFR: 8289735: UTIL_LOOKUP_PROGS fails on pathes with space [v2]

2023-04-25 Thread Matthias Baesken
On Mon, 24 Apr 2023 21:44:00 GMT, Christoph Langer wrote: >> This is an attempt to fix the issue on Windows when no cygwin Git is >> installed or the Git for Windows installation has precedence in PATH lookup. >> The path to the Windows GIT installation usually resides in `C:\Program >>

Re: RFR: 8289735: UTIL_LOOKUP_PROGS fails on pathes with space [v2]

2023-04-24 Thread Erik Joelsson
On Mon, 24 Apr 2023 21:44:00 GMT, Christoph Langer wrote: >> This is an attempt to fix the issue on Windows when no cygwin Git is >> installed or the Git for Windows installation has precedence in PATH lookup. >> The path to the Windows GIT installation usually resides in `C:\Program >>

Re: RFR: 8289735: UTIL_LOOKUP_PROGS fails on pathes with space [v2]

2023-04-24 Thread Christoph Langer
> This is an attempt to fix the issue on Windows when no cygwin Git is > installed or the Git for Windows installation has precedence in PATH lookup. > The path to the Windows GIT installation usually resides in `C:\Program > Files` which contains a space and thus needs some special handling. >

Re: RFR: 8289735: UTIL_LOOKUP_PROGS fails on pathes with space

2023-04-24 Thread Christoph Langer
On Mon, 24 Apr 2023 21:04:50 GMT, Erik Joelsson wrote: > I think this change makes sense. Given how small this set of tools is now, I > think we should add a comment on `PLATFORM_SETUP_OPENJDK_BUILD_AND_TARGET` in > platform.m4 saying something about needing to be careful to only use tools >

Re: RFR: 8289735: UTIL_LOOKUP_PROGS fails on pathes with space

2023-04-24 Thread Erik Joelsson
On Mon, 24 Apr 2023 20:11:50 GMT, Christoph Langer wrote: > This is an attempt to fix the issue on Windows when no cygwin Git is > installed or the Git for Windows installation has precedence in PATH lookup. > The path to the Windows GIT installation usually resides in `C:\Program > Files`

RFR: 8289735: UTIL_LOOKUP_PROGS fails on pathes with space

2023-04-24 Thread Christoph Langer
This is an attempt to fix the issue on Windows when no cygwin Git is installed or the Git for Windows installation has precedence in PATH lookup. The path to the Windows GIT installation usually resides in `C:\Program Files` which contains a space and thus needs some special handling. There