On Wed, 27 Jul 2022 12:22:41 GMT, Weijun Wang wrote:
>> The DLL should be built no matter what `BUILD_CRYPTO` is.
>
> Weijun Wang has updated the pull request incrementally with one additional
> commit since the last revision:
>
> indentation change
LGTM.
-
Marked as reviewed b
On Wed, 27 Jul 2022 12:22:41 GMT, Weijun Wang wrote:
>> The DLL should be built no matter what `BUILD_CRYPTO` is.
>
> Weijun Wang has updated the pull request incrementally with one additional
> commit since the last revision:
>
> indentation change
Marked as reviewed by ihse (Reviewer).
--
On Wed, 27 Jul 2022 12:06:51 GMT, Weijun Wang wrote:
>> The DLL should be built no matter what `BUILD_CRYPTO` is.
>
> Weijun Wang has updated the pull request incrementally with one additional
> commit since the last revision:
>
> indentation change
Looks good.
Minor style nit. We like to h
> The DLL should be built no matter what `BUILD_CRYPTO` is.
Weijun Wang has updated the pull request incrementally with one additional
commit since the last revision:
indentation change
-
Changes:
- all: https://git.openjdk.org/jdk/pull/9647/files
- new: https://git.openjdk.o
On Tue, 26 Jul 2022 18:12:33 GMT, Weijun Wang wrote:
> The DLL should be built no matter what `BUILD_CRYPTO` is.
Looks good to me.
-
Marked as reviewed by valeriep (Reviewer).
PR: https://git.openjdk.org/jdk/pull/9647
On Tue, 26 Jul 2022 18:12:33 GMT, Weijun Wang wrote:
> The DLL should be built no matter what `BUILD_CRYPTO` is.
Your fix looks good to me. I'm assuming sspi_bridge.dll is useful regardless of
the value of BUILD_CRYPTO.
-
PR: https://git.openjdk.org/jdk/pull/9647
The DLL should be built no matter what `BUILD_CRYPTO` is.
-
Commit messages:
- the fix
Changes: https://git.openjdk.org/jdk/pull/9647/files
Webrev: https://webrevs.openjdk.org/?repo=jdk&pr=9647&range=00
Issue: https://bugs.openjdk.org/browse/JDK-8290920
Stats: 25 lines in 1 fil
