Re: RFR: 8293116: Incremental JDK build could be sped up [v5]

2022-09-13 Thread Magnus Ihse Bursie
On Mon, 12 Sep 2022 20:35:27 GMT, Jan Lahoda wrote: >> Jan Lahoda has updated the pull request incrementally with one additional >> commit since the last revision: >> >> Regenerating modfiles as necessary. > > I ran some tests (in a semi-automated fashion), results seem reasonable: > > ##

Re: RFR: 8293116: Incremental JDK build could be sped up [v5]

2022-09-12 Thread Erik Joelsson
On Fri, 9 Sep 2022 11:41:08 GMT, Jan Lahoda wrote: >> Currently, when doing a small change inside a module that does not affect >> the API of the module, the build system will skip rebuild of the dependent >> modules. If there's a change that affects the module's API, the dependent >> modules

Re: RFR: 8293116: Incremental JDK build could be sped up [v5]

2022-09-12 Thread Jan Lahoda
On Fri, 9 Sep 2022 11:41:08 GMT, Jan Lahoda wrote: >> Currently, when doing a small change inside a module that does not affect >> the API of the module, the build system will skip rebuild of the dependent >> modules. If there's a change that affects the module's API, the dependent >> modules

Re: RFR: 8293116: Incremental JDK build could be sped up [v5]

2022-09-09 Thread Erik Joelsson
On Fri, 9 Sep 2022 11:51:55 GMT, Magnus Ihse Bursie wrote: > I think this looks good now. But this is apparently tricky business, with the > three of us taking turns of thinking wrongly about this. :-) Let's hear what > Erik has to say, too. > > Have you verified that it still does the

Re: RFR: 8293116: Incremental JDK build could be sped up [v5]

2022-09-09 Thread Erik Joelsson
On Fri, 9 Sep 2022 11:41:08 GMT, Jan Lahoda wrote: >> Currently, when doing a small change inside a module that does not affect >> the API of the module, the build system will skip rebuild of the dependent >> modules. If there's a change that affects the module's API, the dependent >> modules

Re: RFR: 8293116: Incremental JDK build could be sped up [v5]

2022-09-09 Thread Magnus Ihse Bursie
On Fri, 9 Sep 2022 11:41:08 GMT, Jan Lahoda wrote: >> Currently, when doing a small change inside a module that does not affect >> the API of the module, the build system will skip rebuild of the dependent >> modules. If there's a change that affects the module's API, the dependent >> modules

Re: RFR: 8293116: Incremental JDK build could be sped up [v5]

2022-09-09 Thread Jan Lahoda
> Currently, when doing a small change inside a module that does not affect the > API of the module, the build system will skip rebuild of the dependent > modules. If there's a change that affects the module's API, the dependent > modules are recompiled. So far, this seems to work reasonably. >