On Sat, 15 Oct 2022 08:11:39 GMT, Kim Barrett wrote:
> Looks good.
I think you want to do the actual "Approve" to supersede your previous "Request
changes" review.
Anyway, I think we are good for integration here, @magicus?
-
PR: https://git.openjdk.org/jdk/pull/10414
On Wed, 12 Oct 2022 13:42:39 GMT, Magnus Ihse Bursie wrote:
>> make/hotspot/lib/CompileJvm.gmk line 92:
>>
>>> 90:
>>> 91: DISABLED_WARNINGS_clang := ignored-qualifiers sometimes-uninitialized \
>>> 92: missing-braces delete-non-abstract-non-virtual-dtor unknown-pragmas
>>
>> Shouldn't shi
On Wed, 12 Oct 2022 11:04:14 GMT, Magnus Ihse Bursie wrote:
>> After [JDK-8294281](https://bugs.openjdk.org/browse/JDK-8294281), it is now
>> possible to disable warnings for individual files instead for whole
>> libraries. I used this opportunity to go through all disabled warnings in
>> hots
On Wed, 12 Oct 2022 11:04:14 GMT, Magnus Ihse Bursie wrote:
>> After [JDK-8294281](https://bugs.openjdk.org/browse/JDK-8294281), it is now
>> possible to disable warnings for individual files instead for whole
>> libraries. I used this opportunity to go through all disabled warnings in
>> hots
On Wed, 12 Oct 2022 13:33:26 GMT, Kim Barrett wrote:
>> Magnus Ihse Bursie has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> Github workflow changes were not supposed to be in this PR...
>
> make/hotspot/lib/CompileJvm.gmk line 92:
>
>> 9
On Wed, 12 Oct 2022 11:04:14 GMT, Magnus Ihse Bursie wrote:
>> After [JDK-8294281](https://bugs.openjdk.org/browse/JDK-8294281), it is now
>> possible to disable warnings for individual files instead for whole
>> libraries. I used this opportunity to go through all disabled warnings in
>> hots
On Wed, 12 Oct 2022 11:04:14 GMT, Magnus Ihse Bursie wrote:
>> After [JDK-8294281](https://bugs.openjdk.org/browse/JDK-8294281), it is now
>> possible to disable warnings for individual files instead for whole
>> libraries. I used this opportunity to go through all disabled warnings in
>> hots
On Wed, 12 Oct 2022 11:04:14 GMT, Magnus Ihse Bursie wrote:
>> After [JDK-8294281](https://bugs.openjdk.org/browse/JDK-8294281), it is now
>> possible to disable warnings for individual files instead for whole
>> libraries. I used this opportunity to go through all disabled warnings in
>> hots
> After [JDK-8294281](https://bugs.openjdk.org/browse/JDK-8294281), it is now
> possible to disable warnings for individual files instead for whole
> libraries. I used this opportunity to go through all disabled warnings in
> hotspot.
>
> Any warnings that were only triggered in a few files wer
