Re: RFR: 8294982: Implementation of Classfile API [v20]

2023-03-06 Thread Adam Sotona
On Wed, 1 Mar 2023 10:05:27 GMT, Adam Sotona wrote: >> src/java.base/share/classes/jdk/internal/classfile/impl/ChainedFieldBuilder.java >> line 48: >> >>> 46: this.consumer = consumer; >>> 47: FieldBuilder b = downstream; >>> 48: while (b instanceof ChainedFieldBuilder c

Re: RFR: 8294982: Implementation of Classfile API [v20]

2023-03-01 Thread Adam Sotona
On Thu, 16 Feb 2023 14:19:12 GMT, Maurizio Cimadamore wrote: >> Adam Sotona has updated the pull request incrementally with one additional >> commit since the last revision: >> >> added 4-byte Unicode text to Utf8EntryTest > > src/java.base/share/classes/jdk/internal/classfile/impl/ChainedFi

Re: RFR: 8294982: Implementation of Classfile API [v20]

2023-03-01 Thread Adam Sotona
On Thu, 16 Feb 2023 14:58:21 GMT, Maurizio Cimadamore wrote: >> Adam Sotona has updated the pull request incrementally with one additional >> commit since the last revision: >> >> added 4-byte Unicode text to Utf8EntryTest > > src/java.base/share/classes/jdk/internal/classfile/impl/Transform

Re: RFR: 8294982: Implementation of Classfile API [v20]

2023-03-01 Thread Adam Sotona
On Thu, 16 Feb 2023 11:34:28 GMT, Maurizio Cimadamore wrote: >> Adam Sotona has updated the pull request incrementally with one additional >> commit since the last revision: >> >> added 4-byte Unicode text to Utf8EntryTest > > src/java.base/share/classes/jdk/internal/classfile/components/pac

Re: RFR: 8294982: Implementation of Classfile API [v20]

2023-02-28 Thread Adam Sotona
On Thu, 16 Feb 2023 14:47:52 GMT, Maurizio Cimadamore wrote: >> Adam Sotona has updated the pull request incrementally with one additional >> commit since the last revision: >> >> added 4-byte Unicode text to Utf8EntryTest > > src/java.base/share/classes/jdk/internal/classfile/impl/Instructi

Re: RFR: 8294982: Implementation of Classfile API [v20]

2023-02-28 Thread Adam Sotona
On Thu, 16 Feb 2023 14:41:16 GMT, Maurizio Cimadamore wrote: >> Adam Sotona has updated the pull request incrementally with one additional >> commit since the last revision: >> >> added 4-byte Unicode text to Utf8EntryTest > > src/java.base/share/classes/jdk/internal/classfile/impl/ConcreteE

Re: RFR: 8294982: Implementation of Classfile API [v20]

2023-02-28 Thread Adam Sotona
On Thu, 16 Feb 2023 13:43:32 GMT, Maurizio Cimadamore wrote: >> Adam Sotona has updated the pull request incrementally with one additional >> commit since the last revision: >> >> added 4-byte Unicode text to Utf8EntryTest > > src/java.base/share/classes/jdk/internal/classfile/impl/BytecodeH

Re: RFR: 8294982: Implementation of Classfile API [v20]

2023-02-28 Thread Maurizio Cimadamore
On Tue, 28 Feb 2023 14:33:58 GMT, Adam Sotona wrote: >> src/java.base/share/classes/jdk/internal/classfile/impl/AttributeHolder.java >> line 38: >> >>> 36: private final List> attributes = new ArrayList<>(); >>> 37: >>> 38: public AttributeHolder() { >> >> default constructor > > yes,

Re: RFR: 8294982: Implementation of Classfile API [v20]

2023-02-28 Thread Adam Sotona
On Thu, 16 Feb 2023 13:47:04 GMT, Maurizio Cimadamore wrote: >> Adam Sotona has updated the pull request incrementally with one additional >> commit since the last revision: >> >> added 4-byte Unicode text to Utf8EntryTest > > src/java.base/share/classes/jdk/internal/classfile/impl/Attribute

Re: RFR: 8294982: Implementation of Classfile API [v20]

2023-02-28 Thread Adam Sotona
On Thu, 16 Feb 2023 13:40:49 GMT, Maurizio Cimadamore wrote: >> Adam Sotona has updated the pull request incrementally with one additional >> commit since the last revision: >> >> added 4-byte Unicode text to Utf8EntryTest > > src/java.base/share/classes/jdk/internal/classfile/constantpool/C

Re: RFR: 8294982: Implementation of Classfile API [v20]

2023-02-28 Thread Adam Sotona
On Thu, 16 Feb 2023 12:55:06 GMT, Maurizio Cimadamore wrote: >> Adam Sotona has updated the pull request incrementally with one additional >> commit since the last revision: >> >> added 4-byte Unicode text to Utf8EntryTest > > src/java.base/share/classes/jdk/internal/classfile/impl/SplitCons

Re: RFR: 8294982: Implementation of Classfile API [v20]

2023-02-27 Thread Adam Sotona
On Thu, 16 Feb 2023 11:29:51 GMT, Maurizio Cimadamore wrote: >> src/java.base/share/classes/jdk/internal/classfile/components/CodeStackTracker.java >> line 43: >> >>> 41: >>> 42: /** >>> 43: * CodeStackTracker is a {@link jdk.internal.classfile.CodeTransform} >>> synchronously tracking >>

Re: RFR: 8294982: Implementation of Classfile API [v20]

2023-02-27 Thread Adam Sotona
On Thu, 16 Feb 2023 11:21:29 GMT, Maurizio Cimadamore wrote: >> Adam Sotona has updated the pull request incrementally with one additional >> commit since the last revision: >> >> added 4-byte Unicode text to Utf8EntryTest > > src/java.base/share/classes/jdk/internal/classfile/components/Cod

Re: RFR: 8294982: Implementation of Classfile API [v20]

2023-02-27 Thread Adam Sotona
On Mon, 27 Feb 2023 11:54:53 GMT, Adam Sotona wrote: >> src/java.base/share/classes/jdk/internal/classfile/components/ClassRemapper.java >> line 168: >> >>> 166: public void accept(ClassBuilder clb, ClassElement cle) { >>> 167: switch (cle) { >>> 168: case Fi

Re: RFR: 8294982: Implementation of Classfile API [v20]

2023-02-27 Thread Adam Sotona
On Thu, 16 Feb 2023 11:09:30 GMT, Maurizio Cimadamore wrote: >> Adam Sotona has updated the pull request incrementally with one additional >> commit since the last revision: >> >> added 4-byte Unicode text to Utf8EntryTest > > src/java.base/share/classes/jdk/internal/classfile/components/Cla

Re: RFR: 8294982: Implementation of Classfile API [v20]

2023-02-27 Thread Adam Sotona
On Thu, 16 Feb 2023 10:54:00 GMT, Maurizio Cimadamore wrote: >> Adam Sotona has updated the pull request incrementally with one additional >> commit since the last revision: >> >> added 4-byte Unicode text to Utf8EntryTest > > src/java.base/share/classes/jdk/internal/classfile/components/Cla

Re: RFR: 8294982: Implementation of Classfile API [v20]

2023-02-27 Thread Adam Sotona
On Thu, 16 Feb 2023 10:51:10 GMT, Maurizio Cimadamore wrote: >> Adam Sotona has updated the pull request incrementally with one additional >> commit since the last revision: >> >> added 4-byte Unicode text to Utf8EntryTest > > src/java.base/share/classes/jdk/internal/classfile/components/Cla

Re: RFR: 8294982: Implementation of Classfile API [v20]

2023-02-27 Thread Adam Sotona
On Fri, 17 Feb 2023 17:09:51 GMT, Maurizio Cimadamore wrote: >> Yes, the print structure does not exactly correspond to the Classfile API >> architecture, but rather to the classfile physical structure and it is >> partly similar to `javap` output. >> The common tree structure has been reverse

Re: RFR: 8294982: Implementation of Classfile API [v20]

2023-02-17 Thread Maurizio Cimadamore
On Fri, 17 Feb 2023 09:20:21 GMT, Adam Sotona wrote: >> src/java.base/share/classes/jdk/internal/classfile/impl/ClassPrinterImpl.java >> line 563: >> >>> 561: list("attributes", "attribute", >>> clm.attributes().stream().map(Attribute::attributeName))) >>> 562:

Re: RFR: 8294982: Implementation of Classfile API [v20]

2023-02-17 Thread Adam Sotona
On Thu, 16 Feb 2023 12:11:06 GMT, Jens Lidestrom wrote: >> Adam Sotona has updated the pull request incrementally with one additional >> commit since the last revision: >> >> added 4-byte Unicode text to Utf8EntryTest > > src/java.base/share/classes/jdk/internal/classfile/constantpool/Constan

Re: RFR: 8294982: Implementation of Classfile API [v20]

2023-02-17 Thread Adam Sotona
On Thu, 16 Feb 2023 14:24:21 GMT, Maurizio Cimadamore wrote: >> Adam Sotona has updated the pull request incrementally with one additional >> commit since the last revision: >> >> added 4-byte Unicode text to Utf8EntryTest > > src/java.base/share/classes/jdk/internal/classfile/impl/DirectCod

Re: RFR: 8294982: Implementation of Classfile API [v20]

2023-02-17 Thread Adam Sotona
On Thu, 16 Feb 2023 11:00:48 GMT, Maurizio Cimadamore wrote: >> Adam Sotona has updated the pull request incrementally with one additional >> commit since the last revision: >> >> added 4-byte Unicode text to Utf8EntryTest > > src/java.base/share/classes/jdk/internal/classfile/impl/ClassPrin

Re: RFR: 8294982: Implementation of Classfile API [v20]

2023-02-17 Thread Adam Sotona
On Thu, 16 Feb 2023 10:56:57 GMT, Maurizio Cimadamore wrote: >> Adam Sotona has updated the pull request incrementally with one additional >> commit since the last revision: >> >> added 4-byte Unicode text to Utf8EntryTest > > src/java.base/share/classes/jdk/internal/classfile/components/Cla

Re: RFR: 8294982: Implementation of Classfile API [v20]

2023-02-16 Thread Maurizio Cimadamore
On Thu, 16 Feb 2023 10:41:33 GMT, Adam Sotona wrote: >> This is root pull request with Classfile API implementation, tests and >> benchmarks initial drop into JDK. >> >> Following pull requests consolidating JDK class files parsing, generating, >> and transforming >> ([JDK-8294957](https://bu

Re: RFR: 8294982: Implementation of Classfile API [v20]

2023-02-16 Thread Maurizio Cimadamore
On Thu, 16 Feb 2023 10:41:33 GMT, Adam Sotona wrote: >> This is root pull request with Classfile API implementation, tests and >> benchmarks initial drop into JDK. >> >> Following pull requests consolidating JDK class files parsing, generating, >> and transforming >> ([JDK-8294957](https://bu

Re: RFR: 8294982: Implementation of Classfile API [v20]

2023-02-16 Thread Maurizio Cimadamore
On Thu, 16 Feb 2023 12:46:09 GMT, Maurizio Cimadamore wrote: >> Adam Sotona has updated the pull request incrementally with one additional >> commit since the last revision: >> >> added 4-byte Unicode text to Utf8EntryTest > > src/java.base/share/classes/jdk/internal/classfile/impl/SplitCons

Re: RFR: 8294982: Implementation of Classfile API [v20]

2023-02-16 Thread Jens Lidestrom
On Thu, 16 Feb 2023 10:41:33 GMT, Adam Sotona wrote: >> This is root pull request with Classfile API implementation, tests and >> benchmarks initial drop into JDK. >> >> Following pull requests consolidating JDK class files parsing, generating, >> and transforming >> ([JDK-8294957](https://bu

Re: RFR: 8294982: Implementation of Classfile API [v20]

2023-02-16 Thread Maurizio Cimadamore
On Thu, 16 Feb 2023 11:27:18 GMT, Maurizio Cimadamore wrote: >> Adam Sotona has updated the pull request incrementally with one additional >> commit since the last revision: >> >> added 4-byte Unicode text to Utf8EntryTest > > src/java.base/share/classes/jdk/internal/classfile/components/Cod

Re: RFR: 8294982: Implementation of Classfile API [v20]

2023-02-16 Thread Maurizio Cimadamore
On Thu, 16 Feb 2023 10:41:33 GMT, Adam Sotona wrote: >> This is root pull request with Classfile API implementation, tests and >> benchmarks initial drop into JDK. >> >> Following pull requests consolidating JDK class files parsing, generating, >> and transforming >> ([JDK-8294957](https://bu

Re: RFR: 8294982: Implementation of Classfile API [v20]

2023-02-16 Thread Adam Sotona
> This is root pull request with Classfile API implementation, tests and > benchmarks initial drop into JDK. > > Following pull requests consolidating JDK class files parsing, generating, > and transforming ([JDK-8294957](https://bugs.openjdk.org/browse/JDK-8294957)) > will chain to this one. >