Re: RFR: 8303130: Document required Accessibility permissions on macOS [v4]

2023-02-28 Thread Sergey Bylokhov
On Tue, 28 Feb 2023 17:03:01 GMT, Dmitry Markov wrote: >> Added the section devoted to client UI test which use Robot API > > Dmitry Markov has updated the pull request incrementally with one additional > commit since the last revision: > > Fix link Thank you for this doc update. --

Re: RFR: 8303130: Document required Accessibility permissions on macOS [v4]

2023-02-28 Thread Phil Race
On Tue, 28 Feb 2023 17:03:01 GMT, Dmitry Markov wrote: >> Added the section devoted to client UI test which use Robot API > > Dmitry Markov has updated the pull request incrementally with one additional > commit since the last revision: > > Fix link Marked as reviewed by prr (Reviewer). ---

Re: RFR: 8303130: Document required Accessibility permissions on macOS [v4]

2023-02-28 Thread Alexey Ivanov
On Tue, 28 Feb 2023 17:03:01 GMT, Dmitry Markov wrote: >> Added the section devoted to client UI test which use Robot API > > Dmitry Markov has updated the pull request incrementally with one additional > commit since the last revision: > > Fix link Marked as reviewed by aivanov (Reviewer).

Re: RFR: 8303130: Document required Accessibility permissions on macOS [v3]

2023-02-28 Thread Dmitry Markov
On Tue, 28 Feb 2023 16:45:36 GMT, Alexey Ivanov wrote: >> Dmitry Markov has updated the pull request incrementally with one additional >> commit since the last revision: >> >> Fix typo > > doc/testing.md line 668: > >> 666: Additional information about Client UI tests configuration for vario

Re: RFR: 8303130: Document required Accessibility permissions on macOS [v4]

2023-02-28 Thread Dmitry Markov
> Added the section devoted to client UI test which use Robot API Dmitry Markov has updated the pull request incrementally with one additional commit since the last revision: Fix link - Changes: - all: https://git.openjdk.org/jdk/pull/12772/files - new: https://git.openjdk.or

Re: RFR: 8303130: Document required Accessibility permissions on macOS [v3]

2023-02-28 Thread Alexey Ivanov
On Tue, 28 Feb 2023 14:17:11 GMT, Dmitry Markov wrote: >> Added the section devoted to client UI test which use Robot API > > Dmitry Markov has updated the pull request incrementally with one additional > commit since the last revision: > > Fix typo Changes requested by aivanov (Reviewer).

Re: RFR: 8303130: Document required Accessibility permissions on macOS [v3]

2023-02-28 Thread Erik Joelsson
On Tue, 28 Feb 2023 14:17:11 GMT, Dmitry Markov wrote: >> Added the section devoted to client UI test which use Robot API > > Dmitry Markov has updated the pull request incrementally with one additional > commit since the last revision: > > Fix typo Marked as reviewed by erikj (Reviewer). -

Re: RFR: 8303130: Document required Accessibility permissions on macOS [v2]

2023-02-28 Thread Patrick Chen
lgtm Le mar. 28 févr. 2023 à 15:18, Dmitry Markov a écrit : > On Tue, 28 Feb 2023 14:00:21 GMT, Erik Joelsson wrote: > > >> Dmitry Markov has updated the pull request incrementally with one > additional commit since the last revision: > >> > >> Fix review findings > > > > doc/testing.md line

Re: RFR: 8303130: Document required Accessibility permissions on macOS [v3]

2023-02-28 Thread Dmitry Markov
> Added the section devoted to client UI test which use Robot API Dmitry Markov has updated the pull request incrementally with one additional commit since the last revision: Fix typo - Changes: - all: https://git.openjdk.org/jdk/pull/12772/files - new: https://git.openjdk.or

Re: RFR: 8303130: Document required Accessibility permissions on macOS [v2]

2023-02-28 Thread Dmitry Markov
On Tue, 28 Feb 2023 14:00:21 GMT, Erik Joelsson wrote: >> Dmitry Markov has updated the pull request incrementally with one additional >> commit since the last revision: >> >> Fix review findings > > doc/testing.md line 666: > >> 664: the `ForegroundLockTimeout` value is set to 0. >> 665: >

Re: RFR: 8303130: Document required Accessibility permissions on macOS [v2]

2023-02-28 Thread Erik Joelsson
On Tue, 28 Feb 2023 11:03:41 GMT, Dmitry Markov wrote: >> Added the section devoted to client UI test which use Robot API > > Dmitry Markov has updated the pull request incrementally with one additional > commit since the last revision: > > Fix review findings doc/testing.md line 666: > 664

Re: RFR: 8303130: Document required Accessibility permissions on macOS [v2]

2023-02-28 Thread Patrick Chen
pre submit tests failed Le mar. 28 févr. 2023 à 12:04, Dmitry Markov a écrit : > On Mon, 27 Feb 2023 20:52:52 GMT, Sergey Bylokhov > wrote: > > >> Dmitry Markov has updated the pull request incrementally with one > additional commit since the last revision: > >> > >> Fix review findings > > >

Re: RFR: 8303130: Document required Accessibility permissions on macOS [v2]

2023-02-28 Thread Dmitry Markov
On Mon, 27 Feb 2023 18:49:15 GMT, Alexey Ivanov wrote: >> Dmitry Markov has updated the pull request incrementally with one additional >> commit since the last revision: >> >> Fix review findings > > doc/testing.md line 616: > >> 614: system key shortcuts for various platforms are provided b

Re: RFR: 8303130: Document required Accessibility permissions on macOS [v2]

2023-02-28 Thread Dmitry Markov
On Mon, 27 Feb 2023 20:52:52 GMT, Sergey Bylokhov wrote: >> Dmitry Markov has updated the pull request incrementally with one additional >> commit since the last revision: >> >> Fix review findings > > doc/testing.md line 664: > >> 662: select Registry Editor; navigate to the following key:

Re: RFR: 8303130: Document required Accessibility permissions on macOS [v2]

2023-02-28 Thread Dmitry Markov
On Mon, 27 Feb 2023 21:11:33 GMT, Alexey Ivanov wrote: >> doc/testing.html line 621: >> >>> 619: the following apps are allowed to control your computer: >>> 620: Java and Terminal. If the tests are run from >>> 621: an IDE, the IDE should be granted this permission too. >> >> You can mention t

Re: RFR: 8303130: Document required Accessibility permissions on macOS

2023-02-28 Thread Dmitry Markov
On Mon, 27 Feb 2023 15:54:28 GMT, Dmitry Markov wrote: > Added the section devoted to client UI test which use Robot API @aivanov-jdk @mrserb Thanks for review. I have updated the text based on your suggestions. Please have a look at the new version. - PR: https://git.openjdk.org/

Re: RFR: 8303130: Document required Accessibility permissions on macOS [v2]

2023-02-28 Thread Dmitry Markov
> Added the section devoted to client UI test which use Robot API Dmitry Markov has updated the pull request incrementally with one additional commit since the last revision: Fix review findings - Changes: - all: https://git.openjdk.org/jdk/pull/12772/files - new: https://git

Re: RFR: 8303130: Document required Accessibility permissions on macOS

2023-02-27 Thread Alexey Ivanov
On Mon, 27 Feb 2023 20:54:08 GMT, Sergey Bylokhov wrote: >> Added the section devoted to client UI test which use Robot API > > doc/testing.html line 621: > >> 619: the following apps are allowed to control your computer: >> 620: Java and Terminal. If the tests are run from >> 621: an IDE, the I

Re: RFR: 8303130: Document required Accessibility permissions on macOS

2023-02-27 Thread Sergey Bylokhov
On Mon, 27 Feb 2023 15:54:28 GMT, Dmitry Markov wrote: > Added the section devoted to client UI test which use Robot API doc/testing.html line 621: > 619: the following apps are allowed to control your computer: > 620: Java and Terminal. If the tests are run from > 621: an IDE, the IDE should b

Re: RFR: 8303130: Document required Accessibility permissions on macOS

2023-02-27 Thread Alexey Ivanov
On Mon, 27 Feb 2023 15:54:28 GMT, Dmitry Markov wrote: > Added the section devoted to client UI test which use Robot API doc/testing.md line 616: > 614: system key shortcuts for various platforms are provided below. > 615: > 616: # MacOS Suggestion: # macOS Shall we spell _macOS_ wi

RFR: 8303130: Document required Accessibility permissions on macOS

2023-02-27 Thread Dmitry Markov
Added the section devoted to client UI test which use Robot API - Commit messages: - 8303130: Document required Accessibility permissions on macOS Changes: https://git.openjdk.org/jdk/pull/12772/files Webrev: https://webrevs.openjdk.org/?repo=jdk&pr=12772&range=00 Issue: https://