Re: RFR: 8303485: Replacing os.name for operating system customization [v3]

2023-03-14 Thread Eirik Bjorsnos
On Tue, 14 Mar 2023 18:15:46 GMT, Roger Riggs wrote: >> src/java.base/share/classes/jdk/internal/util/OperatingSystem.java line 29: >> >>> 27: >>> 28: /** >>> 29: * Enumeration of operating system types and testing for the current OS. >> >> Would it be more correct to say an enumerating of

Re: RFR: 8303485: Replacing os.name for operating system customization [v3]

2023-03-14 Thread Roger Riggs
On Tue, 14 Mar 2023 15:04:47 GMT, Alan Bateman wrote: >> Roger Riggs has updated the pull request incrementally with one additional >> commit since the last revision: >> >> Fix indentation and improve exception message > > src/java.base/share/classes/jdk/internal/util/OperatingSystem.java

Re: RFR: 8303485: Replacing os.name for operating system customization [v3]

2023-03-14 Thread Alan Bateman
On Tue, 14 Mar 2023 14:14:30 GMT, Roger Riggs wrote: >> Improvements to support OS specific customization for JDK internal use: >> - To select values and code; allowing elimination of unused code and values >> - Optionally evaluated by build processes, compilation, or archiving (i.e. >> CDS)

Re: RFR: 8303485: Replacing os.name for operating system customization [v3]

2023-03-14 Thread Roger Riggs
> Improvements to support OS specific customization for JDK internal use: > - To select values and code; allowing elimination of unused code and values > - Optionally evaluated by build processes, compilation, or archiving (i.e. > CDS) > - Simple API to replace adhoc comparisons with `os.name`