> Minor changes to the build system to recognize and warn that an incompatible
> toolchain is detected.
Tyler Steele has updated the pull request incrementally with two additional
commits since the last revision:
- Trivial II
- Trivial I
-
Changes:
- all: https://git.openjdk.o
On Tue, 4 Apr 2023 01:49:09 GMT, Tyler Steele wrote:
>> Minor changes to the build system to recognize and warn that an incompatible
>> toolchain is detected.
>
> Tyler Steele has updated the pull request incrementally with one additional
> commit since the last revision:
>
> Change min xlx
On Tue, 4 Apr 2023 01:49:09 GMT, Tyler Steele wrote:
>> Minor changes to the build system to recognize and warn that an incompatible
>> toolchain is detected.
>
> Tyler Steele has updated the pull request incrementally with one additional
> commit since the last revision:
>
> Change min xlx
On Tue, 4 Apr 2023 01:49:09 GMT, Tyler Steele wrote:
>> Minor changes to the build system to recognize and warn that an incompatible
>> toolchain is detected.
>
> Tyler Steele has updated the pull request incrementally with one additional
> commit since the last revision:
>
> Change min xlx
On Fri, 21 Apr 2023 11:54:04 GMT, Matthias Baesken wrote:
> seems I have to adjust the separated test script to
>
> ```
> #!/bin/sh
>
> COMPILER_VERSION_OUTPUT=`xlclang -qversion 2>&1`
>
> COMPILER_VERSION_NUMBER=`echo $COMPILER_VERSION_OUTPUT | sed -e
> 's/^.*Version: ([1-9][0-9.]*).*$/\1/'`
On Tue, 4 Apr 2023 01:49:09 GMT, Tyler Steele wrote:
>> Minor changes to the build system to recognize and warn that an incompatible
>> toolchain is detected.
>
> Tyler Steele has updated the pull request incrementally with one additional
> commit since the last revision:
>
> Change min xlx
On Tue, 4 Apr 2023 01:49:09 GMT, Tyler Steele wrote:
>> Minor changes to the build system to recognize and warn that an incompatible
>> toolchain is detected.
>
> Tyler Steele has updated the pull request incrementally with one additional
> commit since the last revision:
>
> Change min xlx
On Tue, 4 Apr 2023 01:49:09 GMT, Tyler Steele wrote:
>> Minor changes to the build system to recognize and warn that an incompatible
>> toolchain is detected.
>
> Tyler Steele has updated the pull request incrementally with one additional
> commit since the last revision:
>
> Change min xlx
On Thu, 23 Mar 2023 18:42:41 GMT, Martin Doerr wrote:
>> Minor changes to the build system to recognize and warn that an incompatible
>> toolchain is detected.
>
> Yes, I think it's better to define the minimum version to a compiler which
> will work at the point of time at which we integrate t
> Minor changes to the build system to recognize and warn that an incompatible
> toolchain is detected.
Tyler Steele has updated the pull request incrementally with one additional
commit since the last revision:
Change min xlx FP level to 11
-
Changes:
- all: https://git.openj
On Fri, 17 Mar 2023 22:36:24 GMT, Tyler Steele wrote:
> Minor changes to the build system to recognize and warn that an incompatible
> toolchain is detected.
Yes, I think it's better to define the minimum version to a compiler which will
work at the point of time at which we integrate this PR.
On Fri, 17 Mar 2023 22:36:24 GMT, Tyler Steele wrote:
> Minor changes to the build system to recognize and warn that an incompatible
> toolchain is detected.
I assume you're referring to JDK-8304291[1]? I actually based these changes on
the commit just prior to the one that broke so that I cou
On Fri, 17 Mar 2023 22:36:24 GMT, Tyler Steele wrote:
> Minor changes to the build system to recognize and warn that an incompatible
> toolchain is detected.
I think we should get it compiling before we define the minimum level.
Otherwise we may have to change it several times.
-
On Fri, 17 Mar 2023 22:36:24 GMT, Tyler Steele wrote:
> Minor changes to the build system to recognize and warn that an incompatible
> toolchain is detected.
I am currently using 16.1.0.0011. If we want to stick with one we have tested,
rather than the lowest version we know will cause an issu
On Fri, 17 Mar 2023 22:36:24 GMT, Tyler Steele wrote:
> Minor changes to the build system to recognize and warn that an incompatible
> toolchain is detected.
I think 16.1.0.0002 is pretty old. Shouldn't we better require some version we
have tested? We have tested 16.1.0.13.
-
PR
On Mon, 20 Mar 2023 20:07:12 GMT, Martin Doerr wrote:
>> Minor changes to the build system to recognize and warn that an incompatible
>> toolchain is detected.
>
> LGTM. I think the reason for this PR is another issue? If so, please link the
> JBS issues as "relates to".
> @MBaesken: Please tak
On Fri, 17 Mar 2023 22:36:24 GMT, Tyler Steele wrote:
> Minor changes to the build system to recognize and warn that an incompatible
> toolchain is detected.
LGTM. I think the reason for this PR is another issue? If so, please link the
JBS issues as "relates to".
@MBaesken: Please take a look.
On Fri, 17 Mar 2023 22:36:24 GMT, Tyler Steele wrote:
> Minor changes to the build system to recognize and warn that an incompatible
> toolchain is detected.
Thanks for the review Erik.
These changes are pretty close to trivial, but I would still like to get a
second review in case there is s
On Fri, 17 Mar 2023 22:36:24 GMT, Tyler Steele wrote:
> Minor changes to the build system to recognize and warn that an incompatible
> toolchain is detected.
Marked as reviewed by erikj (Reviewer).
-
PR: https://git.openjdk.org/jdk/pull/13086
Minor changes to the build system to recognize and warn that an incompatible
toolchain is detected.
-
Commit messages:
- Set xlc toolchain minimum version
Changes: https://git.openjdk.org/jdk/pull/13086/files
Webrev: https://webrevs.openjdk.org/?repo=jdk&pr=13086&range=00
Issue:
20 matches
Mail list logo
