On Mon, 20 Nov 2023 16:48:51 GMT, Lance Andersen wrote:
> Hi Joe,
>
> Thank you for all of your hard work and perseverance to drive this project as
> I realize it was a lot of work and iterations based on feedback from the team.
>
> Overall looks good. A couple of minor comments below
Thanks
On Mon, 20 Nov 2023 16:38:54 GMT, Magnus Ihse Bursie wrote:
> Build change trivially okay
Thanks Magnus!
-
PR Comment: https://git.openjdk.org/jdk/pull/16719#issuecomment-1819529895
On Sun, 19 Nov 2023 23:36:16 GMT, Joe Wang wrote:
>> Implement the built-in Catalog.
>
> Joe Wang has updated the pull request incrementally with one additional
> commit since the last revision:
>
> remove J2SE directory; add note explaining how DTDs are resolved
Hi Joe,
Thank you for all o
On Sun, 19 Nov 2023 23:36:16 GMT, Joe Wang wrote:
>> Implement the built-in Catalog.
>
> Joe Wang has updated the pull request incrementally with one additional
> commit since the last revision:
>
> remove J2SE directory; add note explaining how DTDs are resolved
Build change trivially okay
On Sun, 19 Nov 2023 23:36:16 GMT, Joe Wang wrote:
>> Implement the built-in Catalog.
>
> Joe Wang has updated the pull request incrementally with one additional
> commit since the last revision:
>
> remove J2SE directory; add note explaining how DTDs are resolved
Tests: Tier 1-3 and JCK pass
On Sun, 19 Nov 2023 08:46:30 GMT, Alan Bateman wrote:
>> Joe Wang has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> remove J2SE directory; add note explaining how DTDs are resolved
>
> src/java.xml/share/classes/module-info.java line 910:
On Sun, 19 Nov 2023 08:45:29 GMT, Alan Bateman wrote:
>> src/java.xml/share/classes/jdk/xml/internal/jdkcatalog/JDKCatalog.xml line
>> 34:
>>
>>> 32:
>>> 33: http://java.sun.com/dtd/preferences.dtd";
>>> uri="J2SE/preferences.dtd"/>
>>> 34: http://java.sun.com/dtd/properti
> Implement the built-in Catalog.
Joe Wang has updated the pull request incrementally with one additional commit
since the last revision:
remove J2SE directory; add note explaining how DTDs are resolved
-
Changes:
- all: https://git.openjdk.org/jdk/pull/16719/files
- new: htt
