Re: RFR: 8307058: Implementation of Generational ZGC [v2]

2023-05-04 Thread Stefan Karlsson
On Wed, 3 May 2023 21:08:39 GMT, Stefan Karlsson wrote: >> test/jdk/ProblemList-generational-zgc.txt line 27: >> >>> 25: # >>> 26: # List of quarantined tests for testing with Generational ZGC. >>> 27: # >> >> Are the tests in `test/jdk/sun/tools/jhsdb/` not failing? > > It seems like these

Re: RFR: 8307058: Implementation of Generational ZGC [v2]

2023-05-03 Thread Stefan Karlsson
On Wed, 3 May 2023 20:00:42 GMT, Chris Plummer wrote: >> Yes, the test was finicky with the heap size. Given that the leak it tries >> to provoke would be provoked by other GCs as well, we didn't think it was >> that important to run this particular test with Generational ZGC. If you >> still

Re: RFR: 8307058: Implementation of Generational ZGC [v2]

2023-05-03 Thread Stefan Karlsson
On Wed, 3 May 2023 18:54:24 GMT, Chris Plummer wrote: >> Stefan Karlsson has updated the pull request incrementally with one >> additional commit since the last revision: >> >> Fix PPC build after 8305668 > > test/jdk/ProblemList-generational-zgc.txt line 27: > >> 25: # >> 26: # List of

Re: RFR: 8307058: Implementation of Generational ZGC [v2]

2023-05-03 Thread Chris Plummer
On Wed, 3 May 2023 19:42:01 GMT, Stefan Karlsson wrote: >> test/jdk/com/sun/jdi/ThreadMemoryLeakTest.java line 30: >> >>> 28: * >>> 29: * @comment Don't allow -Xcomp or -Xint as they impact memory useage >>> and number of iterations >>> 30: * @requires (vm.compMode == "Xmixed") & !(vm.gc.Z

Re: RFR: 8307058: Implementation of Generational ZGC [v2]

2023-05-03 Thread Stefan Karlsson
On Wed, 3 May 2023 18:57:22 GMT, Chris Plummer wrote: >> Stefan Karlsson has updated the pull request incrementally with one >> additional commit since the last revision: >> >> Fix PPC build after 8305668 > > test/jdk/com/sun/jdi/ThreadMemoryLeakTest.java line 30: > >> 28: * >> 29: *

Re: RFR: 8307058: Implementation of Generational ZGC [v2]

2023-05-03 Thread Stefan Karlsson
On Wed, 3 May 2023 18:52:19 GMT, Chris Plummer wrote: >> Stefan Karlsson has updated the pull request incrementally with one >> additional commit since the last revision: >> >> Fix PPC build after 8305668 > > test/hotspot/jtreg/ProblemList-generational-zgc.txt line 32: > >> 30: # Quiet all

Re: RFR: 8307058: Implementation of Generational ZGC [v2]

2023-05-03 Thread Chris Plummer
On Wed, 3 May 2023 10:55:49 GMT, Stefan Karlsson wrote: >> Hi all, >> >> Please review the implementation of Generational ZGC, which can be turned on >> by adding -XX:+ZGenerational in addition to using -XX:+UseZGC. Generational >> ZGC is a major rewrite of the non-generational ZGC version

Re: RFR: 8307058: Implementation of Generational ZGC [v2]

2023-05-03 Thread Martin Doerr
On Wed, 3 May 2023 10:55:49 GMT, Stefan Karlsson wrote: >> Hi all, >> >> Please review the implementation of Generational ZGC, which can be turned on >> by adding -XX:+ZGenerational in addition to using -XX:+UseZGC. Generational >> ZGC is a major rewrite of the non-generational ZGC version

Re: RFR: 8307058: Implementation of Generational ZGC [v2]

2023-05-03 Thread Stefan Karlsson
On Wed, 3 May 2023 12:29:15 GMT, Martin Doerr wrote: > Thanks for fixing PPC64! With this, the VM compiles and the > `test/hotspot/jtreg/gc` tests are passing on linux PPC64le. > > I'm glad to see this PR for JDK 21 LTS. It's a big step forward for ZGC. > Congratulations! Thanks for porting

Re: RFR: 8307058: Implementation of Generational ZGC [v2]

2023-05-03 Thread Martin Doerr
On Wed, 3 May 2023 10:55:49 GMT, Stefan Karlsson wrote: >> Hi all, >> >> Please review the implementation of Generational ZGC, which can be turned on >> by adding -XX:+ZGenerational in addition to using -XX:+UseZGC. Generational >> ZGC is a major rewrite of the non-generational ZGC version

Re: RFR: 8307058: Implementation of Generational ZGC [v2]

2023-05-03 Thread Stefan Karlsson
> Hi all, > > Please review the implementation of Generational ZGC, which can be turned on > by adding -XX:+ZGenerational in addition to using -XX:+UseZGC. Generational > ZGC is a major rewrite of the non-generational ZGC version that exists in the > openjdk/jdk repository. It splits the heap