Re: RFR: 8308753: Class-File API transition to Preview [v34]

2023-12-03 Thread Adam Sotona
> Classfile API is an internal library under package `jdk.internal.classfile`  > in JDK 21. > This pull request turns the Classfile API into a preview feature and moves it > into `java.lang.classfile`. > It repackages all uses across JDK and tests and adds lots of missing Javadoc. > > This PR goe

Re: RFR: 8308753: Class-File API transition to Preview [v33]

2023-12-01 Thread Adam Sotona
> Classfile API is an internal library under package `jdk.internal.classfile`  > in JDK 21. > This pull request turns the Classfile API into a preview feature and moves it > into `java.lang.classfile`. > It repackages all uses across JDK and tests and adds lots of missing Javadoc. > > This PR goe

Re: RFR: 8308753: Class-File API transition to Preview [v32]

2023-12-01 Thread Adam Sotona
On Wed, 29 Nov 2023 08:46:46 GMT, Per Minborg wrote: >> This is explicit list of supported class file versions, so I don't see any >> other way. > > Would it not be possible to expose an immutable `Map` that > maps from Java version to major class version? This is actually out of scope of this

Re: RFR: 8308753: Class-File API transition to Preview [v32]

2023-11-29 Thread Per Minborg
On Tue, 28 Nov 2023 13:03:48 GMT, Adam Sotona wrote: >> src/java.base/share/classes/java/lang/classfile/ClassFile.java line 1404: >> >>> (failed to retrieve contents of file, check the PR for context) >> Is there a more scalable way to express the major class version? The current >> approach me

Re: RFR: 8308753: Class-File API transition to Preview [v32]

2023-11-28 Thread Adam Sotona
On Tue, 28 Nov 2023 10:21:25 GMT, Per Minborg wrote: >> Adam Sotona has updated the pull request incrementally with one additional >> commit since the last revision: >> >> fixed SwitchBootstrapTest > > src/java.base/share/classes/java/lang/classfile/ClassFile.java line 1404: > >> (failed to

Re: RFR: 8308753: Class-File API transition to Preview [v32]

2023-11-28 Thread Per Minborg
On Mon, 27 Nov 2023 10:01:50 GMT, Adam Sotona wrote: >> Classfile API is an internal library under package `jdk.internal.classfile`  >> in JDK 21. >> This pull request turns the Classfile API into a preview feature and moves >> it into `java.lang.classfile`. >> It repackages all uses across JDK

Re: RFR: 8308753: Class-File API transition to Preview [v32]

2023-11-27 Thread Adam Sotona
> Classfile API is an internal library under package `jdk.internal.classfile`  > in JDK 21. > This pull request turns the Classfile API into a preview feature and moves it > into `java.lang.classfile`. > It repackages all uses across JDK and tests and adds lots of missing Javadoc. > > This PR goe

Re: RFR: 8308753: Class-File API transition to Preview [v31]

2023-11-27 Thread Adam Sotona
> Classfile API is an internal library under package `jdk.internal.classfile`  > in JDK 21. > This pull request turns the Classfile API into a preview feature and moves it > into `java.lang.classfile`. > It repackages all uses across JDK and tests and adds lots of missing Javadoc. > > This PR goe

Re: RFR: 8308753: Class-File API transition to Preview [v30]

2023-11-21 Thread Adam Sotona
> Classfile API is an internal library under package `jdk.internal.classfile`  > in JDK 21. > This pull request turns the Classfile API into a preview feature and moves it > into `java.lang.classfile`. > It repackages all uses across JDK and tests and adds lots of missing Javadoc. > > This PR goe

Re: RFR: 8308753: Class-File API transition to Preview [v29]

2023-11-20 Thread Adam Sotona
> Classfile API is an internal library under package `jdk.internal.classfile`  > in JDK 21. > This pull request turns the Classfile API into a preview feature and moves it > into `java.lang.classfile`. > It repackages all uses across JDK and tests and adds lots of missing Javadoc. > > This PR goe

Re: RFR: 8308753: Class-File API transition to Preview [v28]

2023-11-20 Thread Adam Sotona
> Classfile API is an internal library under package `jdk.internal.classfile`  > in JDK 21. > This pull request turns the Classfile API into a preview feature and moves it > into `java.lang.classfile`. > It repackages all uses across JDK and tests and adds lots of missing Javadoc. > > This PR goe

Re: RFR: 8308753: Class-File API transition to Preview [v27]

2023-11-09 Thread Adam Sotona
> Classfile API is an internal library under package `jdk.internal.classfile`  > in JDK 21. > This pull request turns the Classfile API into a preview feature and moves it > into `java.lang.classfile`. > It repackages all uses across JDK and tests and adds lots of missing Javadoc. > > This PR goe

Re: RFR: 8308753: Class-File API transition to Preview [v24]

2023-11-08 Thread Chen Liang
On Wed, 8 Nov 2023 15:45:56 GMT, Konrad Windszus wrote: > I know, but for memory consumption reasons everyone should prefer just > passing an InputStream. Is the memory consumption with > `ClassFile.of().parse(Path)` any better (i.e. are you using a > `java.io.RandomAccessFile` or `java.nio.ch

Re: RFR: 8308753: Class-File API transition to Preview [v25]

2023-11-08 Thread Adam Sotona
On Wed, 8 Nov 2023 15:22:54 GMT, Chen Liang wrote: >> Adam Sotona has updated the pull request with a new target base due to a >> merge or a rebase. The pull request now contains 360 commits: >> >> - fixed condy tests >> - Merge branch 'master' into JDK-8308753-preview >> - Merge branch 'mas

Re: RFR: 8308753: Class-File API transition to Preview [v26]

2023-11-08 Thread Adam Sotona
> Classfile API is an internal library under package `jdk.internal.classfile`  > in JDK 21. > This pull request turns the Classfile API into a preview feature and moves it > into `java.lang.classfile`. > It repackages all uses across JDK and tests and adds lots of missing Javadoc. > > This PR goe

Re: RFR: 8308753: Class-File API transition to Preview [v24]

2023-11-08 Thread Konrad Windszus
On Wed, 8 Nov 2023 14:07:04 GMT, Chen Liang wrote: > You can simply call `ClassFile.of().parse(inputStream.readAllBytes())` > instead. I know, but for memory consumption reasons everyone should prefer just passing an InputStream. Is the memory consumption with `ClassFile.of().parse(Path)` any

Re: RFR: 8308753: Class-File API transition to Preview [v25]

2023-11-08 Thread Chen Liang
On Wed, 8 Nov 2023 14:32:52 GMT, Adam Sotona wrote: >> Classfile API is an internal library under package `jdk.internal.classfile`  >> in JDK 21. >> This pull request turns the Classfile API into a preview feature and moves >> it into `java.lang.classfile`. >> It repackages all uses across JDK a

Re: RFR: 8308753: Class-File API transition to Preview [v25]

2023-11-08 Thread Adam Sotona
> Classfile API is an internal library under package `jdk.internal.classfile`  > in JDK 21. > This pull request turns the Classfile API into a preview feature and moves it > into `java.lang.classfile`. > It repackages all uses across JDK and tests and adds lots of missing Javadoc. > > This PR goe

Re: RFR: 8308753: Class-File API transition to Preview [v24]

2023-11-08 Thread Chen Liang
On Wed, 8 Nov 2023 13:31:32 GMT, Konrad Windszus wrote: > I would appreciate a hint in the javadocs why `Classfile.of` requires a byte > array and cannot deal with inputstreams (iiuc this is due to the lazy reading > which requires adjusting the offset back and forth potentially) You can simpl

Re: RFR: 8308753: Class-File API transition to Preview [v24]

2023-11-08 Thread Konrad Windszus
On Fri, 3 Nov 2023 08:39:37 GMT, Adam Sotona wrote: >> Classfile API is an internal library under package `jdk.internal.classfile`  >> in JDK 21. >> This pull request turns the Classfile API into a preview feature and moves >> it into `java.lang.classfile`. >> It repackages all uses across JDK a

Re: RFR: 8308753: Class-File API transition to Preview [v24]

2023-11-03 Thread Adam Sotona
> Classfile API is an internal library under package `jdk.internal.classfile`  > in JDK 21. > This pull request turns the Classfile API into a preview feature and moves it > into `java.lang.classfile`. > It repackages all uses across JDK and tests and adds lots of missing Javadoc. > > This PR goe

Re: RFR: 8308753: Class-File API transition to Preview [v23]

2023-10-25 Thread Adam Sotona
> Classfile API is an internal library under package `jdk.internal.classfile`  > in JDK 21. > This pull request turns the Classfile API into a preview feature and moves it > into `java.lang.classfile`. > It repackages all uses across JDK and tests and adds lots of missing Javadoc. > > This PR goe

Re: RFR: 8308753: Class-File API transition to Preview [v22]

2023-10-20 Thread Adam Sotona
> Classfile API is an internal library under package `jdk.internal.classfile`  > in JDK 21. > This pull request turns the Classfile API into a preview feature and moves it > into `java.lang.classfile`. > It repackages all uses across JDK and tests and adds lots of missing Javadoc. > > This PR goe

Re: RFR: 8308753: Class-File API transition to Preview [v21]

2023-10-16 Thread Adam Sotona
> Classfile API is an internal library under package `jdk.internal.classfile`  > in JDK 21. > This pull request turns the Classfile API into a preview feature and moves it > into `java.lang.classfile`. > It repackages all uses across JDK and tests and adds lots of missing Javadoc. > > This PR goe

Re: RFR: 8308753: Class-File API transition to Preview [v20]

2023-10-12 Thread Adam Sotona
> Classfile API is an internal library under package `jdk.internal.classfile`  > in JDK 21. > This pull request turns the Classfile API into a preview feature and moves it > into `java.lang.classfile`. > It repackages all uses across JDK and tests and adds lots of missing Javadoc. > > This PR goe

Re: RFR: 8308753: Class-File API transition to Preview [v19]

2023-10-12 Thread Adam Sotona
On Thu, 12 Oct 2023 11:11:10 GMT, Maurizio Cimadamore wrote: >> Adam Sotona has updated the pull request incrementally with one additional >> commit since the last revision: >> >> removed obsolete exports from BuildMicrobenchmark.gmk > > src/java.base/share/classes/java/lang/classfile/packag

Re: RFR: 8308753: Class-File API transition to Preview [v19]

2023-10-12 Thread Maurizio Cimadamore
On Wed, 11 Oct 2023 07:17:04 GMT, Adam Sotona wrote: >> Classfile API is an internal library under package `jdk.internal.classfile`  >> in JDK 21. >> This pull request turns the Classfile API into a preview feature and moves >> it into `java.lang.classfile`. >> It repackages all uses across JDK

Re: RFR: 8308753: Class-File API transition to Preview [v19]

2023-10-12 Thread Magnus Ihse Bursie
On Thu, 12 Oct 2023 10:40:03 GMT, Adam Sotona wrote: >> make/test/BuildMicrobenchmark.gmk line 99: >> >>> 97: JAVAC_FLAGS := --add-exports >>> java.base/sun.security.util=ALL-UNNAMED \ >>> 98: --add-exports java.base/sun.invoke.util=ALL-UNNAMED \ >>> 99: --add-exports java.b

Re: RFR: 8308753: Class-File API transition to Preview [v19]

2023-10-12 Thread Adam Sotona
On Thu, 12 Oct 2023 10:23:56 GMT, Magnus Ihse Bursie wrote: >> Adam Sotona has updated the pull request incrementally with one additional >> commit since the last revision: >> >> removed obsolete exports from BuildMicrobenchmark.gmk > > make/test/BuildMicrobenchmark.gmk line 99: > >> 97:

Re: RFR: 8308753: Class-File API transition to Preview [v19]

2023-10-12 Thread Magnus Ihse Bursie
On Wed, 11 Oct 2023 07:17:04 GMT, Adam Sotona wrote: >> Classfile API is an internal library under package `jdk.internal.classfile`  >> in JDK 21. >> This pull request turns the Classfile API into a preview feature and moves >> it into `java.lang.classfile`. >> It repackages all uses across JDK

Re: RFR: 8308753: Class-File API transition to Preview [v18]

2023-10-11 Thread Adam Sotona
On Tue, 10 Oct 2023 14:46:32 GMT, Chen Liang wrote: > We need to remove the outdated exports in `BuildMicroBenchmarks.gmk` after > the package migration. Removed, good catch, thanks! - PR Comment: https://git.openjdk.org/jdk/pull/15706#issuecomment-1756993662

Re: RFR: 8308753: Class-File API transition to Preview [v19]

2023-10-11 Thread Adam Sotona
> Classfile API is an internal library under package `jdk.internal.classfile`  > in JDK 21. > This pull request turns the Classfile API into a preview feature and moves it > into `java.lang.classfile`. > It repackages all uses across JDK and tests and adds lots of missing Javadoc. > > This PR goe

Re: RFR: 8308753: Class-File API transition to Preview [v18]

2023-10-10 Thread Chen Liang
On Tue, 10 Oct 2023 11:29:40 GMT, Adam Sotona wrote: >> Classfile API is an internal library under package `jdk.internal.classfile`  >> in JDK 21. >> This pull request turns the Classfile API into a preview feature and moves >> it into `java.lang.classfile`. >> It repackages all uses across JDK

Re: RFR: 8308753: Class-File API transition to Preview [v18]

2023-10-10 Thread Adam Sotona
> Classfile API is an internal library under package `jdk.internal.classfile`  > in JDK 21. > This pull request turns the Classfile API into a preview feature and moves it > into `java.lang.classfile`. > It repackages all uses across JDK and tests and adds lots of missing Javadoc. > > This PR goe

Re: RFR: 8308753: Class-File API transition to Preview [v17]

2023-10-09 Thread Adam Sotona
> Classfile API is an internal library under package `jdk.internal.classfile`  > in JDK 21. > This pull request turns the Classfile API into a preview feature and moves it > into `java.lang.classfile`. > It repackages all uses across JDK and tests and adds lots of missing Javadoc. > > This PR goe

Re: RFR: 8308753: Class-File API transition to Preview [v16]

2023-10-09 Thread Adam Sotona
> Classfile API is an internal library under package `jdk.internal.classfile`  > in JDK 21. > This pull request turns the Classfile API into a preview feature and moves it > into `java.lang.classfile`. > It repackages all uses across JDK and tests and adds lots of missing Javadoc. > > This PR goe

Re: RFR: 8308753: Class-File API transition to Preview [v15]

2023-10-05 Thread Adam Sotona
> Classfile API is an internal library under package `jdk.internal.classfile`  > in JDK 21. > This pull request turns the Classfile API into a preview feature and moves it > into `java.lang.classfile`. > It repackages all uses across JDK and tests and adds lots of missing Javadoc. > > This PR goe

Re: RFR: 8308753: Class-File API transition to Preview [v14]

2023-10-04 Thread Adam Sotona
On Wed, 4 Oct 2023 09:30:16 GMT, Adam Sotona wrote: >> Classfile API is an internal library under package `jdk.internal.classfile`  >> in JDK 21. >> This pull request turns the Classfile API into a preview feature and moves >> it into `java.lang.classfile`. >> It repackages all uses across JDK a

Re: RFR: 8308753: Class-File API transition to Preview [v14]

2023-10-04 Thread Vicente Romero
On Wed, 4 Oct 2023 09:30:16 GMT, Adam Sotona wrote: >> Classfile API is an internal library under package `jdk.internal.classfile`  >> in JDK 21. >> This pull request turns the Classfile API into a preview feature and moves >> it into `java.lang.classfile`. >> It repackages all uses across JDK a

Re: RFR: 8308753: Class-File API transition to Preview [v14]

2023-10-04 Thread Mandy Chung
On Wed, 4 Oct 2023 09:30:16 GMT, Adam Sotona wrote: >> Classfile API is an internal library under package `jdk.internal.classfile`  >> in JDK 21. >> This pull request turns the Classfile API into a preview feature and moves >> it into `java.lang.classfile`. >> It repackages all uses across JDK a

Re: RFR: 8308753: Class-File API transition to Preview [v14]

2023-10-04 Thread Adam Sotona
> Classfile API is an internal library under package `jdk.internal.classfile`  > in JDK 21. > This pull request turns the Classfile API into a preview feature and moves it > into `java.lang.classfile`. > It repackages all uses across JDK and tests and adds lots of missing Javadoc. > > This PR goe

Re: RFR: 8308753: Class-File API transition to Preview [v13]

2023-10-04 Thread Adam Sotona
> Classfile API is an internal library under package `jdk.internal.classfile`  > in JDK 21. > This pull request turns the Classfile API into a preview feature and moves it > into `java.lang.classfile`. > It repackages all uses across JDK and tests and adds lots of missing Javadoc. > > This PR goe

Re: RFR: 8308753: Class-File API transition to Preview [v12]

2023-10-03 Thread Adam Sotona
> Classfile API is an internal library under package `jdk.internal.classfile`  > in JDK 21. > This pull request turns the Classfile API into a preview feature and moves it > into `java.lang.classfile`. > It repackages all uses across JDK and tests and adds lots of missing Javadoc. > > This PR goe

Re: RFR: 8308753: Class-File API transition to Preview [v11]

2023-10-03 Thread Adam Sotona
On Tue, 3 Oct 2023 18:55:36 GMT, ExE Boss wrote: >> Adam Sotona has updated the pull request incrementally with three additional >> commits since the last revision: >> >> - fixed case in the test text >> - fixing javadoc >> - Unified implementations of InvokeInstruction::count, fixed javadoc

Re: RFR: 8308753: Class-File API transition to Preview [v11]

2023-10-03 Thread ExE Boss
On Tue, 3 Oct 2023 14:11:08 GMT, Adam Sotona wrote: >> Classfile API is an internal library under package `jdk.internal.classfile`  >> in JDK 21. >> This pull request turns the Classfile API into a preview feature and moves >> it into `java.lang.classfile`. >> It repackages all uses across JDK a

Re: RFR: 8308753: Class-File API transition to Preview [v11]

2023-10-03 Thread Adam Sotona
> Classfile API is an internal library under package `jdk.internal.classfile`  > in JDK 21. > This pull request turns the Classfile API into a preview feature and moves it > into `java.lang.classfile`. > It repackages all uses across JDK and tests and adds lots of missing Javadoc. > > This PR goe

Re: RFR: 8308753: Class-File API transition to Preview [v3]

2023-10-03 Thread Adam Sotona
On Mon, 2 Oct 2023 14:51:47 GMT, Maurizio Cimadamore wrote: >> Adam Sotona has updated the pull request incrementally with one additional >> commit since the last revision: >> >> fixed javadoc typo > > test/langtools/tools/javac/classfiles/attributes/SourceFile/NoSourceFileAttribute.java >

Re: RFR: 8308753: Class-File API transition to Preview [v3]

2023-10-03 Thread Adam Sotona
On Mon, 2 Oct 2023 14:03:48 GMT, Maurizio Cimadamore wrote: >> Adam Sotona has updated the pull request incrementally with one additional >> commit since the last revision: >> >> fixed javadoc typo > > src/java.base/share/classes/java/lang/classfile/package-info.java line 389: > >> 387: *

Re: RFR: 8308753: Class-File API transition to Preview [v3]

2023-10-03 Thread Adam Sotona
On Mon, 2 Oct 2023 13:54:22 GMT, Maurizio Cimadamore wrote: >> Adam Sotona has updated the pull request incrementally with one additional >> commit since the last revision: >> >> fixed javadoc typo > > src/java.base/share/classes/java/lang/classfile/package-info.java line 259: > >> 257: *

Re: RFR: 8308753: Class-File API transition to Preview [v3]

2023-10-03 Thread Adam Sotona
On Mon, 2 Oct 2023 13:57:58 GMT, Maurizio Cimadamore wrote: >> Adam Sotona has updated the pull request incrementally with one additional >> commit since the last revision: >> >> fixed javadoc typo > > src/java.base/share/classes/java/lang/classfile/package-info.java line 273: > >> 271: *

Re: RFR: 8308753: Class-File API transition to Preview [v3]

2023-10-03 Thread Adam Sotona
On Mon, 2 Oct 2023 13:50:56 GMT, Maurizio Cimadamore wrote: >> src/java.base/share/classes/java/lang/classfile/instruction/InvokeInstruction.java >> line 67: >> >>> 65: >>> 66: /** >>> 67: * {@return for an {@code invokeinterface}, the {@code count} >>> value, as defined in {@jvms 6

Re: RFR: 8308753: Class-File API transition to Preview [v10]

2023-10-03 Thread Adam Sotona
> Classfile API is an internal library under package `jdk.internal.classfile`  > in JDK 21. > This pull request turns the Classfile API into a preview feature and moves it > into `java.lang.classfile`. > It repackages all uses across JDK and tests and adds lots of missing Javadoc. > > This PR goe

Re: RFR: 8308753: Class-File API transition to Preview [v3]

2023-10-03 Thread Adam Sotona
On Mon, 2 Oct 2023 13:46:53 GMT, Maurizio Cimadamore wrote: >> Adam Sotona has updated the pull request incrementally with one additional >> commit since the last revision: >> >> fixed javadoc typo > > src/java.base/share/classes/java/lang/classfile/instruction/CharacterRange.java > line 77

Re: RFR: 8308753: Class-File API transition to Preview [v9]

2023-10-03 Thread Adam Sotona
> Classfile API is an internal library under package `jdk.internal.classfile`  > in JDK 21. > This pull request turns the Classfile API into a preview feature and moves it > into `java.lang.classfile`. > It repackages all uses across JDK and tests and adds lots of missing Javadoc. > > This PR goe

Re: RFR: 8308753: Class-File API transition to Preview [v3]

2023-10-03 Thread Adam Sotona
On Mon, 2 Oct 2023 13:38:18 GMT, Maurizio Cimadamore wrote: >> Adam Sotona has updated the pull request incrementally with one additional >> commit since the last revision: >> >> fixed javadoc typo > > src/java.base/share/classes/java/lang/classfile/attribute/package-info.java > line 27: >

Re: RFR: 8308753: Class-File API transition to Preview [v8]

2023-10-03 Thread Adam Sotona
> Classfile API is an internal library under package `jdk.internal.classfile`  > in JDK 21. > This pull request turns the Classfile API into a preview feature and moves it > into `java.lang.classfile`. > It repackages all uses across JDK and tests and adds lots of missing Javadoc. > > This PR goe

Re: RFR: 8308753: Class-File API transition to Preview [v3]

2023-10-02 Thread Adam Sotona
On Mon, 2 Oct 2023 14:45:52 GMT, Maurizio Cimadamore wrote: >> test/langtools/tools/javac/7166455/CheckACC_STRICTFlagOnclinitTest.java line >> 107: >> >>> 105: } >>> 106: >>> 107: // this version of the code can be used when ClassFile API in not in a >>> preview >> >> Do you want to kee

Re: RFR: 8308753: Class-File API transition to Preview [v2]

2023-10-02 Thread Vicente Romero
On Mon, 2 Oct 2023 07:18:19 GMT, Adam Sotona wrote: >> src/java.base/share/classes/java/lang/classfile/AnnotationElement.java line >> 34: >> >>> 32: import jdk.internal.javac.PreviewFeature; >>> 33: >>> 34: /** >> >> shouldn't we have the preview header applied to all these compilation units?

Re: RFR: 8308753: Class-File API transition to Preview [v3]

2023-10-02 Thread Adam Sotona
On Mon, 2 Oct 2023 14:56:11 GMT, Maurizio Cimadamore wrote: >> test/langtools/tools/javac/classfiles/attributes/SourceFile/SourceFileTestBase_legacy.java >> line 45: >> >>> 43: * @see #compileAndTest >>> 44: */ >>> 45: public class SourceFileTestBase_legacy extends TestBase { >> >> Why is t

Re: RFR: 8308753: Class-File API transition to Preview [v3]

2023-10-02 Thread Maurizio Cimadamore
On Mon, 2 Oct 2023 08:34:19 GMT, Adam Sotona wrote: >> Classfile API is an internal library under package `jdk.internal.classfile`  >> in JDK 21. >> This pull request turns the Classfile API into a preview feature and moves >> it into `java.lang.classfile`. >> It repackages all uses across JDK a

Re: RFR: 8308753: Class-File API transition to Preview [v3]

2023-10-02 Thread Maurizio Cimadamore
On Mon, 2 Oct 2023 08:34:19 GMT, Adam Sotona wrote: >> Classfile API is an internal library under package `jdk.internal.classfile`  >> in JDK 21. >> This pull request turns the Classfile API into a preview feature and moves >> it into `java.lang.classfile`. >> It repackages all uses across JDK a

Re: RFR: 8308753: Class-File API transition to Preview [v3]

2023-10-02 Thread Maurizio Cimadamore
On Mon, 2 Oct 2023 14:52:58 GMT, Maurizio Cimadamore wrote: >> Adam Sotona has updated the pull request incrementally with one additional >> commit since the last revision: >> >> fixed javadoc typo > > test/langtools/tools/javac/classfiles/attributes/SourceFile/SourceFileTestBase_legacy.java

Re: RFR: 8308753: Class-File API transition to Preview [v3]

2023-10-02 Thread Maurizio Cimadamore
On Mon, 2 Oct 2023 14:40:49 GMT, Maurizio Cimadamore wrote: >> Adam Sotona has updated the pull request incrementally with one additional >> commit since the last revision: >> >> fixed javadoc typo > > test/langtools/tools/javac/7166455/CheckACC_STRICTFlagOnclinitTest.java line > 107: > >>

Re: RFR: 8308753: Class-File API transition to Preview [v3]

2023-10-02 Thread Maurizio Cimadamore
On Mon, 2 Oct 2023 08:34:19 GMT, Adam Sotona wrote: >> Classfile API is an internal library under package `jdk.internal.classfile`  >> in JDK 21. >> This pull request turns the Classfile API into a preview feature and moves >> it into `java.lang.classfile`. >> It repackages all uses across JDK a

Re: RFR: 8308753: Class-File API transition to Preview [v3]

2023-10-02 Thread Adam Sotona
On Mon, 2 Oct 2023 13:40:40 GMT, Maurizio Cimadamore wrote: >> Adam Sotona has updated the pull request incrementally with one additional >> commit since the last revision: >> >> fixed javadoc typo > > src/java.base/share/classes/java/lang/classfile/components/CodeRelabeler.java > line 71:

Re: RFR: 8308753: Class-File API transition to Preview [v7]

2023-10-02 Thread Adam Sotona
> Classfile API is an internal library under package `jdk.internal.classfile`  > in JDK 21. > This pull request turns the Classfile API into a preview feature and moves it > into `java.lang.classfile`. > It repackages all uses across JDK and tests and adds lots of missing Javadoc. > > This PR goe

Re: RFR: 8308753: Class-File API transition to Preview [v6]

2023-10-02 Thread Adam Sotona
> Classfile API is an internal library under package `jdk.internal.classfile`  > in JDK 21. > This pull request turns the Classfile API into a preview feature and moves it > into `java.lang.classfile`. > It repackages all uses across JDK and tests and adds lots of missing Javadoc. > > This PR goe

Re: RFR: 8308753: Class-File API transition to Preview [v5]

2023-10-02 Thread Adam Sotona
> Classfile API is an internal library under package `jdk.internal.classfile`  > in JDK 21. > This pull request turns the Classfile API into a preview feature and moves it > into `java.lang.classfile`. > It repackages all uses across JDK and tests and adds lots of missing Javadoc. > > This PR goe

Re: RFR: 8308753: Class-File API transition to Preview [v3]

2023-10-02 Thread Adam Sotona
On Mon, 2 Oct 2023 13:29:59 GMT, Maurizio Cimadamore wrote: >> src/java.base/share/classes/java/lang/classfile/FieldTransform.java line 116: >> >>> 114: >>> 115: /** >>> 116: * @implSpec The default implementation returns a resolved >>> transform with all >> >> Perhaps lose the `all

Re: RFR: 8308753: Class-File API transition to Preview [v3]

2023-10-02 Thread Maurizio Cimadamore
On Mon, 2 Oct 2023 08:34:19 GMT, Adam Sotona wrote: >> Classfile API is an internal library under package `jdk.internal.classfile`  >> in JDK 21. >> This pull request turns the Classfile API into a preview feature and moves >> it into `java.lang.classfile`. >> It repackages all uses across JDK a

Re: RFR: 8308753: Class-File API transition to Preview [v3]

2023-10-02 Thread Adam Sotona
On Mon, 2 Oct 2023 13:26:38 GMT, Maurizio Cimadamore wrote: >> Adam Sotona has updated the pull request incrementally with one additional >> commit since the last revision: >> >> fixed javadoc typo > > src/java.base/share/classes/java/lang/classfile/CodeTransform.java line 101: > >> 99: >>

Re: RFR: 8308753: Class-File API transition to Preview [v4]

2023-10-02 Thread Adam Sotona
> Classfile API is an internal library under package `jdk.internal.classfile`  > in JDK 21. > This pull request turns the Classfile API into a preview feature and moves it > into `java.lang.classfile`. > It repackages all uses across JDK and tests and adds lots of missing Javadoc. > > This PR goe

Re: RFR: 8308753: Class-File API transition to Preview [v3]

2023-10-02 Thread Maurizio Cimadamore
On Mon, 2 Oct 2023 08:34:19 GMT, Adam Sotona wrote: >> Classfile API is an internal library under package `jdk.internal.classfile`  >> in JDK 21. >> This pull request turns the Classfile API into a preview feature and moves >> it into `java.lang.classfile`. >> It repackages all uses across JDK a

Re: RFR: 8308753: Class-File API transition to Preview [v3]

2023-10-02 Thread Adam Sotona
On Mon, 2 Oct 2023 13:24:49 GMT, Maurizio Cimadamore wrote: >> Adam Sotona has updated the pull request incrementally with one additional >> commit since the last revision: >> >> fixed javadoc typo > > src/java.base/share/classes/java/lang/classfile/CodeBuilder.java line 596: > >> 594:

Re: RFR: 8308753: Class-File API transition to Preview [v3]

2023-10-02 Thread Maurizio Cimadamore
On Mon, 2 Oct 2023 13:50:17 GMT, Maurizio Cimadamore wrote: >> Adam Sotona has updated the pull request incrementally with one additional >> commit since the last revision: >> >> fixed javadoc typo > > src/java.base/share/classes/java/lang/classfile/instruction/InvokeInstruction.java > line

Re: RFR: 8308753: Class-File API transition to Preview [v3]

2023-10-02 Thread Adam Sotona
On Mon, 2 Oct 2023 13:23:00 GMT, Maurizio Cimadamore wrote: >> src/java.base/share/classes/java/lang/classfile/ClassTransform.java line 164: >> >>> 162: >>> 163: /** >>> 164: * @implSpec >> >> Should these overridden method have `@inheritDoc` ? If not, their javadoc >> won't show mu

Re: RFR: 8308753: Class-File API transition to Preview [v3]

2023-10-02 Thread Maurizio Cimadamore
On Mon, 2 Oct 2023 08:34:19 GMT, Adam Sotona wrote: >> Classfile API is an internal library under package `jdk.internal.classfile`  >> in JDK 21. >> This pull request turns the Classfile API into a preview feature and moves >> it into `java.lang.classfile`. >> It repackages all uses across JDK a

Re: RFR: 8308753: Class-File API transition to Preview [v3]

2023-10-02 Thread Maurizio Cimadamore
On Mon, 2 Oct 2023 08:34:19 GMT, Adam Sotona wrote: >> Classfile API is an internal library under package `jdk.internal.classfile`  >> in JDK 21. >> This pull request turns the Classfile API into a preview feature and moves >> it into `java.lang.classfile`. >> It repackages all uses across JDK a

Re: RFR: 8308753: Class-File API transition to Preview [v3]

2023-10-02 Thread Maurizio Cimadamore
On Mon, 2 Oct 2023 08:34:19 GMT, Adam Sotona wrote: >> Classfile API is an internal library under package `jdk.internal.classfile`  >> in JDK 21. >> This pull request turns the Classfile API into a preview feature and moves >> it into `java.lang.classfile`. >> It repackages all uses across JDK a

Re: RFR: 8308753: Class-File API transition to Preview [v3]

2023-10-02 Thread Maurizio Cimadamore
On Mon, 2 Oct 2023 13:19:48 GMT, Maurizio Cimadamore wrote: >> Adam Sotona has updated the pull request incrementally with one additional >> commit since the last revision: >> >> fixed javadoc typo > > src/java.base/share/classes/java/lang/classfile/ClassTransform.java line 164: > >> 162:

Re: RFR: 8308753: Class-File API transition to Preview [v2]

2023-10-02 Thread Adam Sotona
On Fri, 29 Sep 2023 23:00:44 GMT, Vicente Romero wrote: >> Adam Sotona has updated the pull request incrementally with one additional >> commit since the last revision: >> >> PreviewFeature annotated with JEP 457 > > make/jdk/src/classes/build/tools/module/GenModuleInfoSource.java line 476: >

Re: RFR: 8308753: Class-File API transition to Preview [v3]

2023-10-02 Thread Adam Sotona
> Classfile API is an internal library under package `jdk.internal.classfile`  > in JDK 21. > This pull request turns the Classfile API into a preview feature and moves it > into `java.lang.classfile`. > It repackages all uses across JDK and tests and adds lots of missing Javadoc. > > This PR goe

Re: RFR: 8308753: Class-File API transition to Preview [v2]

2023-09-29 Thread Vicente Romero
On Tue, 26 Sep 2023 12:32:37 GMT, Adam Sotona wrote: >> Classfile API is an internal library under package `jdk.internal.classfile`  >> in JDK 21. >> This pull request turns the Classfile API into a preview feature and moves >> it into `java.lang.classfile`. >> It repackages all uses across JDK

Re: RFR: 8308753: Class-File API transition to Preview [v2]

2023-09-29 Thread Vicente Romero
On Tue, 26 Sep 2023 12:32:37 GMT, Adam Sotona wrote: >> Classfile API is an internal library under package `jdk.internal.classfile`  >> in JDK 21. >> This pull request turns the Classfile API into a preview feature and moves >> it into `java.lang.classfile`. >> It repackages all uses across JDK

Re: RFR: 8308753: Class-File API transition to Preview [v2]

2023-09-28 Thread Jonathan Gibbons
On Tue, 26 Sep 2023 12:32:37 GMT, Adam Sotona wrote: >> Classfile API is an internal library under package `jdk.internal.classfile`  >> in JDK 21. >> This pull request turns the Classfile API into a preview feature and moves >> it into `java.lang.classfile`. >> It repackages all uses across JDK

Re: RFR: 8308753: Class-File API transition to Preview [v2]

2023-09-26 Thread Adam Sotona
On Tue, 26 Sep 2023 13:10:15 GMT, Chen Liang wrote: >> Adam Sotona has updated the pull request incrementally with one additional >> commit since the last revision: >> >> PreviewFeature annotated with JEP 457 > > src/java.base/share/classes/jdk/internal/javac/PreviewFeature.java line 82: > >

Re: RFR: 8308753: Class-File API transition to Preview [v2]

2023-09-26 Thread Chen Liang
On Tue, 26 Sep 2023 12:32:37 GMT, Adam Sotona wrote: >> Classfile API is an internal library under package `jdk.internal.classfile`  >> in JDK 21. >> This pull request turns the Classfile API into a preview feature and moves >> it into `java.lang.classfile`. >> It repackages all uses across JDK

Re: RFR: 8308753: Class-File API transition to Preview [v2]

2023-09-26 Thread Adam Sotona
> Classfile API is an internal library under package `jdk.internal.classfile`  > in JDK 21. > This pull request turns the Classfile API into a preview feature and moves it > into `java.lang.classfile`. > It repackages all uses across JDK and tests and adds lots of missing Javadoc. > > This PR goe

Re: RFR: 8308753: Class-File API transition to Preview

2023-09-26 Thread Magnus Ihse Bursie
On Wed, 13 Sep 2023 09:48:00 GMT, Adam Sotona wrote: > Classfile API is an internal library under package `jdk.internal.classfile`  > in JDK 21. > This pull request turns the Classfile API into a preview feature and moves it > into `java.lang.classfile`. > It repackages all uses across JDK and t

RFR: 8308753: Class-File API transition to Preview

2023-09-26 Thread Adam Sotona
Classfile API is an internal library under package `jdk.internal.classfile` in JDK 21. This pull request turns the Classfile API into a preview feature and moves it into `java.lang.classfile`. It repackages all uses across JDK and tests and adds lots of missing Javadoc. This PR goes in sync with