Re: RFR: 8313374: --enable-ccache's CCACHE_BASEDIR breaks builds [v4]

2023-08-08 Thread Kim Barrett
On Mon, 31 Jul 2023 07:52:42 GMT, Jan Kratochvil wrote: > I doubt there is anyone as it did not work. :-) Um, I've been using it for years without noticing any problems, and measured a frequent speedup for my normal use. - PR Comment:

Re: RFR: 8313374: --enable-ccache's CCACHE_BASEDIR breaks builds [v4]

2023-08-08 Thread Erik Joelsson
On Mon, 31 Jul 2023 07:00:00 GMT, Jan Kratochvil wrote: >> https://bugs.openjdk.org/browse/JDK-8313374 >> --enable-ccache's CCACHE_BASEDIR breaks builds > > Jan Kratochvil has updated the pull request incrementally with one additional > commit since the last revision: > > Adjust

Re: RFR: 8313374: --enable-ccache's CCACHE_BASEDIR breaks builds [v4]

2023-08-08 Thread Jan Kratochvil
On Tue, 8 Aug 2023 13:26:22 GMT, Erik Joelsson wrote: > I understand why you need `fix-deps-file` when using `ccache`, but do you > also need `MakeCommandRelative`? I did try it without `MakeCommandRelative`. But it did not work. As the relative paths created by `ccache` itself will look

Re: RFR: 8313374: --enable-ccache's CCACHE_BASEDIR breaks builds [v4]

2023-08-08 Thread Erik Joelsson
On Mon, 31 Jul 2023 07:00:00 GMT, Jan Kratochvil wrote: >> https://bugs.openjdk.org/browse/JDK-8313374 >> --enable-ccache's CCACHE_BASEDIR breaks builds > > Jan Kratochvil has updated the pull request incrementally with one additional > commit since the last revision: > > Adjust

Re: RFR: 8313374: --enable-ccache's CCACHE_BASEDIR breaks builds [v4]

2023-07-31 Thread Julian Waters
On Mon, 31 Jul 2023 07:00:00 GMT, Jan Kratochvil wrote: >> https://bugs.openjdk.org/browse/JDK-8313374 >> --enable-ccache's CCACHE_BASEDIR breaks builds > > Jan Kratochvil has updated the pull request incrementally with one additional > commit since the last revision: > > Adjust

Re: RFR: 8313374: --enable-ccache's CCACHE_BASEDIR breaks builds [v4]

2023-07-31 Thread Julian Waters
On Mon, 31 Jul 2023 07:00:00 GMT, Jan Kratochvil wrote: >> https://bugs.openjdk.org/browse/JDK-8313374 >> --enable-ccache's CCACHE_BASEDIR breaks builds > > Jan Kratochvil has updated the pull request incrementally with one additional > commit since the last revision: > > Adjust

Re: RFR: 8313374: --enable-ccache's CCACHE_BASEDIR breaks builds [v4]

2023-07-31 Thread Julian Waters
On Mon, 31 Jul 2023 07:00:00 GMT, Jan Kratochvil wrote: >> https://bugs.openjdk.org/browse/JDK-8313374 >> --enable-ccache's CCACHE_BASEDIR breaks builds > > Jan Kratochvil has updated the pull request incrementally with one additional > commit since the last revision: > > Adjust

Re: RFR: 8313374: --enable-ccache's CCACHE_BASEDIR breaks builds [v4]

2023-07-31 Thread Jan Kratochvil
On Mon, 31 Jul 2023 07:00:00 GMT, Jan Kratochvil wrote: >> https://bugs.openjdk.org/browse/JDK-8313374 >> --enable-ccache's CCACHE_BASEDIR breaks builds > > Jan Kratochvil has updated the pull request incrementally with one additional > commit since the last revision: > > Adjust

Re: RFR: 8313374: --enable-ccache's CCACHE_BASEDIR breaks builds [v4]

2023-07-31 Thread David Holmes
On Mon, 31 Jul 2023 07:00:00 GMT, Jan Kratochvil wrote: >> https://bugs.openjdk.org/browse/JDK-8313374 >> --enable-ccache's CCACHE_BASEDIR breaks builds > > Jan Kratochvil has updated the pull request incrementally with one additional > commit since the last revision: > > Adjust

Re: RFR: 8313374: --enable-ccache's CCACHE_BASEDIR breaks builds [v4]

2023-07-31 Thread Jan Kratochvil
> https://bugs.openjdk.org/browse/JDK-8313374 > --enable-ccache's CCACHE_BASEDIR breaks builds Jan Kratochvil has updated the pull request incrementally with one additional commit since the last revision: Adjust compatibility with FILE_MACRO_CFLAGS. - Changes: - all: