Re: RFR: 8315038: Capstone disassembler stops when it sees a bad instruction [v2]

2023-09-18 Thread Aleksey Shipilev
On Mon, 18 Sep 2023 10:18:05 GMT, Andrew Haley wrote: >> At present, the Capstone disassembler stops whenever it encounters an >> undefined instruction. We really need it not to do that, because we use >> undefined instructions in JIT-generated code for many things. >> >> The fix is described

Re: RFR: 8315038: Capstone disassembler stops when it sees a bad instruction [v2]

2023-09-18 Thread Andrew Haley
> At present, the Capstone disassembler stops whenever it encounters an > undefined instruction. We really need it not to do that, because we use > undefined instructions in JIT-generated code for many things. > > The fix is described here: > https://www.capstone-engine.org/skipdata.html

Re: RFR: 8315038: Capstone disassembler stops when it sees a bad instruction [v2]

2023-09-18 Thread Andrew Haley
On Fri, 15 Sep 2023 14:57:39 GMT, Jorn Vernee wrote: >> Andrew Haley has updated the pull request incrementally with one additional >> commit since the last revision: >> >> Comment text > > src/utils/hsdis/capstone/hsdis-capstone.c line 153: > >> 151: cs_option(cs_handle, CS_OPT_SYNTAX,

Re: RFR: 8315038: Capstone disassembler stops when it sees a bad instruction

2023-09-16 Thread Andrew Haley
On Fri, 15 Sep 2023 14:56:10 GMT, Jorn Vernee wrote: > Some thoughts: that linked page claims this is only available on the `next` > branch, but I see this option is available in the 5.0.1 release from 3 weeks > ago (https://github.com/capstone-engine/capstone/releases/tag/5.0.1). That is >

Re: RFR: 8315038: Capstone disassembler stops when it sees a bad instruction

2023-09-15 Thread Jorn Vernee
On Fri, 15 Sep 2023 14:22:48 GMT, Andrew Haley wrote: > At present, the Capstone disassembler stops whenever it encounters an > undefined instruction. We really need it not to do that, because we use > undefined instructions in JIT-generated code for many things. > > The fix is described

RFR: 8315038: Capstone disassembler stops when it sees a bad instruction

2023-09-15 Thread Andrew Haley
At present, the Capstone disassembler stops whenever it encounters an undefined instruction. We really need it not to do that, because we use undefined instructions in JIT-generated code for many things. The fix is described here: https://www.capstone-engine.org/skipdata.html -