On Thu, 21 Sep 2023 06:08:27 GMT, Daniel Jeliński wrote:
>> Please review this patch that makes java.dll load shell32.dll earlier.
>> Delay-loading requires some additional code (delayimp.lib), and offers no
>> benefits since we always load shell32 during JVM startup.
>>
>> Other than removing
On Thu, 21 Sep 2023 06:08:27 GMT, Daniel Jeliński wrote:
>> Please review this patch that makes java.dll load shell32.dll earlier.
>> Delay-loading requires some additional code (delayimp.lib), and offers no
>> benefits since we always load shell32 during JVM startup.
>>
>> Other than removing
On Wed, 20 Sep 2023 14:42:40 GMT, Jorn Vernee wrote:
>> src/java.base/windows/native/libjava/java_props_md.c line 214:
>>
>>> 212: HRESULT hr;
>>> 213: WCHAR *tmpPath = NULL;
>>> 214: hr = SHGetKnownFolderPath(&FOLDERID_Profile,
>>> KF_FLAG_DONT_VERIFY, NULL, &tmpPath);
> Please review this patch that makes java.dll load shell32.dll earlier.
> Delay-loading requires some additional code (delayimp.lib), and offers no
> benefits since we always load shell32 during JVM startup.
>
> Other than removing the delayload clause, the patch also cleans up the
> `getHomeF
On Wed, 20 Sep 2023 14:41:59 GMT, Jorn Vernee wrote:
>> Daniel Jeliński has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> Remove unused define
>
> src/java.base/windows/native/libjava/java_props_md.c line 214:
>
>> 212: HRESULT hr
On Mon, 18 Sep 2023 18:10:12 GMT, Daniel Jeliński wrote:
>> Please review this patch that makes java.dll load shell32.dll earlier.
>> Delay-loading requires some additional code (delayimp.lib), and offers no
>> benefits since we always load shell32 during JVM startup.
>>
>> Other than removing
On Mon, 18 Sep 2023 18:10:12 GMT, Daniel Jeliński wrote:
>> Please review this patch that makes java.dll load shell32.dll earlier.
>> Delay-loading requires some additional code (delayimp.lib), and offers no
>> benefits since we always load shell32 during JVM startup.
>>
>> Other than removing
On Mon, 18 Sep 2023 18:10:12 GMT, Daniel Jeliński wrote:
>> Please review this patch that makes java.dll load shell32.dll earlier.
>> Delay-loading requires some additional code (delayimp.lib), and offers no
>> benefits since we always load shell32 during JVM startup.
>>
>> Other than removing
On Mon, 18 Sep 2023 18:10:12 GMT, Daniel Jeliński wrote:
>> Please review this patch that makes java.dll load shell32.dll earlier.
>> Delay-loading requires some additional code (delayimp.lib), and offers no
>> benefits since we always load shell32 during JVM startup.
>>
>> Other than removing
On Mon, 18 Sep 2023 18:10:12 GMT, Daniel Jeliński wrote:
>> Please review this patch that makes java.dll load shell32.dll earlier.
>> Delay-loading requires some additional code (delayimp.lib), and offers no
>> benefits since we always load shell32 during JVM startup.
>>
>> Other than removing
On Mon, 18 Sep 2023 18:05:19 GMT, Daniel Jeliński wrote:
> Hmm, indeed `VER_PLATFORM_WIN32_WINDOWS` was not used... Removed now. Was
> that the `define` you were referring to?
Err, sorry, I was talking about the `_WIN32_NT` define, but that was actually
already removed in
https://github.com/o
> Please review this patch that makes java.dll load shell32.dll earlier.
> Delay-loading requires some additional code (delayimp.lib), and offers no
> benefits since we always load shell32 during JVM startup.
>
> Other than removing the delayload clause, the patch also cleans up the
> `getHomeF
On Mon, 18 Sep 2023 14:44:13 GMT, Daniel Jeliński wrote:
> Please review this patch that makes java.dll load shell32.dll earlier.
> Delay-loading requires some additional code (delayimp.lib), and offers no
> benefits since we always load shell32 during JVM startup.
>
> Other than removing the
On Mon, 18 Sep 2023 16:05:37 GMT, Daniel Jeliński wrote:
> based on the above, I believe we can ignore WinXP compatibility here.
I tend to agree.
> During compilation we enable APIs from Win8:
This is interesting. I think that means the `define` at the start of
src/java.base/windows/native/li
On Mon, 18 Sep 2023 14:44:13 GMT, Daniel Jeliński wrote:
> Please review this patch that makes java.dll load shell32.dll earlier.
> Delay-loading requires some additional code (delayimp.lib), and offers no
> benefits since we always load shell32 during JVM startup.
>
> Other than removing the
On Mon, 18 Sep 2023 14:44:13 GMT, Daniel Jeliński wrote:
> Please review this patch that makes java.dll load shell32.dll earlier.
> Delay-loading requires some additional code (delayimp.lib), and offers no
> benefits since we always load shell32 during JVM startup.
>
> Other than removing the
Please review this patch that makes java.dll load shell32.dll earlier.
Delay-loading requires some additional code (delayimp.lib), and offers no
benefits since we always load shell32 during JVM startup.
Other than removing the delayload clause, the patch also cleans up the
`getHomeFromShell32`
17 matches
Mail list logo
