Re: RFR: 8317601: Windows build on WSL broken after JDK-8317340 [v2]

2023-10-06 Thread Erik Joelsson
On Fri, 6 Oct 2023 13:06:33 GMT, Andrew Leonard wrote: >> [JDK-8317340](https://bugs.openjdk.org/browse/JDK-8317340) introduced >> -pathmap'ing of VS_INCLUDE paths to enable reproducible Windows builds that >> are not dependent on the Visual Studio tooling install location. This >> however

Re: RFR: 8317601: Windows build on WSL broken after JDK-8317340 [v2]

2023-10-06 Thread Erik Joelsson
On Fri, 6 Oct 2023 13:01:03 GMT, Andrew Leonard wrote: >> [JDK-8317340](https://bugs.openjdk.org/browse/JDK-8317340) introduced >> -pathmap'ing of VS_INCLUDE paths to enable reproducible Windows builds that >> are not dependent on the Visual Studio tooling install location. This >> however

Re: RFR: 8317601: Windows build on WSL broken after JDK-8317340 [v2]

2023-10-06 Thread Andrew Leonard
> [JDK-8317340](https://bugs.openjdk.org/browse/JDK-8317340) introduced > -pathmap'ing of VS_INCLUDE paths to enable reproducible Windows builds that > are not dependent on the Visual Studio tooling install location. This however > requires pathmap'ing the Windows long paths generated by the

Re: RFR: 8317601: Windows build on WSL broken after JDK-8317340 [v2]

2023-10-06 Thread Andrew Leonard
On Fri, 6 Oct 2023 12:56:17 GMT, Erik Joelsson wrote: > Could you add a comment on the new UTIL_FIXUP_WIN_LONG_PATH macro that it > only works in cygwin? Yes, good point. Added - PR Comment: https://git.openjdk.org/jdk/pull/16069#issuecomment-1750638935

Re: RFR: 8317601: Windows build on WSL broken after JDK-8317340

2023-10-06 Thread Erik Joelsson
On Fri, 6 Oct 2023 10:17:25 GMT, Andrew Leonard wrote: > [JDK-8317340](https://bugs.openjdk.org/browse/JDK-8317340) introduced > -pathmap'ing of VS_INCLUDE paths to enable reproducible Windows builds that > are not dependent on the Visual Studio tooling install location. This however >

Re: RFR: 8317601: Windows build on WSL broken after JDK-8317340

2023-10-06 Thread Daniel JeliƄski
On Fri, 6 Oct 2023 10:17:25 GMT, Andrew Leonard wrote: > [JDK-8317340](https://bugs.openjdk.org/browse/JDK-8317340) introduced > -pathmap'ing of VS_INCLUDE paths to enable reproducible Windows builds that > are not dependent on the Visual Studio tooling install location. This however >

Re: RFR: 8317601: Windows build on WSL broken after JDK-8317340

2023-10-06 Thread Andrew Leonard
On Fri, 6 Oct 2023 10:17:25 GMT, Andrew Leonard wrote: > [JDK-8317340](https://bugs.openjdk.org/browse/JDK-8317340) introduced > -pathmap'ing of VS_INCLUDE paths to enable reproducible Windows builds that > are not dependent on the Visual Studio tooling install location. This however >

RFR: 8317601: Windows build on WSL broken after JDK-8317340

2023-10-06 Thread Andrew Leonard
[JDK-8317340](https://bugs.openjdk.org/browse/JDK-8317340) introduced -pathmap'ing of VS_INCLUDE paths to enable reproducible Windows builds that are not dependent on the Visual Studio tooling install location. This however requires pathmap'ing the Windows long paths generated by the compiler,