Re: RFR: 8319165: hsdis binutils: warns on empty string as option string [v2]

2023-11-02 Thread Robbin Ehn
On Thu, 2 Nov 2023 09:22:55 GMT, Andrew Haley wrote: >> Robbin Ehn has updated the pull request incrementally with one additional >> commit since the last revision: >> >> More clear > > src/utils/hsdis/binutils/hsdis-binutils.c line 341: > >> 339: /* On some

Re: RFR: 8319165: hsdis binutils: warns on empty string as option string [v3]

2023-11-02 Thread Robbin Ehn
> Hi, please consider. > > insn_options[0] is set to empty string if there is no options (NULL or empty > strings). > Checking it for empty string should cover both cases, caller option is NULL > or caller option is empty string. > > Tested hsdis no longer gives me the warning. Robbin Ehn has

Re: RFR: 8319165: hsdis binutils: warns on empty string as option string [v2]

2023-11-02 Thread Robbin Ehn
On Wed, 1 Nov 2023 11:52:20 GMT, Robbin Ehn wrote: >> Hi, please consider. >> >> insn_options[0] is set to empty string if there is no options (NULL or empty >> strings). >> Checking it for empty string should cover both cases, caller option is NULL >> or caller option is empty string. >> >>

Re: RFR: 8319165: hsdis binutils: warns on empty string as option string [v2]

2023-11-02 Thread Andrew Haley
On Wed, 1 Nov 2023 11:52:20 GMT, Robbin Ehn wrote: >> Hi, please consider. >> >> insn_options[0] is set to empty string if there is no options (NULL or empty >> strings). >> Checking it for empty string should cover both cases, caller option is NULL >> or caller option is empty string. >> >>

Re: RFR: 8319165: hsdis binutils: warns on empty string as option string [v2]

2023-11-02 Thread Jesper Wilhelmsson
On Wed, 1 Nov 2023 11:52:20 GMT, Robbin Ehn wrote: >> Hi, please consider. >> >> insn_options[0] is set to empty string if there is no options (NULL or empty >> strings). >> Checking it for empty string should cover both cases, caller option is NULL >> or caller option is empty string. >> >>

Re: RFR: 8319165: hsdis binutils: warns on empty string as option string [v2]

2023-11-01 Thread Hamlin Li
On Wed, 1 Nov 2023 11:52:20 GMT, Robbin Ehn wrote: >> Hi, please consider. >> >> insn_options[0] is set to empty string if there is no options (NULL or empty >> strings). >> Checking it for empty string should cover both cases, caller option is NULL >> or caller option is empty string. >> >>

Re: RFR: 8319165: hsdis binutils: warns on empty string as option string [v2]

2023-11-01 Thread Robbin Ehn
> Hi, please consider. > > insn_options[0] is set to empty string if there is no options (NULL or empty > strings). > Checking it for empty string should cover both cases, caller option is NULL > or caller option is empty string. > > Tested hsdis no longer gives me the warning. Robbin Ehn has

Re: RFR: 8319165: hsdis binutils: warns on empty string as option string

2023-11-01 Thread Robbin Ehn
On Tue, 31 Oct 2023 14:21:02 GMT, Hamlin Li wrote: >> Hi, please consider. >> >> insn_options[0] is set to empty string if there is no options (NULL or empty >> strings). >> Checking it for empty string should cover both cases, caller option is NULL >> or caller option is empty string. >> >>

Re: RFR: 8319165: hsdis binutils: warns on empty string as option string

2023-10-31 Thread Hamlin Li
On Tue, 31 Oct 2023 13:05:44 GMT, Robbin Ehn wrote: > Hi, please consider. > > insn_options[0] is set to empty string if there is no options (NULL or empty > strings). > Checking it for empty string should cover both cases, caller option is NULL > or caller option is empty string. > > Tested

Re: RFR: 8319165: hsdis binutils: warns on empty string as option string

2023-10-31 Thread Andrew Haley
On Tue, 31 Oct 2023 14:42:22 GMT, Robbin Ehn wrote: >> The parse_caller_options handles the NULL case, so I forgot about the early >> bailout. >> >> for (p = caller_options; p != NULL; ) { >> } >> *iop = '\0'; >> >> >> Sorry. > > Sorry again, long day: > > struct hsdis_app_data

Re: RFR: 8319165: hsdis binutils: warns on empty string as option string

2023-10-31 Thread Robbin Ehn
On Tue, 31 Oct 2023 14:30:26 GMT, Robbin Ehn wrote: >> src/utils/hsdis/binutils/hsdis-binutils.c line 340: >> >>> 338: native_bfd, >>> 339: /* On some archs we get warnings, if >>> we pass empty options */ >>> 340:

Re: RFR: 8319165: hsdis binutils: warns on empty string as option string

2023-10-31 Thread Robbin Ehn
On Tue, 31 Oct 2023 14:30:26 GMT, Robbin Ehn wrote: >> src/utils/hsdis/binutils/hsdis-binutils.c line 340: >> >>> 338: native_bfd, >>> 339: /* On some archs we get warnings, if >>> we pass empty options */ >>> 340:

Re: RFR: 8319165: hsdis binutils: warns on empty string as option string

2023-10-31 Thread Robbin Ehn
On Tue, 31 Oct 2023 14:15:16 GMT, Andrew Haley wrote: >> Hi, please consider. >> >> insn_options[0] is set to empty string if there is no options (NULL or empty >> strings). >> Checking it for empty string should cover both cases, caller option is NULL >> or caller option is empty string. >>

Re: RFR: 8319165: hsdis binutils: warns on empty string as option string

2023-10-31 Thread Andrew Haley
On Tue, 31 Oct 2023 13:05:44 GMT, Robbin Ehn wrote: > Hi, please consider. > > insn_options[0] is set to empty string if there is no options (NULL or empty > strings). > Checking it for empty string should cover both cases, caller option is NULL > or caller option is empty string. > > Tested

RFR: 8319165: hsdis binutils: warns on empty string as option string

2023-10-31 Thread Robbin Ehn
Hi, please consider. insn_options[0] is set to empty string if there is no options (NULL or empty strings). Checking it for empty string should cover both cases, caller option is NULL or caller option is empty string. Tested hsdis no longer gives me the warning. - Commit