Re: RFR: 8319165: hsdis binutils: warns on empty string as option string [v2]

2023-11-02 Thread Robbin Ehn
On Thu, 2 Nov 2023 09:22:55 GMT, Andrew Haley wrote: >> Robbin Ehn has updated the pull request incrementally with one additional >> commit since the last revision: >> >> More clear > > src/utils/hsdis/binutils/hsdis-binutils.c line 341: > >> 339: /* On some

Re: RFR: 8319165: hsdis binutils: warns on empty string as option string [v2]

2023-11-02 Thread Robbin Ehn
On Wed, 1 Nov 2023 11:52:20 GMT, Robbin Ehn wrote: >> Hi, please consider. >> >> insn_options[0] is set to empty string if there is no options (NULL or empty >> strings). >> Checking it for empty string should cover both cases, caller option is NULL >> or caller option is empty string. >> >>

Re: RFR: 8319165: hsdis binutils: warns on empty string as option string [v2]

2023-11-02 Thread Andrew Haley
On Wed, 1 Nov 2023 11:52:20 GMT, Robbin Ehn wrote: >> Hi, please consider. >> >> insn_options[0] is set to empty string if there is no options (NULL or empty >> strings). >> Checking it for empty string should cover both cases, caller option is NULL >> or caller option is empty string. >> >>

Re: RFR: 8319165: hsdis binutils: warns on empty string as option string [v2]

2023-11-02 Thread Jesper Wilhelmsson
On Wed, 1 Nov 2023 11:52:20 GMT, Robbin Ehn wrote: >> Hi, please consider. >> >> insn_options[0] is set to empty string if there is no options (NULL or empty >> strings). >> Checking it for empty string should cover both cases, caller option is NULL >> or caller option is empty string. >> >>

Re: RFR: 8319165: hsdis binutils: warns on empty string as option string [v2]

2023-11-01 Thread Hamlin Li
On Wed, 1 Nov 2023 11:52:20 GMT, Robbin Ehn wrote: >> Hi, please consider. >> >> insn_options[0] is set to empty string if there is no options (NULL or empty >> strings). >> Checking it for empty string should cover both cases, caller option is NULL >> or caller option is empty string. >> >>

Re: RFR: 8319165: hsdis binutils: warns on empty string as option string [v2]

2023-11-01 Thread Robbin Ehn
> Hi, please consider. > > insn_options[0] is set to empty string if there is no options (NULL or empty > strings). > Checking it for empty string should cover both cases, caller option is NULL > or caller option is empty string. > > Tested hsdis no longer gives me the warning. Robbin Ehn has