Re: RFR: 8324834: Use _LARGE_FILES on AIX [v2]

2024-02-01 Thread Matthias Baesken
On Thu, 1 Feb 2024 09:04:47 GMT, Magnus Ihse Bursie wrote: > I added a compile-time check that hotspot on AIX is indeed compiled with > _LARGE_FILES. > > @MBaesken Are you happy with this PR now? Thanks for adding this, I approved the PR . - PR Comment:

Re: RFR: 8324834: Use _LARGE_FILES on AIX [v2]

2024-02-01 Thread Magnus Ihse Bursie
On Tue, 30 Jan 2024 12:25:47 GMT, Magnus Ihse Bursie wrote: >> In the same spirit as >> [JDK-8318696](https://bugs.openjdk.org/browse/JDK-8318696), we should adapt >> the AIX-specific code in hotspot so it uses the well-defined posix `` >> functions, instead of `64`. By setting the define

Re: RFR: 8324834: Use _LARGE_FILES on AIX [v2]

2024-02-01 Thread Matthias Baesken
On Tue, 30 Jan 2024 12:25:47 GMT, Magnus Ihse Bursie wrote: >> In the same spirit as >> [JDK-8318696](https://bugs.openjdk.org/browse/JDK-8318696), we should adapt >> the AIX-specific code in hotspot so it uses the well-defined posix `` >> functions, instead of `64`. By setting the define

Re: RFR: 8324834: Use _LARGE_FILES on AIX [v3]

2024-02-01 Thread Magnus Ihse Bursie
> In the same spirit as > [JDK-8318696](https://bugs.openjdk.org/browse/JDK-8318696), we should adapt > the AIX-specific code in hotspot so it uses the well-defined posix `` > functions, instead of `64`. By setting the define _LARGE_FILES, this > will make `` behave as `64`, just as

Re: RFR: 8324834: Use _LARGE_FILES on AIX [v2]

2024-01-31 Thread Matthias Baesken
On Wed, 31 Jan 2024 08:49:58 GMT, Magnus Ihse Bursie wrote: > I suspect this worry of yours were more directed at the change for the JDK Yes it is more a general worry, not especially related to Hotspot. We could also add some kind of check (e.g. static assert or configure check) to address

Re: RFR: 8324834: Use _LARGE_FILES on AIX [v2]

2024-01-31 Thread Magnus Ihse Bursie
On Tue, 30 Jan 2024 12:25:47 GMT, Magnus Ihse Bursie wrote: >> In the same spirit as >> [JDK-8318696](https://bugs.openjdk.org/browse/JDK-8318696), we should adapt >> the AIX-specific code in hotspot so it uses the well-defined posix `` >> functions, instead of `64`. By setting the define

Re: RFR: 8324834: Use _LARGE_FILES on AIX

2024-01-31 Thread Matthias Baesken
On Mon, 29 Jan 2024 13:13:44 GMT, Matthias Baesken wrote: >> In the same spirit as >> [JDK-8318696](https://bugs.openjdk.org/browse/JDK-8318696), we should adapt >> the AIX-specific code in hotspot so it uses the well-defined posix `` >> functions, instead of `64`. By setting the define

Re: RFR: 8324834: Use _LARGE_FILES on AIX

2024-01-30 Thread Christoph Langer
On Mon, 29 Jan 2024 13:13:44 GMT, Matthias Baesken wrote: >> In the same spirit as >> [JDK-8318696](https://bugs.openjdk.org/browse/JDK-8318696), we should adapt >> the AIX-specific code in hotspot so it uses the well-defined posix `` >> functions, instead of `64`. By setting the define

Re: RFR: 8324834: Use _LARGE_FILES on AIX [v2]

2024-01-30 Thread Magnus Ihse Bursie
> In the same spirit as > [JDK-8318696](https://bugs.openjdk.org/browse/JDK-8318696), we should adapt > the AIX-specific code in hotspot so it uses the well-defined posix `` > functions, instead of `64`. By setting the define _LARGE_FILES, this > will make `` behave as `64`, just as

Re: RFR: 8324834: Use _LARGE_FILES on AIX

2024-01-30 Thread Magnus Ihse Bursie
On Mon, 29 Jan 2024 13:51:29 GMT, Joachim Kern wrote: >> In the same spirit as >> [JDK-8318696](https://bugs.openjdk.org/browse/JDK-8318696), we should adapt >> the AIX-specific code in hotspot so it uses the well-defined posix `` >> functions, instead of `64`. By setting the define

Re: RFR: 8324834: Use _LARGE_FILES on AIX

2024-01-30 Thread Magnus Ihse Bursie
On Mon, 29 Jan 2024 13:13:44 GMT, Matthias Baesken wrote: >> In the same spirit as >> [JDK-8318696](https://bugs.openjdk.org/browse/JDK-8318696), we should adapt >> the AIX-specific code in hotspot so it uses the well-defined posix `` >> functions, instead of `64`. By setting the define

Re: RFR: 8324834: Use _LARGE_FILES on AIX

2024-01-29 Thread Christoph Langer
On Mon, 29 Jan 2024 12:41:29 GMT, Julian Waters wrote: >> In the same spirit as >> [JDK-8318696](https://bugs.openjdk.org/browse/JDK-8318696), we should adapt >> the AIX-specific code in hotspot so it uses the well-defined posix `` >> functions, instead of `64`. By setting the define

Re: RFR: 8324834: Use _LARGE_FILES on AIX

2024-01-29 Thread Joachim Kern
On Mon, 29 Jan 2024 11:44:34 GMT, Magnus Ihse Bursie wrote: > In the same spirit as > [JDK-8318696](https://bugs.openjdk.org/browse/JDK-8318696), we should adapt > the AIX-specific code in hotspot so it uses the well-defined posix `` > functions, instead of `64`. By setting the define

Re: RFR: 8324834: Use _LARGE_FILES on AIX

2024-01-29 Thread Erik Joelsson
On Mon, 29 Jan 2024 11:44:34 GMT, Magnus Ihse Bursie wrote: > In the same spirit as > [JDK-8318696](https://bugs.openjdk.org/browse/JDK-8318696), we should adapt > the AIX-specific code in hotspot so it uses the well-defined posix `` > functions, instead of `64`. By setting the define

Re: RFR: 8324834: Use _LARGE_FILES on AIX

2024-01-29 Thread Matthias Baesken
On Mon, 29 Jan 2024 11:44:34 GMT, Magnus Ihse Bursie wrote: > In the same spirit as > [JDK-8318696](https://bugs.openjdk.org/browse/JDK-8318696), we should adapt > the AIX-specific code in hotspot so it uses the well-defined posix `` > functions, instead of `64`. By setting the define

Re: RFR: 8324834: Use _LARGE_FILES on AIX

2024-01-29 Thread Julian Waters
On Mon, 29 Jan 2024 11:44:34 GMT, Magnus Ihse Bursie wrote: > In the same spirit as > [JDK-8318696](https://bugs.openjdk.org/browse/JDK-8318696), we should adapt > the AIX-specific code in hotspot so it uses the well-defined posix `` > functions, instead of `64`. By setting the define

RFR: 8324834: Use _LARGE_FILES on AIX

2024-01-29 Thread Magnus Ihse Bursie
In the same spirit as [JDK-8318696](https://bugs.openjdk.org/browse/JDK-8318696), we should adapt the AIX-specific code in hotspot so it uses the well-defined posix `` functions, instead of `64`. By setting the define _LARGE_FILES, this will make `` behave as `64`, just as _FILE_OFFSET_BITS=64