Re: RFR: 8325444: GHA: JDK-8325194 causes a regression

2024-02-08 Thread Magnus Ihse Bursie
On Wed, 7 Feb 2024 19:50:51 GMT, Christoph Langer wrote: > The > [change](https://github.com/openjdk/jdk/commit/d1c82156ba6ede4b798ac15f935289cfcc99d1a0) > for [JDK-8325194](https://bugs.openjdk.org/browse/JDK-8325194) broke > get-jtreg because the way to determine the build jdk was not

Re: RFR: 8325444: GHA: JDK-8325194 causes a regression

2024-02-08 Thread Christoph Langer
On Thu, 8 Feb 2024 07:31:15 GMT, Magnus Ihse Bursie wrote: >> The >> [change](https://github.com/openjdk/jdk/commit/d1c82156ba6ede4b798ac15f935289cfcc99d1a0) >> for [JDK-8325194](https://bugs.openjdk.org/browse/JDK-8325194) broke >> get-jtreg because the way to determine the build jdk was not

Re: RFR: 8325444: GHA: JDK-8325194 causes a regression

2024-02-08 Thread George Adams
On Wed, 7 Feb 2024 19:50:51 GMT, Christoph Langer wrote: > The > [change](https://github.com/openjdk/jdk/commit/d1c82156ba6ede4b798ac15f935289cfcc99d1a0) > for [JDK-8325194](https://bugs.openjdk.org/browse/JDK-8325194) broke > get-jtreg because the way to determine the build jdk was not

Re: RFR: 8325444: GHA: JDK-8325194 causes a regression

2024-02-08 Thread Aleksey Shipilev
On Wed, 7 Feb 2024 19:50:51 GMT, Christoph Langer wrote: > The > [change](https://github.com/openjdk/jdk/commit/d1c82156ba6ede4b798ac15f935289cfcc99d1a0) > for [JDK-8325194](https://bugs.openjdk.org/browse/JDK-8325194) broke > get-jtreg because the way to determine the build jdk was not

Re: RFR: 8325444: GHA: JDK-8325194 causes a regression

2024-02-08 Thread Christoph Langer
On Thu, 8 Feb 2024 07:40:50 GMT, Christoph Langer wrote: > > I don't like this approach. There must be better ways to achieve this, like > > inputting the correct value as input to the action, or setting it as a > > global gh variable. Where does even the `$JAVA_HOME_17_arm64` come from? Is >

Re: RFR: 8325444: GHA: JDK-8325194 causes a regression

2024-02-08 Thread Aleksey Shipilev
On Wed, 7 Feb 2024 19:50:51 GMT, Christoph Langer wrote: > The > [change](https://github.com/openjdk/jdk/commit/d1c82156ba6ede4b798ac15f935289cfcc99d1a0) > for [JDK-8325194](https://bugs.openjdk.org/browse/JDK-8325194) broke > get-jtreg because the way to determine the build jdk was not

Re: RFR: 8325444: GHA: JDK-8325194 causes a regression

2024-02-07 Thread Christoph Langer
On Thu, 8 Feb 2024 07:31:15 GMT, Magnus Ihse Bursie wrote: > I don't like this approach. There must be better ways to achieve this, like > inputting the correct value as input to the action, or setting it as a global > gh variable. Where does even the `$JAVA_HOME_17_arm64` come from? Is it >

Re: RFR: 8325444: GHA: JDK-8325194 causes a regression

2024-02-07 Thread Magnus Ihse Bursie
On Wed, 7 Feb 2024 19:50:51 GMT, Christoph Langer wrote: > The > [change](https://github.com/openjdk/jdk/commit/d1c82156ba6ede4b798ac15f935289cfcc99d1a0) > for [JDK-8325194](https://bugs.openjdk.org/browse/JDK-8325194) broke > get-jtreg because the way to determine the build jdk was not

RFR: 8325444: GHA: JDK-8325194 causes a regression

2024-02-07 Thread Christoph Langer
The [change](https://github.com/openjdk/jdk/commit/d1c82156ba6ede4b798ac15f935289cfcc99d1a0) for [JDK-8325194](https://bugs.openjdk.org/browse/JDK-8325194) broke get-jtreg because the macro to determine the build jdk was not correct. I fix this by reverting to the originally proposed way to

Re: RFR: 8325444: GHA: JDK-8325194 causes a regression

2024-02-07 Thread George Adams
On Wed, 7 Feb 2024 19:50:51 GMT, Christoph Langer wrote: > The > [change](https://github.com/openjdk/jdk/commit/d1c82156ba6ede4b798ac15f935289cfcc99d1a0) > for [JDK-8325194](https://bugs.openjdk.org/browse/JDK-8325194) broke > get-jtreg because the macro to determine the build jdk was not