Re: RFR: 8326509: Clean up JNIEXPORT in Hotspot after JDK-8017234 [v4]

2024-02-27 Thread Magnus Ihse Bursie
On Tue, 27 Feb 2024 11:01:03 GMT, Magnus Ihse Bursie wrote: >> Once [JDK-8017234](https://bugs.openjdk.org/browse/JDK-8017234) has been >> integrated, it is possible to do some cleanup. The goal of >> [JDK-8017234](https://bugs.openjdk.org/browse/JDK-8017234) was to not change >> any

Re: RFR: 8326509: Clean up JNIEXPORT in Hotspot after JDK-8017234 [v4]

2024-02-27 Thread Andrew Dinn
On Tue, 27 Feb 2024 15:35:56 GMT, Ludovic Henry wrote: >> It does not sound like anyone object to the removal of `JNIEXPORT` for >> `das1`, then. >> >> Or should I just remove the entire function, if it serves no purpose that >> any current maintainers know or care about? > > You can probably

Re: RFR: 8326509: Clean up JNIEXPORT in Hotspot after JDK-8017234 [v4]

2024-02-27 Thread Ludovic Henry
On Mon, 26 Feb 2024 20:07:35 GMT, Magnus Ihse Bursie wrote: >> I use `das` every day. In contrast, I don't know what `das1` is for. > > It does not sound like anyone object to the removal of `JNIEXPORT` for > `das1`, then. > > Or should I just remove the entire function, if it serves no

Re: RFR: 8326509: Clean up JNIEXPORT in Hotspot after JDK-8017234 [v4]

2024-02-27 Thread Magnus Ihse Bursie
> Once [JDK-8017234](https://bugs.openjdk.org/browse/JDK-8017234) has been > integrated, it is possible to do some cleanup. The goal of > [JDK-8017234](https://bugs.openjdk.org/browse/JDK-8017234) was to not change > any behavior, even if that behavior seemed odd. > > Now let's try to fix