On Tue, 27 Feb 2024 13:44:15 GMT, Andrew Leonard wrote:
>> Adds Linux -fdebug-prefix-map'ing for SUPPORT_OUTPUTDIR and
>> HOTSPOT_OUTPUTDIR when absolute paths are not allowed in the binaries, thus
>> making the building of a JDK identically reproducible from different build
>> directories.
>
On Tue, 27 Feb 2024 13:44:15 GMT, Andrew Leonard wrote:
>> Adds Linux -fdebug-prefix-map'ing for SUPPORT_OUTPUTDIR and
>> HOTSPOT_OUTPUTDIR when absolute paths are not allowed in the binaries, thus
>> making the building of a JDK identically reproducible from different build
>> directories.
>
> Adds Linux -fdebug-prefix-map'ing for SUPPORT_OUTPUTDIR and HOTSPOT_OUTPUTDIR
> when absolute paths are not allowed in the binaries, thus making the building
> of a JDK identically reproducible from different build directories.
Andrew Leonard has updated the pull request incrementally with
On Tue, 27 Feb 2024 11:53:03 GMT, Andrew Leonard wrote:
>> Adds Linux -fdebug-prefix-map'ing for SUPPORT_OUTPUTDIR and
>> HOTSPOT_OUTPUTDIR when absolute paths are not allowed in the binaries, thus
>> making the building of a JDK identically reproducible from different build
>> directories.
>
On Tue, 27 Feb 2024 11:50:35 GMT, Andrew Leonard wrote:
>> Also, this mapping business is getting really convoluted. :-( I did not like
>> it as it was, and this patch makes it even worse. I think we need to rewrite
>> this to create some kind of dict/map, and then iterate over the map and
>>
> Adds Linux -fdebug-prefix-map'ing for SUPPORT_OUTPUTDIR and HOTSPOT_OUTPUTDIR
> when absolute paths are not allowed in the binaries, thus making the building
> of a JDK identically reproducible from different build directories.
Andrew Leonard has updated the pull request incrementally with
On Tue, 27 Feb 2024 10:35:20 GMT, Magnus Ihse Bursie wrote:
>> It seems correct to include the output dir in the remapping, but I have two
>> objections/questions to the way you are doing it.
>> 1) Why not just use OUTPUTDIR instead of the two specialized subdirs? That
>> is simpler, more
On Tue, 27 Feb 2024 10:59:54 GMT, Andrew Leonard wrote:
>> Also, this mapping business is getting really convoluted. :-( I did not like
>> it as it was, and this patch makes it even worse. I think we need to rewrite
>> this to create some kind of dict/map, and then iterate over the map and
>>
On Tue, 27 Feb 2024 10:35:20 GMT, Magnus Ihse Bursie wrote:
>> It seems correct to include the output dir in the remapping, but I have two
>> objections/questions to the way you are doing it.
>> 1) Why not just use OUTPUTDIR instead of the two specialized subdirs? That
>> is simpler, more
On Tue, 27 Feb 2024 10:32:24 GMT, Magnus Ihse Bursie wrote:
>>> Oh you are right, we should always add the OUTPUTDIR to both maps
>>> regardless of if it's internal to the WORKSPACE_ROOT or not. Paths relative
>>> to the OUTPUTDIR should be stable across builds in different output
>>>
On Tue, 27 Feb 2024 08:19:11 GMT, Andrew Leonard wrote:
>>> I have not thought this fully through, but just throwing out a question:
>>> would this work even if one build directory were inside the workspace root,
>>> and the other not?
>>
>> Yes, I have tested that scenario as well, and does
On Tue, 27 Feb 2024 08:13:07 GMT, Andrew Leonard wrote:
>> Oh you are right, we should always add the OUTPUTDIR to both maps regardless
>> of if it's internal to the WORKSPACE_ROOT or not. Paths relative to the
>> OUTPUTDIR should be stable across builds in different output directories,
>>
On Mon, 26 Feb 2024 22:05:34 GMT, Erik Joelsson wrote:
>> I have not thought this fully through, but just throwing out a question:
>> would this work even if one build directory were inside the workspace root,
>> and the other not?
>
> Oh you are right, we should always add the OUTPUTDIR to
On Mon, 26 Feb 2024 21:20:25 GMT, Magnus Ihse Bursie wrote:
>> make/autoconf/flags-cflags.m4 line 126:
>>
>>> 124: DEBUG_PREFIX_MAP_GCC_INCLUDE_PATHS
>>> 125: DEBUG_PREFIX_CFLAGS="$DEBUG_PREFIX_CFLAGS
>>> -fdebug-prefix-map=\$(SUPPORT_OUTPUTDIR)/="
>>> 126:
On Mon, 26 Feb 2024 19:26:33 GMT, Erik Joelsson wrote:
>> Adds Linux -fdebug-prefix-map'ing for SUPPORT_OUTPUTDIR and
>> HOTSPOT_OUTPUTDIR when absolute paths are not allowed in the binaries, thus
>> making the building of a JDK identically reproducible from different build
>> directories.
>
On Mon, 26 Feb 2024 16:00:42 GMT, Andrew Leonard wrote:
> Adds Linux -fdebug-prefix-map'ing for SUPPORT_OUTPUTDIR and HOTSPOT_OUTPUTDIR
> when absolute paths are not allowed in the binaries, thus making the building
> of a JDK identically reproducible from different build directories.
On Mon, 26 Feb 2024 16:00:42 GMT, Andrew Leonard wrote:
> Adds Linux -fdebug-prefix-map'ing for SUPPORT_OUTPUTDIR and HOTSPOT_OUTPUTDIR
> when absolute paths are not allowed in the binaries, thus making the building
> of a JDK identically reproducible from different build directories.
Tested
Adds Linux -fdebug-prefix-map'ing for SUPPORT_OUTPUTDIR and HOTSPOT_OUTPUTDIR
when absolute paths are not allowed in the binaries, thus making the building
of a JDK identically reproducible from different build directories.
-
Commit messages:
- 8326685: Linux builds not
18 matches
Mail list logo
