Re: RFR: 8326685: Linux builds not reproducible if two builds configured in different build folders [v2]

2024-02-27 Thread Magnus Ihse Bursie
On Tue, 27 Feb 2024 11:53:03 GMT, Andrew Leonard wrote: >> Adds Linux -fdebug-prefix-map'ing for SUPPORT_OUTPUTDIR and >> HOTSPOT_OUTPUTDIR when absolute paths are not allowed in the binaries, thus >> making the building of a JDK identically reproducible from different build >> directories. >

Re: RFR: 8326685: Linux builds not reproducible if two builds configured in different build folders [v2]

2024-02-27 Thread Magnus Ihse Bursie
On Tue, 27 Feb 2024 11:50:35 GMT, Andrew Leonard wrote: >> Also, this mapping business is getting really convoluted. :-( I did not like >> it as it was, and this patch makes it even worse. I think we need to rewrite >> this to create some kind of dict/map, and then iterate over the map and >>

Re: RFR: 8326685: Linux builds not reproducible if two builds configured in different build folders [v2]

2024-02-27 Thread Andrew Leonard
> Adds Linux -fdebug-prefix-map'ing for SUPPORT_OUTPUTDIR and HOTSPOT_OUTPUTDIR > when absolute paths are not allowed in the binaries, thus making the building > of a JDK identically reproducible from different build directories. Andrew Leonard has updated the pull request incrementally with

Re: RFR: 8326685: Linux builds not reproducible if two builds configured in different build folders [v2]

2024-02-27 Thread Andrew Leonard
On Tue, 27 Feb 2024 10:35:20 GMT, Magnus Ihse Bursie wrote: >> It seems correct to include the output dir in the remapping, but I have two >> objections/questions to the way you are doing it. >> 1) Why not just use OUTPUTDIR instead of the two specialized subdirs? That >> is simpler, more