On Wed, 12 Jun 2024 14:04:41 GMT, Sonia Zaldana Calles
wrote:
>> Hi all,
>>
>> This PR addresses [8333685](https://bugs.openjdk.org/browse/JDK-8333685).
>>
>> I have added the following enhancements:
>> - Removed uses of `fgrep` and `egrep` with `grep -F` and `grep -E`
>> respectively.
On Wed, 12 Jun 2024 14:04:41 GMT, Sonia Zaldana Calles
wrote:
>> Hi all,
>>
>> This PR addresses [8333685](https://bugs.openjdk.org/browse/JDK-8333685).
>>
>> I have added the following enhancements:
>> - Removed uses of `fgrep` and `egrep` with `grep -F` and `grep -E`
>> respectively.
On Wed, 12 Jun 2024 06:46:39 GMT, Thomas Stuefe wrote:
> A lot better, but not fully there yet. Can you make it so that it also picks
> up SAP's copyrights when they specify multiple years? They are weird in that
> the last year does not have a trailing comma, e.g.:
>
> ```
> * Copyright (c)
> Hi all,
>
> This PR addresses [8333685](https://bugs.openjdk.org/browse/JDK-8333685).
>
> I have added the following enhancements:
> - Removed uses of `fgrep` and `egrep` with `grep -F` and `grep -E`
> respectively.
> - Altered default behaviour to limit the processed changesets to those
On Wed, 12 Jun 2024 06:43:15 GMT, Thomas Stuefe wrote:
>> Sonia Zaldana Calles has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> Fixing optional group to work with bsd as well
>
> make/scripts/update_copyright_year.sh line 70:
>
>> 68:
On Tue, 11 Jun 2024 13:34:24 GMT, Sonia Zaldana Calles
wrote:
>> Hi all,
>>
>> This PR addresses [8333685](https://bugs.openjdk.org/browse/JDK-8333685).
>>
>> I have added the following enhancements:
>> - Removed uses of `fgrep` and `egrep` with `grep -F` and `grep -E`
>> respectively.
On Tue, 11 Jun 2024 13:34:24 GMT, Sonia Zaldana Calles
wrote:
>> Hi all,
>>
>> This PR addresses [8333685](https://bugs.openjdk.org/browse/JDK-8333685).
>>
>> I have added the following enhancements:
>> - Removed uses of `fgrep` and `egrep` with `grep -F` and `grep -E`
>> respectively.
On Tue, 11 Jun 2024 13:19:48 GMT, Thomas Stuefe wrote:
>> Opinion: while it's good to see improvements to the existent script, since
>> JEP 330, we can now conveniently implement a similar script in Java. That'll
>> also automatically take care of OS specifics.
>
>> Opinion: while it's good to
> Hi all,
>
> This PR addresses [8333685](https://bugs.openjdk.org/browse/JDK-8333685).
>
> I have added the following enhancements:
> - Removed uses of `fgrep` and `egrep` with `grep -F` and `grep -E`
> respectively.
> - Altered default behaviour to limit the processed changesets to those
On Tue, 11 Jun 2024 13:12:48 GMT, Pavel Rappo wrote:
> Opinion: while it's good to see improvements to the existent script, since
> JEP 330, we can now conveniently implement a similar script in Java. That'll
> also automatically take care of OS specifics.
Sure, but the script is here, it
On Fri, 7 Jun 2024 19:01:45 GMT, Sonia Zaldana Calles
wrote:
> Hi all,
>
> This PR addresses [8333685](https://bugs.openjdk.org/browse/JDK-8333685).
>
> I have added the following enhancements:
> - Removed uses of `fgrep` and `egrep` with `grep -F` and `grep -E`
> respectively.
> -
On Tue, 11 Jun 2024 12:32:59 GMT, Thomas Stuefe wrote:
> Tested on Linux, there it works.
>
> Note, IIRC, the original unpatched version also worked on MacOS. So, I think
> the original sed expressions were probably ok. Something about
> `(${copyright_symbol} )?` perhabs.
Mac has bsd sed by
On Fri, 7 Jun 2024 19:01:45 GMT, Sonia Zaldana Calles
wrote:
> Hi all,
>
> This PR addresses [8333685](https://bugs.openjdk.org/browse/JDK-8333685).
>
> I have added the following enhancements:
> - Removed uses of `fgrep` and `egrep` with `grep -F` and `grep -E`
> respectively.
> -
On Fri, 7 Jun 2024 19:01:45 GMT, Sonia Zaldana Calles
wrote:
> Hi all,
>
> This PR addresses [8333685](https://bugs.openjdk.org/browse/JDK-8333685).
>
> I have added the following enhancements:
> - Removed uses of `fgrep` and `egrep` with `grep -F` and `grep -E`
> respectively.
> -
Hi all,
This PR addresses [8333685](https://bugs.openjdk.org/browse/JDK-8333685).
I have added the following enhancements:
- Removed uses of `fgrep` and `egrep` with `grep -F` and `grep -E`
respectively.
- Altered default behaviour to limit the processed changesets to those in the
current
15 matches
Mail list logo