On Sun, 1 Sep 2024 21:35:02 GMT, Magnus Ihse Bursie wrote:
>> The build system code has unfortunately diverted in some places from the
>> conventions as described in
>> https://openjdk.org/groups/build/doc/code-conventions.html.
>>
>> Instead of trying to fix these when touching code nearby, I
On Mon, 2 Sep 2024 08:59:05 GMT, Magnus Ihse Bursie wrote:
> I've done that now, and it looks clean on all platforms. (With one exception:
> we include the vardeps files for jar files in jdk/demos -- historical
> reasons, I assume -- and they look slightly different; but they should not
> real
On Fri, 30 Aug 2024 20:23:29 GMT, Erik Joelsson wrote:
> also manually verified a few incremental build scenarios, including running
> tests.
I have tested changing:
* a hotspot file
* a JDK library native file
* a JDK module java file
and verified that the correct bits get rebuilt. I have als
On Sun, 1 Sep 2024 21:34:48 GMT, Magnus Ihse Bursie wrote:
>> make/MainSupport.gmk line 202:
>>
>>> 200: $(foreach i, 2 3 4 5 6 7 8, $(if $(strip $($i)),$(strip $1)_$(strip
>>> $($i)))$(NEWLINE))
>>> 201: $(if $(9), $(error Internal makefile error: Too many arguments to \
>>> 202: Dec
On Sun, 1 Sep 2024 21:35:02 GMT, Magnus Ihse Bursie wrote:
>> The build system code has unfortunately diverted in some places from the
>> conventions as described in
>> https://openjdk.org/groups/build/doc/code-conventions.html.
>>
>> Instead of trying to fix these when touching code nearby, I
On Fri, 30 Aug 2024 19:29:56 GMT, Erik Joelsson wrote:
>> Magnus Ihse Bursie has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> Fix bad change in BuildMicrobenchmarks
>
> make/MainSupport.gmk line 202:
>
>> 200: $(foreach i, 2 3 4 5 6 7
On Fri, 30 Aug 2024 20:19:46 GMT, Erik Joelsson wrote:
>> Magnus Ihse Bursie has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> Fix bad change in BuildMicrobenchmarks
>
> make/test/BuildMicrobenchmark.gmk line 71:
>
>> 69: # Need double \n
> The build system code has unfortunately diverted in some places from the
> conventions as described in
> https://openjdk.org/groups/build/doc/code-conventions.html.
>
> Instead of trying to fix these when touching code nearby, I'd like to make an
> effort to fix all issues at once and separat
