Re: RFR: JDK-8298405: Support Markdown in Documentation Comments [v18]

2024-02-06 Thread Jonathan Gibbons
On Wed, 7 Feb 2024 00:16:57 GMT, Jonathan Gibbons wrote: >> There are two cases that need consideration: >> 1. A tree that is not modified during the transformation, as in the test >> case here, so that all nodes should be "as before" >> 2. A tree that is modified during the transformation, rais

Re: RFR: JDK-8298405: Support Markdown in Documentation Comments [v18]

2024-02-06 Thread Jonathan Gibbons
On Tue, 6 Feb 2024 19:57:45 GMT, Jonathan Gibbons wrote: >> Uugh. Noted. > > There are two cases that need consideration: > 1. A tree that is not modified during the transformation, as in the test case > here, so that all nodes should be "as before" > 2. A tree that is modified during the trans

Re: RFR: JDK-8298405: Support Markdown in Documentation Comments [v18]

2024-02-06 Thread Jonathan Gibbons
On Tue, 6 Feb 2024 19:27:55 GMT, Jonathan Gibbons wrote: >> src/jdk.internal.md/share/classes/jdk/internal/markdown/MarkdownTransformer.java >> line 1: >> >>> 1: /* >> >> This transformer seems to break positions of the `RawTextTree`. >> For javadoc like: >> >> /// Mar

Re: RFR: JDK-8298405: Support Markdown in Documentation Comments [v18]

2024-02-06 Thread Jonathan Gibbons
On Tue, 6 Feb 2024 07:08:13 GMT, Jan Lahoda wrote: >> Jonathan Gibbons has updated the pull request incrementally with one >> additional commit since the last revision: >> >> First pass at remove DocCommentTransformer from the public API. >> >> It is still declared internally, and instal

Re: RFR: JDK-8298405: Support Markdown in Documentation Comments [v18]

2024-02-05 Thread Jan Lahoda
On Tue, 6 Feb 2024 01:36:58 GMT, Jonathan Gibbons wrote: >> Please review a patch to add support for Markdown syntax in documentation >> comments, as described in the associated JEP. >> >> Notable features: >> >> * support for `///` documentation comments in `JavaTokenizer` >> * new module `jd

Re: RFR: JDK-8298405: Support Markdown in Documentation Comments [v18]

2024-02-05 Thread Jonathan Gibbons
> Please review a patch to add support for Markdown syntax in documentation > comments, as described in the associated JEP. > > Notable features: > > * support for `///` documentation comments in `JavaTokenizer` > * new module `jdk.internal.md` -- a private copy of the `commonmark-java` > libra