Re: RFR: JDK-8298445: Add LeakSanitizer support in HotSpot [v2]

2023-02-03 Thread Justin King
On Fri, 3 Feb 2023 06:16:06 GMT, Thomas Stuefe wrote: > Thanks for the explanation. Do I understand correctly: You register address > ranges with LSAN, and at certain points (program exit?) the memory is > examined for pointers that point still to unreleased memory? Does LSAN > instrument

Re: RFR: JDK-8298445: Add LeakSanitizer support in HotSpot [v2]

2023-02-02 Thread Thomas Stuefe
On Thu, 2 Feb 2023 06:34:56 GMT, Thomas Stuefe wrote: >> Justin King has updated the pull request incrementally with one additional >> commit since the last revision: >> >> Support CDS >> >> Signed-off-by: Justin King > > Thinking this through some more: > > Why would

Re: RFR: JDK-8298445: Add LeakSanitizer support in HotSpot [v2]

2023-02-02 Thread Justin King
On Thu, 2 Feb 2023 06:34:56 GMT, Thomas Stuefe wrote: >> Justin King has updated the pull request incrementally with one additional >> commit since the last revision: >> >> Support CDS >> >> Signed-off-by: Justin King > > Thinking this through some more: > > Why would

Re: RFR: JDK-8298445: Add LeakSanitizer support in HotSpot [v2]

2023-02-02 Thread Justin King
On Thu, 2 Feb 2023 06:06:04 GMT, David Holmes wrote: >> src/hotspot/share/runtime/arguments.cpp line 3979: >> >>> 3977: // LSAN relies on pointers to be natively aligned. Using compressed >>> class pointers breaks this >>> 3978: // expectation and results in nondeterministic leak reports.

Re: RFR: JDK-8298445: Add LeakSanitizer support in HotSpot [v2]

2023-02-02 Thread Justin King
On Thu, 2 Feb 2023 05:34:57 GMT, David Holmes wrote: >> Justin King has updated the pull request incrementally with one additional >> commit since the last revision: >> >> Support CDS >> >> Signed-off-by: Justin King > > make/data/lsan/lsan_default_options.c line 49: > >> 47: //

Re: RFR: JDK-8298445: Add LeakSanitizer support in HotSpot [v2]

2023-02-01 Thread Thomas Stuefe
On Wed, 1 Feb 2023 15:26:27 GMT, Justin King wrote: >> Adds initial LSan (LeakSanitizer) support to Hotspot. This setup has been >> used to identify multiple leaks so far. It can run most of the test suite >> except those that rely on testing compressed oops or compressed class >> pointers.

Re: RFR: JDK-8298445: Add LeakSanitizer support in HotSpot [v2]

2023-02-01 Thread Thomas Stuefe
On Wed, 1 Feb 2023 15:26:27 GMT, Justin King wrote: >> Adds initial LSan (LeakSanitizer) support to Hotspot. This setup has been >> used to identify multiple leaks so far. It can run most of the test suite >> except those that rely on testing compressed oops or compressed class >> pointers.

Re: RFR: JDK-8298445: Add LeakSanitizer support in HotSpot [v2]

2023-02-01 Thread David Holmes
On Thu, 2 Feb 2023 06:01:04 GMT, David Holmes wrote: >> Justin King has updated the pull request incrementally with one additional >> commit since the last revision: >> >> Support CDS >> >> Signed-off-by: Justin King > > src/hotspot/share/runtime/arguments.cpp line 3979: > >> 3977:

Re: RFR: JDK-8298445: Add LeakSanitizer support in HotSpot [v2]

2023-02-01 Thread David Holmes
On Wed, 1 Feb 2023 15:26:27 GMT, Justin King wrote: >> Adds initial LSan (LeakSanitizer) support to Hotspot. This setup has been >> used to identify multiple leaks so far. It can run most of the test suite >> except those that rely on testing compressed oops or compressed class >> pointers.

Re: RFR: JDK-8298445: Add LeakSanitizer support in HotSpot [v2]

2023-02-01 Thread Justin King
> Adds initial LSan (LeakSanitizer) support to Hotspot. This setup has been > used to identify multiple leaks so far. It can run most of the test suite > except those that rely on testing compressed oops or compressed class > pointers. It is especially useful when combined with ASan, as LSan