Re: RFR: JDK-8298445: Add LeakSanitizer support in HotSpot [v6]

2023-02-08 Thread David Holmes
On Wed, 8 Feb 2023 13:37:04 GMT, Magnus Ihse Bursie wrote: >> Justin King has updated the pull request incrementally with one additional >> commit since the last revision: >> >> Revert changes to JDK >> >> Signed-off-by: Justin King > > I apologize, the fault lies entirely with me.

Re: RFR: JDK-8298445: Add LeakSanitizer support in HotSpot [v6]

2023-02-08 Thread Thomas Stuefe
On Wed, 8 Feb 2023 15:39:17 GMT, Justin King wrote: > > I read through your explanation, and through the [design > > docs](https://github.com/google/sanitizers/wiki/AddressSanitizerLeakSanitizerDesignDocument), > > but my question remains unanswered. See below. > > > > Metaspace objects hold

Re: RFR: JDK-8298445: Add LeakSanitizer support in HotSpot [v6]

2023-02-08 Thread Justin King
On Wed, 8 Feb 2023 06:58:52 GMT, Thomas Stuefe wrote: > I read through your explanation, and through the [design > docs](https://github.com/google/sanitizers/wiki/AddressSanitizerLeakSanitizerDesignDocument), > but my question remains unanswered. See below. > > > > Metaspace objects hold

Re: RFR: JDK-8298445: Add LeakSanitizer support in HotSpot [v6]

2023-02-08 Thread Justin King
On Wed, 8 Feb 2023 06:45:28 GMT, Thomas Stuefe wrote: > The informal rule is that ongoing discussions should be closed and that > nobody strongly objects to a change. Two reviewers are easy to come by. The > point of this rule is that you have a reasonable chance to block changes you >

Re: RFR: JDK-8298445: Add LeakSanitizer support in HotSpot [v6]

2023-02-08 Thread Magnus Ihse Bursie
On Tue, 7 Feb 2023 15:40:34 GMT, Justin King wrote: >> Adds initial LSan (LeakSanitizer) support to Hotspot. This setup has been >> used to identify multiple leaks so far. It can run most of the test suite >> except those that also fail with ASan, which is being looked at separately. >> It is

Re: RFR: JDK-8298445: Add LeakSanitizer support in HotSpot [v6]

2023-02-07 Thread Thomas Stuefe
On Tue, 7 Feb 2023 15:40:34 GMT, Justin King wrote: >> Adds initial LSan (LeakSanitizer) support to Hotspot. This setup has been >> used to identify multiple leaks so far. It can run most of the test suite >> except those that also fail with ASan, which is being looked at separately. >> It is

Re: RFR: JDK-8298445: Add LeakSanitizer support in HotSpot [v6]

2023-02-07 Thread Thomas Stuefe
On Wed, 8 Feb 2023 03:11:32 GMT, Justin King wrote: > > The bot can only check the required number of Reviewers (strictly 1 per > > OpenJDK rules but changeable as here via `/reviewers` command) but it > > doesn't know about the informal rules such as having reviewers from each > > affected

Re: RFR: JDK-8298445: Add LeakSanitizer support in HotSpot [v6]

2023-02-07 Thread Justin King
On Wed, 8 Feb 2023 02:53:51 GMT, David Holmes wrote: > The bot can only check the required number of Reviewers (strictly 1 per > OpenJDK rules but changeable as here via `/reviewers` command) but it doesn't > know about the informal rules such as having reviewers from each affected > area

Re: RFR: JDK-8298445: Add LeakSanitizer support in HotSpot [v6]

2023-02-07 Thread David Holmes
On Tue, 7 Feb 2023 15:40:34 GMT, Justin King wrote: >> Adds initial LSan (LeakSanitizer) support to Hotspot. This setup has been >> used to identify multiple leaks so far. It can run most of the test suite >> except those that also fail with ASan, which is being looked at separately. >> It is

Re: RFR: JDK-8298445: Add LeakSanitizer support in HotSpot [v6]

2023-02-07 Thread Justin King
On Tue, 7 Feb 2023 15:40:34 GMT, Justin King wrote: >> Adds initial LSan (LeakSanitizer) support to Hotspot. This setup has been >> used to identify multiple leaks so far. It can run most of the test suite >> except those that also fail with ASan, which is being looked at separately. >> It is

Re: RFR: JDK-8298445: Add LeakSanitizer support in HotSpot [v6]

2023-02-07 Thread Justin King
> Adds initial LSan (LeakSanitizer) support to Hotspot. This setup has been > used to identify multiple leaks so far. It can run most of the test suite > except those that also fail with ASan, which is being looked at separately. > It is especially useful when combined with ASan, as LSan can