Re: RFR: JDK-8307063: When cross-compiling with hsdis/binutils, buildjdk creation fails [v2]

2023-04-27 Thread Antonios Printezis
On Thu, 27 Apr 2023 20:37:11 GMT, Erik Joelsson wrote: >> Antonios Printezis has updated the pull request incrementally with one >> additional commit since the last revision: >> >> changes based on Erik's feedback > > make/autoconf/buildjdk-spec.gmk.in line 109: > >> 107: # hsdis is not

Re: RFR: JDK-8307063: When cross-compiling with hsdis/binutils, buildjdk creation fails [v2]

2023-04-27 Thread Erik Joelsson
On Thu, 27 Apr 2023 20:08:29 GMT, Antonios Printezis wrote: >> Fix is to exclude hsdis when building the buildjdk. > > Antonios Printezis has updated the pull request incrementally with one > additional commit since the last revision: > > changes based on Erik's feedback

Re: RFR: JDK-8307063: When cross-compiling with hsdis/binutils, buildjdk creation fails [v2]

2023-04-27 Thread Antonios Printezis
> Fix is to exclude hsdis when building the buildjdk. Antonios Printezis has updated the pull request incrementally with one additional commit since the last revision: changes based on Erik's feedback - Changes: - all: https://git.openjdk.org/jdk/pull/13697/files - new:

Re: RFR: JDK-8307063: When cross-compiling with hsdis/binutils, buildjdk creation fails [v2]

2023-04-27 Thread Antonios Printezis
On Thu, 27 Apr 2023 18:19:49 GMT, Erik Joelsson wrote: >> Antonios Printezis has updated the pull request incrementally with one >> additional commit since the last revision: >> >> changes based on Erik's feedback > > This looks like it should work, but I would like to avoid sprinkling any