Re: RFR: JDK-8312466: /bin/nm usage in AIX makes needs -X64 flag [v2]

On Wed, 26 Jul 2023 10:29:25 GMT, Andreas Steiner wrote: >> On AIX the 'nm' needs -X64 option. > > Andreas Steiner has updated the pull request incrementally with one > additional commit since the last revision: > > correction of comment Marked as reviewed by jwaters (Committer).

Re: RFR: JDK-8312466: /bin/nm usage in AIX makes needs -X64 flag [v2]

On Wed, 26 Jul 2023 10:29:25 GMT, Andreas Steiner wrote: >> On AIX the 'nm' needs -X64 option. > > Andreas Steiner has updated the pull request incrementally with one > additional commit since the last revision: > > correction of comment There might be room for improvement for the general

Re: RFR: JDK-8312466: /bin/nm usage in AIX makes needs -X64 flag [v2]

On Wed, 26 Jul 2023 14:18:49 GMT, Matthias Baesken wrote: > > OTOH, this cleanup could be done in another PR. For now, the code as it is > > would be ok, too. > > I agree, let's do the flags / macro adjustment in another issue. Andreas, I > can open one for you if you want. I would prefer to

Re: RFR: JDK-8312466: /bin/nm usage in AIX makes needs -X64 flag [v2]

On Wed, 26 Jul 2023 14:15:25 GMT, Christoph Langer wrote: > OTOH, this cleanup could be done in another PR. For now, the code as it is > would be ok, too. I agree, let's do the flags / macro adjustment in another issue. Andreas, I can open one for you if you want. - PR Comment:

Re: RFR: JDK-8312466: /bin/nm usage in AIX makes needs -X64 flag [v2]

On Wed, 26 Jul 2023 10:29:25 GMT, Andreas Steiner wrote: >> On AIX the 'nm' needs -X64 option. > > Andreas Steiner has updated the pull request incrementally with one > additional commit since the last revision: > > correction of comment No, I don't think flags-other.m4 is suited. If at

Re: RFR: JDK-8312466: /bin/nm usage in AIX makes needs -X64 flag [v2]

On Wed, 26 Jul 2023 10:29:25 GMT, Andreas Steiner wrote: >> On AIX the 'nm' needs -X64 option. > > Andreas Steiner has updated the pull request incrementally with one > additional commit since the last revision: > > correction of comment Rather than toolchain.m4, this might actually be

Re: RFR: JDK-8312466: /bin/nm usage in AIX makes needs -X64 flag [v2]

On Wed, 26 Jul 2023 12:10:51 GMT, David Holmes wrote: > I don't think this is the right place to make this change. Shouldn't it be > handled at configure time in ./autoconf/toolchain.m4 ? There is also a > BUILD_NM variable that will not be fixed by the proposed change. Currently all needed

Re: RFR: JDK-8312466: /bin/nm usage in AIX makes needs -X64 flag [v2]

On Wed, 26 Jul 2023 10:29:25 GMT, Andreas Steiner wrote: >> On AIX the 'nm' needs -X64 option. > > Andreas Steiner has updated the pull request incrementally with one > additional commit since the last revision: > > correction of comment I agree, this should be handled in toochain.m4

Re: RFR: JDK-8312466: /bin/nm usage in AIX makes needs -X64 flag [v2]

On Wed, 26 Jul 2023 10:29:25 GMT, Andreas Steiner wrote: >> On AIX the 'nm' needs -X64 option. > > Andreas Steiner has updated the pull request incrementally with one > additional commit since the last revision: > > correction of comment I don't think this is the right place to make this

Re: RFR: JDK-8312466: /bin/nm usage in AIX makes needs -X64 flag [v2]

On Wed, 26 Jul 2023 10:29:25 GMT, Andreas Steiner wrote: >> On AIX the 'nm' needs -X64 option. > > Andreas Steiner has updated the pull request incrementally with one > additional commit since the last revision: > > correction of comment +1 - Marked as reviewed by stuefe

Re: RFR: JDK-8312466: /bin/nm usage in AIX makes needs -X64 flag [v2]

On Wed, 26 Jul 2023 10:29:25 GMT, Andreas Steiner wrote: >> On AIX the 'nm' needs -X64 option. > > Andreas Steiner has updated the pull request incrementally with one > additional commit since the last revision: > > correction of comment Marked as reviewed by mbaesken (Reviewer).

Re: RFR: JDK-8312466: /bin/nm usage in AIX makes needs -X64 flag [v2]

> On AIX the 'nm' needs -X64 option. Andreas Steiner has updated the pull request incrementally with one additional commit since the last revision: correction of comment - Changes: - all: https://git.openjdk.org/jdk/pull/15036/files - new: