Re: RFR: JDK-8313244: NM flags handling in configure process [v2]

2023-08-07 Thread Christoph Langer
On Fri, 4 Aug 2023 14:42:37 GMT, Andreas Steiner wrote: > > make/common/NativeCompilation.gmk uses NM too, is there a reason to avoid > > the flag there? flags-other.m4 : the comment 'on AIX ...' is just stating > > the obvious; maybe it should better mention that without -X64 we only > >

Re: RFR: JDK-8313244: NM flags handling in configure process [v2]

2023-08-04 Thread Andreas Steiner
On Fri, 4 Aug 2023 12:35:20 GMT, Matthias Baesken wrote: > make/common/NativeCompilation.gmk uses NM too, is there a reason to avoid the > flag there? flags-other.m4 : the comment 'on AIX ...' is just stating the > obvious; maybe it should better mention that without -X64 we only process >

Re: RFR: JDK-8313244: NM flags handling in configure process [v2]

2023-08-04 Thread Matthias Baesken
On Fri, 4 Aug 2023 11:17:43 GMT, Andreas Steiner wrote: >> On AIX we need the -X64 option for NM in the build. The handling is >> equivalent to the other used tools flags like AR. >> This change will replace the quick fix done in >> https://bugs.openjdk.org/browse/JDK-8312466. > > Andreas

Re: RFR: JDK-8313244: NM flags handling in configure process [v2]

2023-08-04 Thread Andreas Steiner
On Fri, 4 Aug 2023 09:50:44 GMT, Christoph Langer wrote: >> Andreas Steiner has updated the pull request incrementally with one >> additional commit since the last revision: >> >> remove needless else > > make/autoconf/flags-other.m4 line 96: > >> 94: if test "x$OPENJDK_TARGET_OS" = xaix;

Re: RFR: JDK-8313244: NM flags handling in configure process [v2]

2023-08-04 Thread Andreas Steiner
> On AIX we need the -X64 option for NM in the build. The handling is > equivalent to the other used tools flags like AR. > This change will replace the quick fix done in > https://bugs.openjdk.org/browse/JDK-8312466. Andreas Steiner has updated the pull request incrementally with one