Re: RFR: JDK-8317799 : AIX PPC64: FFI symbol lookup doesn't find symbols [v6]

2023-11-21 Thread Martin Doerr
On Tue, 21 Nov 2023 17:49:43 GMT, suchismith1993 wrote: >> The math library in AIX specifically, is a static archive. Doing a -lm wont >> suffice, because when the symbols are looked up using dlsym or accessing >> native code through Java, it will lead to failures. >> Hence we had to come up

Re: RFR: JDK-8317799 : AIX PPC64: FFI symbol lookup doesn't find symbols [v6]

2023-11-21 Thread Martin Doerr
On Tue, 21 Nov 2023 17:54:08 GMT, suchismith1993 wrote: >> src/java.base/aix/native/libsyslookup/syslookup.c line 30: >> >>> 28: #include >>> 29: #include >>> 30: #include >> >> Are string.h and stdlib.h needed? I can't see them in the comments below. > > string.h is needed for strlen. Let

Re: RFR: JDK-8317799 : AIX PPC64: FFI symbol lookup doesn't find symbols [v6]

2023-11-21 Thread suchismith1993
On Tue, 21 Nov 2023 17:50:04 GMT, Martin Doerr wrote: >> suchismith1993 has updated the pull request incrementally with two >> additional commits since the last revision: >> >> - Comments >> - Change comments > > src/java.base/aix/native/libsyslookup/syslookup.c line 30: > >> 28: #include

Re: RFR: JDK-8317799 : AIX PPC64: FFI symbol lookup doesn't find symbols [v6]

2023-11-21 Thread suchismith1993
> The math library in AIX specifically, is a static archive. Doing a -lm wont > suffice, because when the symbols are looked up using dlsym or accessing > native code through Java, it will lead to failures. > Hence we had to come up with a list of symbols to allow math library symbols > to be