On Tue, 21 Nov 2023 17:50:04 GMT, Martin Doerr <mdo...@openjdk.org> wrote:
>> suchismith1993 has updated the pull request incrementally with two >> additional commits since the last revision: >> >> - Comments >> - Change comments > > src/java.base/aix/native/libsyslookup/syslookup.c line 30: > >> 28: #include <stdio.h> >> 29: #include <string.h> >> 30: #include <stdlib.h> > > Are string.h and stdlib.h needed? I can't see them in the comments below. string.h is needed for strlen. Let me check for stdlib.h by excluding it. > src/java.base/aix/native/libsyslookup/syslookup.c line 33: > >> 31: #include <math.h> >> 32: >> 33: // Addresses of functions to referenced using static linking. > > What does "functions to referenced" mean? Typo? To be Referenced*. Is that the right comment ? ------------- PR Review Comment: https://git.openjdk.org/jdk/pull/16414#discussion_r1400964039 PR Review Comment: https://git.openjdk.org/jdk/pull/16414#discussion_r1400964522
