Re: RFR: JDK-8320458: Improve structural navigation in API documentation [v6]

2024-01-18 Thread Jonathan Gibbons
On Thu, 18 Jan 2024 16:25:49 GMT, Hannes Wallnöfer wrote: >> This is a rather big change to update the structural navigation in API >> documentation generated by JavaDoc. It adds a table of contents for the >> current page to module, package, and class documentation, and replaces the >> old

Re: RFR: JDK-8320458: Improve structural navigation in API documentation [v6]

2024-01-18 Thread Hannes Wallnöfer
> This is a rather big change to update the structural navigation in API > documentation generated by JavaDoc. It adds a table of contents for the > current page to module, package, and class documentation, and replaces the > old sub-navigation bar with a breadcrumb-style links in those pages.

Re: RFR: JDK-8320458: Improve structural navigation in API documentation [v5]

2024-01-18 Thread Hannes Wallnöfer
> This is a rather big change to update the structural navigation in API > documentation generated by JavaDoc. It adds a table of contents for the > current page to module, package, and class documentation, and replaces the > old sub-navigation bar with a breadcrumb-style links in those pages.

Re: RFR: JDK-8320458: Improve structural navigation in API documentation [v4]

2024-01-18 Thread Hannes Wallnöfer
On Tue, 16 Jan 2024 19:47:47 GMT, Jonathan Gibbons wrote: > * Medium-size suggestion/question: > consider init-ing `HtmlDocletWriter.tableOfContents` directly in the > constructor for `HtmlDocletWriter` and not in the constructors for the > subtypes. I agree it would be nice, but

Re: RFR: JDK-8320458: Improve structural navigation in API documentation [v4]

2024-01-18 Thread Hannes Wallnöfer
On Tue, 16 Jan 2024 19:46:30 GMT, Jonathan Gibbons wrote: >> Hannes Wallnöfer has updated the pull request incrementally with one >> additional commit since the last revision: >> >> Consolidate TOC functionality into new TableOfContents class > >

Re: RFR: JDK-8320458: Improve structural navigation in API documentation [v4]

2024-01-18 Thread Hannes Wallnöfer
On Tue, 16 Jan 2024 19:26:21 GMT, Jonathan Gibbons wrote: >> Hannes Wallnöfer has updated the pull request incrementally with one >> additional commit since the last revision: >> >> Consolidate TOC functionality into new TableOfContents class > >

Re: RFR: JDK-8320458: Improve structural navigation in API documentation [v4]

2024-01-16 Thread Jonathan Gibbons
On Fri, 12 Jan 2024 18:52:46 GMT, Hannes Wallnöfer wrote: >> This is a rather big change to update the structural navigation in API >> documentation generated by JavaDoc. It adds a table of contents for the >> current page to module, package, and class documentation, and replaces the >> old

Re: RFR: JDK-8320458: Improve structural navigation in API documentation [v4]

2024-01-16 Thread Jonathan Gibbons
On Fri, 12 Jan 2024 18:52:46 GMT, Hannes Wallnöfer wrote: >> This is a rather big change to update the structural navigation in API >> documentation generated by JavaDoc. It adds a table of contents for the >> current page to module, package, and class documentation, and replaces the >> old

Re: RFR: JDK-8320458: Improve structural navigation in API documentation [v4]

2024-01-16 Thread Jonathan Gibbons
On Fri, 12 Jan 2024 18:52:46 GMT, Hannes Wallnöfer wrote: >> This is a rather big change to update the structural navigation in API >> documentation generated by JavaDoc. It adds a table of contents for the >> current page to module, package, and class documentation, and replaces the >> old

Re: RFR: JDK-8320458: Improve structural navigation in API documentation [v4]

2024-01-16 Thread Jonathan Gibbons
On Fri, 12 Jan 2024 18:52:46 GMT, Hannes Wallnöfer wrote: >> This is a rather big change to update the structural navigation in API >> documentation generated by JavaDoc. It adds a table of contents for the >> current page to module, package, and class documentation, and replaces the >> old

Re: RFR: JDK-8320458: Improve structural navigation in API documentation [v2]

2024-01-16 Thread Jonathan Gibbons
On Thu, 11 Jan 2024 14:46:10 GMT, Hannes Wallnöfer wrote: >> src/jdk.javadoc/share/classes/jdk/javadoc/internal/doclets/formats/html/resources/script.js.template >> line 1: >> >>> 1: /* >> >> I note that at least in part this is a rename of `script.js` (and rightly >> so) that Git has failed

Re: RFR: JDK-8320458: Improve structural navigation in API documentation [v4]

2024-01-12 Thread Hannes Wallnöfer
On Fri, 12 Jan 2024 18:52:46 GMT, Hannes Wallnöfer wrote: >> This is a rather big change to update the structural navigation in API >> documentation generated by JavaDoc. It adds a table of contents for the >> current page to module, package, and class documentation, and replaces the >> old

Re: RFR: JDK-8320458: Improve structural navigation in API documentation [v4]

2024-01-12 Thread Hannes Wallnöfer
> This is a rather big change to update the structural navigation in API > documentation generated by JavaDoc. It adds a table of contents for the > current page to module, package, and class documentation, and replaces the > old sub-navigation bar with a breadcrumb-style links in those pages.

Re: RFR: JDK-8320458: Improve structural navigation in API documentation [v3]

2024-01-11 Thread Hannes Wallnöfer
> This is a rather big change to update the structural navigation in API > documentation generated by JavaDoc. It adds a table of contents for the > current page to module, package, and class documentation, and replaces the > old sub-navigation bar with a breadcrumb-style links in those pages.

Re: RFR: JDK-8320458: Improve structural navigation in API documentation [v2]

2024-01-11 Thread Hannes Wallnöfer
On Tue, 9 Jan 2024 23:44:51 GMT, Jonathan Gibbons wrote: >> Hannes Wallnöfer has updated the pull request incrementally with one >> additional commit since the last revision: >> >> Update >> src/jdk.javadoc/share/classes/jdk/javadoc/internal/doclets/formats/html/HtmlDocletWriter.java >>

Re: RFR: JDK-8320458: Improve structural navigation in API documentation [v2]

2024-01-11 Thread Hannes Wallnöfer
On Wed, 10 Jan 2024 00:01:35 GMT, Jonathan Gibbons wrote: >> Hannes Wallnöfer has updated the pull request incrementally with one >> additional commit since the last revision: >> >> Update >> src/jdk.javadoc/share/classes/jdk/javadoc/internal/doclets/formats/html/HtmlDocletWriter.java >>

Re: RFR: JDK-8320458: Improve structural navigation in API documentation [v2]

2024-01-11 Thread Hannes Wallnöfer
On Tue, 9 Jan 2024 23:07:17 GMT, Jonathan Gibbons wrote: >> Hannes Wallnöfer has updated the pull request incrementally with one >> additional commit since the last revision: >> >> Update >> src/jdk.javadoc/share/classes/jdk/javadoc/internal/doclets/formats/html/HtmlDocletWriter.java >>

Re: RFR: JDK-8320458: Improve structural navigation in API documentation [v2]

2024-01-11 Thread Hannes Wallnöfer
On Tue, 9 Jan 2024 23:12:51 GMT, Jonathan Gibbons wrote: >> Hannes Wallnöfer has updated the pull request incrementally with one >> additional commit since the last revision: >> >> Update >> src/jdk.javadoc/share/classes/jdk/javadoc/internal/doclets/formats/html/HtmlDocletWriter.java >>

Re: RFR: JDK-8320458: Improve structural navigation in API documentation [v2]

2024-01-11 Thread Hannes Wallnöfer
On Wed, 10 Jan 2024 23:46:57 GMT, Jonathan Gibbons wrote: >> Hannes Wallnöfer has updated the pull request incrementally with one >> additional commit since the last revision: >> >> Update >> src/jdk.javadoc/share/classes/jdk/javadoc/internal/doclets/formats/html/HtmlDocletWriter.java >>

Re: RFR: JDK-8320458: Improve structural navigation in API documentation [v2]

2024-01-10 Thread Jonathan Gibbons
On Wed, 3 Jan 2024 12:36:15 GMT, Hannes Wallnöfer wrote: >> This is a rather big change to update the structural navigation in API >> documentation generated by JavaDoc. It adds a table of contents for the >> current page to module, package, and class documentation, and replaces the >> old

Re: RFR: JDK-8320458: Improve structural navigation in API documentation [v2]

2024-01-10 Thread Jonathan Gibbons
On Wed, 3 Jan 2024 12:36:15 GMT, Hannes Wallnöfer wrote: >> This is a rather big change to update the structural navigation in API >> documentation generated by JavaDoc. It adds a table of contents for the >> current page to module, package, and class documentation, and replaces the >> old

Re: RFR: JDK-8320458: Improve structural navigation in API documentation [v2]

2024-01-10 Thread Jonathan Gibbons
On Wed, 3 Jan 2024 12:36:15 GMT, Hannes Wallnöfer wrote: >> This is a rather big change to update the structural navigation in API >> documentation generated by JavaDoc. It adds a table of contents for the >> current page to module, package, and class documentation, and replaces the >> old

Re: RFR: JDK-8320458: Improve structural navigation in API documentation [v2]

2024-01-10 Thread Jonathan Gibbons
On Wed, 3 Jan 2024 12:36:15 GMT, Hannes Wallnöfer wrote: >> This is a rather big change to update the structural navigation in API >> documentation generated by JavaDoc. It adds a table of contents for the >> current page to module, package, and class documentation, and replaces the >> old

Re: RFR: JDK-8320458: Improve structural navigation in API documentation [v2]

2024-01-10 Thread Jonathan Gibbons
On Wed, 3 Jan 2024 12:36:15 GMT, Hannes Wallnöfer wrote: >> This is a rather big change to update the structural navigation in API >> documentation generated by JavaDoc. It adds a table of contents for the >> current page to module, package, and class documentation, and replaces the >> old

Re: RFR: JDK-8320458: Improve structural navigation in API documentation [v2]

2024-01-10 Thread Jonathan Gibbons
On Wed, 3 Jan 2024 12:36:15 GMT, Hannes Wallnöfer wrote: >> This is a rather big change to update the structural navigation in API >> documentation generated by JavaDoc. It adds a table of contents for the >> current page to module, package, and class documentation, and replaces the >> old

Re: RFR: JDK-8320458: Improve structural navigation in API documentation [v2]

2024-01-09 Thread Jonathan Gibbons
On Wed, 3 Jan 2024 12:36:15 GMT, Hannes Wallnöfer wrote: >> This is a rather big change to update the structural navigation in API >> documentation generated by JavaDoc. It adds a table of contents for the >> current page to module, package, and class documentation, and replaces the >> old

Re: RFR: JDK-8320458: Improve structural navigation in API documentation [v2]

2024-01-09 Thread Jonathan Gibbons
On Wed, 3 Jan 2024 12:36:15 GMT, Hannes Wallnöfer wrote: >> This is a rather big change to update the structural navigation in API >> documentation generated by JavaDoc. It adds a table of contents for the >> current page to module, package, and class documentation, and replaces the >> old

Re: RFR: JDK-8320458: Improve structural navigation in API documentation [v2]

2024-01-09 Thread Jonathan Gibbons
On Wed, 3 Jan 2024 12:36:15 GMT, Hannes Wallnöfer wrote: >> This is a rather big change to update the structural navigation in API >> documentation generated by JavaDoc. It adds a table of contents for the >> current page to module, package, and class documentation, and replaces the >> old

Re: RFR: JDK-8320458: Improve structural navigation in API documentation [v2]

2024-01-09 Thread Jonathan Gibbons
On Wed, 3 Jan 2024 12:36:15 GMT, Hannes Wallnöfer wrote: >> This is a rather big change to update the structural navigation in API >> documentation generated by JavaDoc. It adds a table of contents for the >> current page to module, package, and class documentation, and replaces the >> old

Re: RFR: JDK-8320458: Improve structural navigation in API documentation [v2]

2024-01-09 Thread Jonathan Gibbons
On Wed, 3 Jan 2024 12:36:15 GMT, Hannes Wallnöfer wrote: >> This is a rather big change to update the structural navigation in API >> documentation generated by JavaDoc. It adds a table of contents for the >> current page to module, package, and class documentation, and replaces the >> old

Re: RFR: JDK-8320458: Improve structural navigation in API documentation [v2]

2024-01-09 Thread Jonathan Gibbons
On Wed, 3 Jan 2024 12:36:15 GMT, Hannes Wallnöfer wrote: >> This is a rather big change to update the structural navigation in API >> documentation generated by JavaDoc. It adds a table of contents for the >> current page to module, package, and class documentation, and replaces the >> old

Re: RFR: JDK-8320458: Improve structural navigation in API documentation [v2]

2024-01-09 Thread Jonathan Gibbons
On Wed, 3 Jan 2024 12:36:15 GMT, Hannes Wallnöfer wrote: >> This is a rather big change to update the structural navigation in API >> documentation generated by JavaDoc. It adds a table of contents for the >> current page to module, package, and class documentation, and replaces the >> old

Re: RFR: JDK-8320458: Improve structural navigation in API documentation [v2]

2024-01-08 Thread Jonathan Gibbons
On Wed, 3 Jan 2024 12:36:15 GMT, Hannes Wallnöfer wrote: >> This is a rather big change to update the structural navigation in API >> documentation generated by JavaDoc. It adds a table of contents for the >> current page to module, package, and class documentation, and replaces the >> old

Re: RFR: JDK-8320458: Improve structural navigation in API documentation [v2]

2024-01-08 Thread Jonathan Gibbons
On Wed, 3 Jan 2024 12:36:15 GMT, Hannes Wallnöfer wrote: >> This is a rather big change to update the structural navigation in API >> documentation generated by JavaDoc. It adds a table of contents for the >> current page to module, package, and class documentation, and replaces the >> old

Re: RFR: JDK-8320458: Improve structural navigation in API documentation [v2]

2024-01-08 Thread Jonathan Gibbons
On Wed, 3 Jan 2024 12:36:15 GMT, Hannes Wallnöfer wrote: >> This is a rather big change to update the structural navigation in API >> documentation generated by JavaDoc. It adds a table of contents for the >> current page to module, package, and class documentation, and replaces the >> old

Re: RFR: JDK-8320458: Improve structural navigation in API documentation [v2]

2024-01-08 Thread Jonathan Gibbons
On Wed, 3 Jan 2024 12:36:15 GMT, Hannes Wallnöfer wrote: >> This is a rather big change to update the structural navigation in API >> documentation generated by JavaDoc. It adds a table of contents for the >> current page to module, package, and class documentation, and replaces the >> old

Re: RFR: JDK-8320458: Improve structural navigation in API documentation [v2]

2024-01-08 Thread Jonathan Gibbons
On Wed, 3 Jan 2024 12:36:15 GMT, Hannes Wallnöfer wrote: >> This is a rather big change to update the structural navigation in API >> documentation generated by JavaDoc. It adds a table of contents for the >> current page to module, package, and class documentation, and replaces the >> old

Re: RFR: JDK-8320458: Improve structural navigation in API documentation [v2]

2024-01-08 Thread Jonathan Gibbons
On Wed, 3 Jan 2024 12:36:15 GMT, Hannes Wallnöfer wrote: >> This is a rather big change to update the structural navigation in API >> documentation generated by JavaDoc. It adds a table of contents for the >> current page to module, package, and class documentation, and replaces the >> old

Re: RFR: JDK-8320458: Improve structural navigation in API documentation [v2]

2024-01-08 Thread Jonathan Gibbons
On Wed, 3 Jan 2024 12:36:15 GMT, Hannes Wallnöfer wrote: >> This is a rather big change to update the structural navigation in API >> documentation generated by JavaDoc. It adds a table of contents for the >> current page to module, package, and class documentation, and replaces the >> old

Re: RFR: JDK-8320458: Improve structural navigation in API documentation [v2]

2024-01-08 Thread Jonathan Gibbons
On Wed, 3 Jan 2024 12:36:15 GMT, Hannes Wallnöfer wrote: >> This is a rather big change to update the structural navigation in API >> documentation generated by JavaDoc. It adds a table of contents for the >> current page to module, package, and class documentation, and replaces the >> old

Re: RFR: JDK-8320458: Improve structural navigation in API documentation [v2]

2024-01-03 Thread Hannes Wallnöfer
> This is a rather big change to update the structural navigation in API > documentation generated by JavaDoc. It adds a table of contents for the > current page to module, package, and class documentation, and replaces the > old sub-navigation bar with a breadcrumb-style links in those pages.

Re: RFR: JDK-8320458: Improve structural navigation in API documentation

2023-12-20 Thread Andrey Turbanov
On Mon, 11 Dec 2023 16:36:09 GMT, Hannes Wallnöfer wrote: > This is a rather big change to update the structural navigation in API > documentation generated by JavaDoc. It adds a table of contents for the > current page to module, package, and class documentation, and replaces the > old

Re: RFR: JDK-8320458: Improve structural navigation in API documentation

2023-12-14 Thread Erik Joelsson
On Mon, 11 Dec 2023 16:36:09 GMT, Hannes Wallnöfer wrote: > This is a rather big change to update the structural navigation in API > documentation generated by JavaDoc. It adds a table of contents for the > current page to module, package, and class documentation, and replaces the > old

Re: RFR: JDK-8320458: Improve structural navigation in API documentation

2023-12-14 Thread Jonathan Gibbons
On Mon, 11 Dec 2023 16:36:09 GMT, Hannes Wallnöfer wrote: > This is a rather big change to update the structural navigation in API > documentation generated by JavaDoc. It adds a table of contents for the > current page to module, package, and class documentation, and replaces the > old

RFR: JDK-8320458: Improve structural navigation in API documentation

2023-12-14 Thread Hannes Wallnöfer
This is a rather big change to update the structural navigation in API documentation generated by JavaDoc. It adds a table of contents for the current page to module, package, and class documentation, and replaces the old sub-navigation bar with a breadcrumb-style links in those pages. The