Re: [PATCH] ash: add bash-like ERR trap and set -E

2021-09-07 Thread Roberto A. Foglietta
Il giorno mar 7 set 2021 alle ore 21:43 Denys Vlasenko ha scritto: > > On Tue, Sep 7, 2021 at 6:26 PM Roberto A. Foglietta > wrote: > > > > Thus, using zero the busybox test suite needs to be updated. > > If you send a patch with "lineno = 0", this patch needs to also > update testsuite so that

Re: [PATCH] ash: add bash-like ERR trap and set -E

2021-09-07 Thread Denys Vlasenko
On Tue, Sep 7, 2021 at 6:26 PM Roberto A. Foglietta wrote: > Il giorno mar 7 set 2021 alle ore 18:19 Denys Vlasenko > ha scritto: > > > > Applied the part which fixes LINENO. > > > > > > // continue reading input from stdin after running 'echo'. > > // bash does

Re: [PATCH] ash: add bash-like ERR trap and set -E

2021-09-07 Thread Roberto A. Foglietta
Il giorno mar 7 set 2021 alle ore 18:19 Denys Vlasenko ha scritto: > > Applied the part which fixes LINENO. > > > // continue reading input from stdin after running 'echo'. > // bash does not do this: it prints "hBcs" and exits. > + lineno = 0; >

Re: [PATCH] ash: add bash-like ERR trap and set -E

2021-09-07 Thread Denys Vlasenko
Applied the part which fixes LINENO. // continue reading input from stdin after running 'echo'. // bash does not do this: it prints "hBcs" and exits. + lineno = 0; evalstring(minusc, EV_EXIT); } This needs existing testsuite

Re: [PATCH] ash test run-all ignores suid message

2021-09-07 Thread Denys Vlasenko
Applied after removal of unrelated changes On Tue, Sep 7, 2021 at 9:36 AM Roberto A. Foglietta wrote: > > Hi all, > > in some configurations the busybox ash print-out on stderr a message > regarding suid drop. > Unfortunately, this message is trapped by the tests handler run-all > and all

Re: chat applet goes into infinite loop when poll() returns POLLHUP or POLLERR

2021-09-07 Thread Denys Vlasenko
On Tue, Sep 7, 2021 at 2:33 PM Jörgen Pihlflyckt wrote: > Your welcome. > > Alas, I have not yet been able to verify with 100% certainity, that the patch > really works but it sure looks promising. It's slightly difficult to make the > badly behaving modems behave badly on command ;-) If they

Re: chat applet goes into infinite loop when poll() returns POLLHUP or POLLERR

2021-09-07 Thread Jörgen Pihlflyckt
Your welcome. Alas, I have not yet been able to verify with 100% certainity, that the patch really works but it sure looks promising. It's slightly difficult to make the badly behaving modems behave badly on command ;-) I'll redouble my efforts in this small but annoying matter and keep you

Re: [PATCH] ash: add bash-like ERR trap and set -E

2021-09-07 Thread Roberto A. Foglietta
Il giorno dom 5 set 2021 alle ore 23:52 Roberto A. Foglietta ha scritto: > > Il giorno dom 5 set 2021 alle ore 21:40 Denys Vlasenko > ha scritto: > > > > IIRC you want to fix other LINENO problems anyway, > > like incorrect handling of it in functions? > > Nope, at the moment all problems are

[PATCH] ash test run-all ignores suid message

2021-09-07 Thread Roberto A. Foglietta
Hi all, in some configurations the busybox ash print-out on stderr a message regarding suid drop. Unfortunately, this message is trapped by the tests handler run-all and all tests fails. The attached patch fixes the problem. Best regards, -- Roberto A. Foglietta +39.349.33.30.697